From: "Cédric Le Goater" <clg@redhat.com>
To: qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: "Kenneth Jia" <kenneth_jia@asus.com>,
"Cédric Le Goater" <clg@redhat.com>
Subject: [PULL 01/12] hw/arm/aspeed: fix connect_serial_hds_to_uarts
Date: Mon, 27 Jan 2025 10:42:28 +0100 [thread overview]
Message-ID: <20250127094239.636526-2-clg@redhat.com> (raw)
In-Reply-To: <20250127094239.636526-1-clg@redhat.com>
From: Kenneth Jia <kenneth_jia@asus.com>
In the loop, we need ignore the index increase when uart == uart_chosen
We should increase the index only after we allocate a serial.
Signed-off-by: Kenneth Jia <kenneth_jia@asus.com>
Fixes: d2b3eaefb4d7 ("aspeed: Refactor UART init for multi-SoC machines")
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Link: https://lore.kernel.org/r/5f9b0c53f1644922ba85522046e92f4c@asus.com
Signed-off-by: Cédric Le Goater <clg@redhat.com>
---
hw/arm/aspeed.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
index a18d4ed1fb10..2662465ada4f 100644
--- a/hw/arm/aspeed.c
+++ b/hw/arm/aspeed.c
@@ -364,11 +364,11 @@ static void connect_serial_hds_to_uarts(AspeedMachineState *bmc)
int uart_chosen = bmc->uart_chosen ? bmc->uart_chosen : amc->uart_default;
aspeed_soc_uart_set_chr(s, uart_chosen, serial_hd(0));
- for (int i = 1, uart = sc->uarts_base; i < sc->uarts_num; i++, uart++) {
+ for (int i = 1, uart = sc->uarts_base; i < sc->uarts_num; uart++) {
if (uart == uart_chosen) {
continue;
}
- aspeed_soc_uart_set_chr(s, uart, serial_hd(i));
+ aspeed_soc_uart_set_chr(s, uart, serial_hd(i++));
}
}
--
2.48.1
next prev parent reply other threads:[~2025-01-27 9:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-27 9:42 [PULL 00/12] aspeed queue Cédric Le Goater
2025-01-27 9:42 ` Cédric Le Goater [this message]
2025-01-27 9:42 ` [PULL 02/12] hw/sd/sdhci: Introduce a new Write Protected pin inverted property Cédric Le Goater
2025-01-27 9:42 ` [PULL 03/12] hw/arm/aspeed: Invert sdhci write protected pin for AST2600 EVB Cédric Le Goater
2025-01-27 9:42 ` [PULL 04/12] hw/timer/aspeed: Refactor Timer Callbacks for SoC-Specific Implementations Cédric Le Goater
2025-01-27 9:42 ` [PULL 05/12] hw/timer/aspeed: Add AST2700 Support Cédric Le Goater
2025-01-27 9:42 ` [PULL 06/12] aspeed/soc: Support Timer for AST2700 Cédric Le Goater
2025-01-27 9:42 ` [PULL 07/12] test/functional: Update the Aspeed aarch64 test Cédric Le Goater
2025-01-27 9:42 ` [PULL 08/12] test/functional: Update buildroot images to 2024.11 Cédric Le Goater
2025-01-27 9:42 ` [PULL 09/12] aspeed: Create sd devices only when defaults are enabled Cédric Le Goater
2025-01-27 9:42 ` [PULL 10/12] aspeed/wdt: Fix coding style Cédric Le Goater
2025-01-27 9:42 ` [PULL 11/12] aspeed/wdt: Support software reset mode for AST2600 Cédric Le Goater
2025-01-27 9:42 ` [PULL 12/12] docs/system/arm/aspeed: Remove tacoma-bmc from the documentation Cédric Le Goater
2025-01-27 19:42 ` [PULL 00/12] aspeed queue Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250127094239.636526-2-clg@redhat.com \
--to=clg@redhat.com \
--cc=kenneth_jia@asus.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).