qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: alex.bennee@linaro.org, richard.henderson@linaro.org,
	pbonzini@redhat.com, imp@bsdimp.com, kevans@freebsd.org,
	gaosong@loongson.cn, laurent@vivier.eu
Subject: [PATCH 2/6] loongarch: reset vcpu after it's created
Date: Wed, 29 Jan 2025 14:44:32 +0100	[thread overview]
Message-ID: <20250129134436.1240740-3-imammedo@redhat.com> (raw)
In-Reply-To: <20250129134436.1240740-1-imammedo@redhat.com>

Reseting vcpu before its thread is created, caused various issues in the past
for other targets. It doesn't cause issues for loongarch at the moment but
to be consistent with the rest of targets, move reset during realize time
after qemu_init_vcpu().

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
 target/loongarch/cpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/loongarch/cpu.c b/target/loongarch/cpu.c
index e91f4a5239..15018d43ae 100644
--- a/target/loongarch/cpu.c
+++ b/target/loongarch/cpu.c
@@ -634,8 +634,8 @@ static void loongarch_cpu_realizefn(DeviceState *dev, Error **errp)
 
     loongarch_cpu_register_gdb_regs_for_features(cs);
 
-    cpu_reset(cs);
     qemu_init_vcpu(cs);
+    cpu_reset(cs);
 
     lacc->parent_realize(dev, errp);
 }
-- 
2.43.0



  parent reply	other threads:[~2025-01-29 13:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-29 13:44 [PATCH 0/6] tcg: fix qemu crash when add assert_cpu_is_self() is enabled and cleanups related to cpu->created check Igor Mammedov
2025-01-29 13:44 ` [PATCH 1/6] bsd-user: drop not longer used target_reset_cpu() Igor Mammedov
2025-01-29 13:44 ` Igor Mammedov [this message]
2025-01-29 13:44 ` [PATCH 3/6] m68k: reset vcpu after it's created Igor Mammedov
2025-01-29 13:44 ` [PATCH 4/6] tcg:tlb: use tcg_debug_assert() in assert_cpu_is_self() Igor Mammedov
2025-01-31 12:19   ` Alex Bennée
2025-01-31 13:47   ` [PATCH v2 " Igor Mammedov
2025-01-29 13:44 ` [PATCH 5/6] Revert "tcg/cputlb: remove other-cpu capability from TLB flushing" Igor Mammedov
2025-01-29 18:33   ` BALATON Zoltan
2025-01-30  8:06     ` Igor Mammedov
2025-01-29 13:44 ` [PATCH 6/6] tcg: drop cpu->created check Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250129134436.1240740-3-imammedo@redhat.com \
    --to=imammedo@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=gaosong@loongson.cn \
    --cc=imp@bsdimp.com \
    --cc=kevans@freebsd.org \
    --cc=laurent@vivier.eu \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).