qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: alex.bennee@linaro.org, richard.henderson@linaro.org,
	pbonzini@redhat.com, imp@bsdimp.com, kevans@freebsd.org,
	gaosong@loongson.cn, laurent@vivier.eu
Subject: [PATCH 6/6] tcg: drop cpu->created check
Date: Wed, 29 Jan 2025 14:44:36 +0100	[thread overview]
Message-ID: <20250129134436.1240740-7-imammedo@redhat.com> (raw)
In-Reply-To: <20250129134436.1240740-1-imammedo@redhat.com>

previous commits fixed 2 remaining cases where vcpu might
have had 'cpu->created == false' during 1st vcpu reset (at realize time)
that leads to call chain
      tcg_cpu_reset_hold() => tlb_flush_by_mmuidx()

remove not need anymore check, with cpu->created always being true.

Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
 accel/tcg/cputlb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c
index db1713b3ca..f4f3965518 100644
--- a/accel/tcg/cputlb.c
+++ b/accel/tcg/cputlb.c
@@ -75,7 +75,7 @@
 } while (0)
 
 #define assert_cpu_is_self(cpu)                             \
-    tcg_debug_assert(!(cpu)->created || qemu_cpu_is_self(cpu))
+    tcg_debug_assert(qemu_cpu_is_self(cpu))
 
 /* run_on_cpu_data.target_ptr should always be big enough for a
  * vaddr even on 32 bit builds
@@ -416,7 +416,7 @@ void tlb_flush_by_mmuidx(CPUState *cpu, uint16_t idxmap)
 {
     tlb_debug("mmu_idx: 0x%" PRIx16 "\n", idxmap);
 
-    if (cpu->created && !qemu_cpu_is_self(cpu)) {
+    if (!qemu_cpu_is_self(cpu)) {
         async_run_on_cpu(cpu, tlb_flush_by_mmuidx_async_work,
                          RUN_ON_CPU_HOST_INT(idxmap));
     } else {
-- 
2.43.0



      parent reply	other threads:[~2025-01-29 13:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-29 13:44 [PATCH 0/6] tcg: fix qemu crash when add assert_cpu_is_self() is enabled and cleanups related to cpu->created check Igor Mammedov
2025-01-29 13:44 ` [PATCH 1/6] bsd-user: drop not longer used target_reset_cpu() Igor Mammedov
2025-01-29 13:44 ` [PATCH 2/6] loongarch: reset vcpu after it's created Igor Mammedov
2025-01-29 13:44 ` [PATCH 3/6] m68k: " Igor Mammedov
2025-01-29 13:44 ` [PATCH 4/6] tcg:tlb: use tcg_debug_assert() in assert_cpu_is_self() Igor Mammedov
2025-01-31 12:19   ` Alex Bennée
2025-01-31 13:47   ` [PATCH v2 " Igor Mammedov
2025-01-29 13:44 ` [PATCH 5/6] Revert "tcg/cputlb: remove other-cpu capability from TLB flushing" Igor Mammedov
2025-01-29 18:33   ` BALATON Zoltan
2025-01-30  8:06     ` Igor Mammedov
2025-01-29 13:44 ` Igor Mammedov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250129134436.1240740-7-imammedo@redhat.com \
    --to=imammedo@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=gaosong@loongson.cn \
    --cc=imp@bsdimp.com \
    --cc=kevans@freebsd.org \
    --cc=laurent@vivier.eu \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).