qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: alex.bennee@linaro.org, richard.henderson@linaro.org,
	pbonzini@redhat.com
Subject: [PATCH v2 4/6] tcg:tlb: use tcg_debug_assert() in assert_cpu_is_self()
Date: Fri, 31 Jan 2025 14:47:09 +0100	[thread overview]
Message-ID: <20250131134709.1306195-1-imammedo@redhat.com> (raw)
In-Reply-To: <20250129134436.1240740-5-imammedo@redhat.com>

that will enable assert_cpu_is_self when QEMU is configured with
   --enable-debug
without need for manual patching DEBUG_TLB_GATE define.

Need to manually path DEBUG_TLB_GATE define to enable assert,
let regression caused by [1] creep in unnoticed.

1) 30933c4fb4f3d ("tcg/cputlb: remove other-cpu capability from TLB flushing")
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Suggested-by: Alex Bennée <alex.bennee@linaro.org>
---
v2: revert DEBUG_TLB_GATE/DEBUG_TLB_LOG_GATE to 0 as it used to be
---
 accel/tcg/cputlb.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c
index b4ccf0cdcb..7380b29da3 100644
--- a/accel/tcg/cputlb.c
+++ b/accel/tcg/cputlb.c
@@ -74,11 +74,8 @@
     } \
 } while (0)
 
-#define assert_cpu_is_self(cpu) do {                              \
-        if (DEBUG_TLB_GATE) {                                     \
-            g_assert(!(cpu)->created || qemu_cpu_is_self(cpu));   \
-        }                                                         \
-    } while (0)
+#define assert_cpu_is_self(cpu)                             \
+    tcg_debug_assert(!(cpu)->created || qemu_cpu_is_self(cpu))
 
 /* run_on_cpu_data.target_ptr should always be big enough for a
  * vaddr even on 32 bit builds
-- 
2.43.0



  parent reply	other threads:[~2025-01-31 13:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-29 13:44 [PATCH 0/6] tcg: fix qemu crash when add assert_cpu_is_self() is enabled and cleanups related to cpu->created check Igor Mammedov
2025-01-29 13:44 ` [PATCH 1/6] bsd-user: drop not longer used target_reset_cpu() Igor Mammedov
2025-01-29 13:44 ` [PATCH 2/6] loongarch: reset vcpu after it's created Igor Mammedov
2025-01-29 13:44 ` [PATCH 3/6] m68k: " Igor Mammedov
2025-01-29 13:44 ` [PATCH 4/6] tcg:tlb: use tcg_debug_assert() in assert_cpu_is_self() Igor Mammedov
2025-01-31 12:19   ` Alex Bennée
2025-01-31 13:47   ` Igor Mammedov [this message]
2025-01-29 13:44 ` [PATCH 5/6] Revert "tcg/cputlb: remove other-cpu capability from TLB flushing" Igor Mammedov
2025-01-29 18:33   ` BALATON Zoltan
2025-01-30  8:06     ` Igor Mammedov
2025-01-29 13:44 ` [PATCH 6/6] tcg: drop cpu->created check Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250131134709.1306195-1-imammedo@redhat.com \
    --to=imammedo@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).