qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Jared Mauch" <jared+home@puck.nether.net>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	qemu-arm@nongnu.org, devel@lists.libvirt.org,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH 2/7] hw/arm/raspi4b: Introduce abstract raspi4-base machine type
Date: Sat,  1 Feb 2025 10:15:23 +0100	[thread overview]
Message-ID: <20250201091528.1177-3-philmd@linaro.org> (raw)
In-Reply-To: <20250201091528.1177-1-philmd@linaro.org>

In preparation of adding more machines based on the raspi4,
introduce TYPE_RASPI4_MACHINE. Remove TYPE_RASPI4B_MACHINE
definitions, declaring the machine name in place via the
MACHINE_TYPE_NAME("raspi4b") macro.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 hw/arm/raspi4b.c | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/hw/arm/raspi4b.c b/hw/arm/raspi4b.c
index 5c78d26f957..548059f6d69 100644
--- a/hw/arm/raspi4b.c
+++ b/hw/arm/raspi4b.c
@@ -23,8 +23,8 @@
 #include "hw/arm/bcm2838.h"
 #include <libfdt.h>
 
-#define TYPE_RASPI4B_MACHINE MACHINE_TYPE_NAME("raspi4b")
-OBJECT_DECLARE_SIMPLE_TYPE(Raspi4bMachineState, RASPI4B_MACHINE)
+#define TYPE_RASPI4_MACHINE MACHINE_TYPE_NAME("raspi4-base")
+OBJECT_DECLARE_SIMPLE_TYPE(Raspi4bMachineState, RASPI4_MACHINE)
 
 struct Raspi4bMachineState {
     RaspiBaseMachineState parent_obj;
@@ -93,7 +93,7 @@ static void raspi4_modify_dtb(const struct arm_boot_info *info, void *fdt)
 
 static void raspi4b_machine_init(MachineState *machine)
 {
-    Raspi4bMachineState *s = RASPI4B_MACHINE(machine);
+    Raspi4bMachineState *s = RASPI4_MACHINE(machine);
     RaspiBaseMachineState *s_base = RASPI_BASE_MACHINE(machine);
     RaspiBaseMachineClass *mc = RASPI_BASE_MACHINE_GET_CLASS(machine);
     BCM2838State *soc = &s->soc;
@@ -123,11 +123,15 @@ static void raspi4b_machine_class_init(ObjectClass *oc, void *data)
 
 static const TypeInfo raspi4_machine_types[] = {
     {
-        .name           = TYPE_RASPI4B_MACHINE,
+        .name           = MACHINE_TYPE_NAME("raspi4b"),
+        .parent         = TYPE_RASPI4_MACHINE,
+        .class_init     = raspi4b_machine_class_init,
+    }, {
+        .name           = TYPE_RASPI4_MACHINE,
         .parent         = TYPE_RASPI_BASE_MACHINE,
         .instance_size  = sizeof(Raspi4bMachineState),
-        .class_init     = raspi4b_machine_class_init,
-    },
+        .abstract       = true,
+    }
 };
 
 DEFINE_TYPES(raspi4_machine_types)
-- 
2.47.1



  parent reply	other threads:[~2025-02-01  9:16 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-01  9:15 [PATCH 0/7] hw/arm/raspi4b: Add models with 4GB and 8GB of DRAM Philippe Mathieu-Daudé
2025-02-01  9:15 ` [PATCH 1/7] hw/arm/raspi4b: Declare machine types using DEFINE_TYPES() macro Philippe Mathieu-Daudé
2025-02-01  9:15 ` Philippe Mathieu-Daudé [this message]
2025-02-01  9:15 ` [PATCH 3/7] hw/arm/raspi4b: Split raspi4b_machine_class_init() in two (1g and 2g) Philippe Mathieu-Daudé
2025-02-01  9:15 ` [PATCH 4/7] hw/arm/raspi4b: Rename as raspi4b-1g / raspi4b-2g, deprecating old name Philippe Mathieu-Daudé
2025-02-01 14:30   ` Philippe Mathieu-Daudé
2025-02-01  9:15 ` [PATCH 5/7] hw/arm/raspi4b: Expose the raspi4b-1g machine on 64-bit hosts Philippe Mathieu-Daudé
2025-02-01  9:15 ` [PATCH 6/7] hw/arm/raspi4b: Add the raspi4b-4g machine Philippe Mathieu-Daudé
2025-02-01  9:15 ` [PATCH 7/7] hw/arm/raspi4b: Add the raspi4b-8g machine Philippe Mathieu-Daudé
2025-02-01 12:57 ` [PATCH 0/7] hw/arm/raspi4b: Add models with 4GB and 8GB of DRAM BALATON Zoltan
2025-02-01 13:51   ` Peter Maydell
2025-02-03 14:29     ` Alex Bennée
2025-02-03 14:33       ` Daniel P. Berrangé
2025-02-03 14:45         ` Peter Maydell
2025-02-03 14:50           ` Daniel P. Berrangé
2025-02-03 15:05             ` Peter Maydell
2025-02-03 16:19             ` Philippe Mathieu-Daudé
2025-02-03 23:20               ` BALATON Zoltan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250201091528.1177-3-philmd@linaro.org \
    --to=philmd@linaro.org \
    --cc=devel@lists.libvirt.org \
    --cc=jared+home@puck.nether.net \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).