qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Thomas Huth" <thuth@redhat.com>
Subject: [PULL 25/32] hw/riscv: Remove all invalid uses of auto_create_sdcard=true
Date: Mon, 10 Feb 2025 21:41:57 +0100	[thread overview]
Message-ID: <20250210204204.54407-26-philmd@linaro.org> (raw)
In-Reply-To: <20250210204204.54407-1-philmd@linaro.org>

MachineClass::auto_create_sdcard is only useful to automatically
create a SD card, attach a IF_SD block drive to it and plug the
card onto a SD bus. None of the RISCV machines modified by this
commit try to use the IF_SD interface.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20250204200934.65279-7-philmd@linaro.org>
---
 hw/riscv/opentitan.c | 1 -
 hw/riscv/shakti_c.c  | 1 -
 hw/riscv/sifive_e.c  | 1 -
 hw/riscv/spike.c     | 1 -
 hw/riscv/virt.c      | 1 -
 5 files changed, 5 deletions(-)

diff --git a/hw/riscv/opentitan.c b/hw/riscv/opentitan.c
index d78a96c5354..b9e56235d87 100644
--- a/hw/riscv/opentitan.c
+++ b/hw/riscv/opentitan.c
@@ -121,7 +121,6 @@ static void opentitan_machine_class_init(ObjectClass *oc, void *data)
     mc->default_cpu_type = TYPE_RISCV_CPU_IBEX;
     mc->default_ram_id = "riscv.lowrisc.ibex.ram";
     mc->default_ram_size = ibex_memmap[IBEX_DEV_RAM].size;
-    mc->auto_create_sdcard = true;
 }
 
 static void lowrisc_ibex_soc_init(Object *obj)
diff --git a/hw/riscv/shakti_c.c b/hw/riscv/shakti_c.c
index efe814b5868..e2242b97d0c 100644
--- a/hw/riscv/shakti_c.c
+++ b/hw/riscv/shakti_c.c
@@ -84,7 +84,6 @@ static void shakti_c_machine_class_init(ObjectClass *klass, void *data)
     mc->default_cpu_type = TYPE_RISCV_CPU_SHAKTI_C;
     mc->valid_cpu_types = valid_cpu_types;
     mc->default_ram_id = "riscv.shakti.c.ram";
-    mc->auto_create_sdcard = true;
 }
 
 static const TypeInfo shakti_c_machine_type_info = {
diff --git a/hw/riscv/sifive_e.c b/hw/riscv/sifive_e.c
index 164eb3ab83b..73d3b74281c 100644
--- a/hw/riscv/sifive_e.c
+++ b/hw/riscv/sifive_e.c
@@ -153,7 +153,6 @@ static void sifive_e_machine_class_init(ObjectClass *oc, void *data)
     mc->default_cpu_type = SIFIVE_E_CPU;
     mc->default_ram_id = "riscv.sifive.e.ram";
     mc->default_ram_size = sifive_e_memmap[SIFIVE_E_DEV_DTIM].size;
-    mc->auto_create_sdcard = true;
 
     object_class_property_add_bool(oc, "revb", sifive_e_machine_get_revb,
                                    sifive_e_machine_set_revb);
diff --git a/hw/riscv/spike.c b/hw/riscv/spike.c
index 1ea35937e15..74a20016f14 100644
--- a/hw/riscv/spike.c
+++ b/hw/riscv/spike.c
@@ -358,7 +358,6 @@ static void spike_machine_class_init(ObjectClass *oc, void *data)
     /* platform instead of architectural choice */
     mc->cpu_cluster_has_numa_boundary = true;
     mc->default_ram_id = "riscv.spike.ram";
-    mc->auto_create_sdcard = true;
     object_class_property_add_str(oc, "signature", NULL, spike_set_signature);
     object_class_property_set_description(oc, "signature",
                                           "File to write ACT test signature");
diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c
index 2aa420f6e55..241389d72f8 100644
--- a/hw/riscv/virt.c
+++ b/hw/riscv/virt.c
@@ -1918,7 +1918,6 @@ static void virt_machine_class_init(ObjectClass *oc, void *data)
     mc->default_cpu_type = TYPE_RISCV_CPU_BASE;
     mc->block_default_type = IF_VIRTIO;
     mc->no_cdrom = 1;
-    mc->auto_create_sdcard = true;
     mc->pci_allow_0_address = true;
     mc->possible_cpu_arch_ids = riscv_numa_possible_cpu_arch_ids;
     mc->cpu_index_to_instance_props = riscv_numa_cpu_index_to_props;
-- 
2.47.1



  parent reply	other threads:[~2025-02-10 20:47 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-10 20:41 [PULL 00/32] Misc HW patches for 2025-02-10 Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 01/32] backends/tpm: Use qemu_hexdump_line() to avoid sprintf() Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 02/32] hw/intc/xilinx_intc: Make device endianness configurable Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 03/32] hw/net/xilinx_ethlite: " Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 04/32] hw/timer/xilinx_timer: " Philippe Mathieu-Daudé
2025-02-12  8:27   ` Thomas Huth
2025-02-12  9:19     ` Philippe Mathieu-Daudé
2025-02-12  9:34       ` Philippe Mathieu-Daudé
2025-02-12  9:55         ` Philippe Mathieu-Daudé
2025-02-12 10:24       ` Thomas Huth
2025-02-12 11:45         ` Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 05/32] hw/char/xilinx_uartlite: " Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 06/32] hw/ssi/xilinx_spi: " Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 07/32] hw/arm/xlnx-zynqmp: Use &error_abort for programming errors Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 08/32] hw/intc/apic: Fixes magic number use, removes outdated comment Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 09/32] hw/core/machine: Reject thread level cache Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 10/32] hw/sysbus: Use sizeof(BusState) in main_system_bus_create() Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 11/32] hw/sysbus: Declare QOM types using DEFINE_TYPES() macro Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 12/32] hw/sysbus: Introduce TYPE_DYNAMIC_SYS_BUS_DEVICE Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 13/32] hw/vfio: Have VFIO_PLATFORM devices inherit from DYNAMIC_SYS_BUS_DEVICE Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 14/32] hw/display: Have RAMFB device " Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 15/32] hw/i386: Have X86_IOMMU devices " Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 16/32] hw/net: Have eTSEC device " Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 17/32] hw/tpm: Have TPM TIS sysbus " Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 18/32] hw/xen: Prefer QOM cast for XenLegacyDevice Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 19/32] hw/xen: Have legacy Xen backend inherit from DYNAMIC_SYS_BUS_DEVICE Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 20/32] hw/boards: Convert no_sdcard flag to OnOffAuto tri-state Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 21/32] hw/boards: Explicit no_sdcard=false as ON_OFF_AUTO_OFF Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 22/32] hw/boards: Rename no_sdcard -> auto_create_sdcard Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 23/32] hw/boards: Do not create unusable default if=sd drives Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 24/32] hw/arm: Remove all invalid uses of auto_create_sdcard=true Philippe Mathieu-Daudé
2025-02-10 20:41 ` Philippe Mathieu-Daudé [this message]
2025-02-10 20:41 ` [PULL 26/32] hw/boards: Ensure machine setting auto_create_sdcard expose a SD Bus Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 27/32] tests/functional: Explicit endianness of microblaze assets Philippe Mathieu-Daudé
2025-02-10 20:42 ` [PULL 28/32] tests/functional: Allow microblaze tests to take a machine name argument Philippe Mathieu-Daudé
2025-02-10 20:42 ` [PULL 29/32] tests/functional: Remove sleep() kludges from microblaze tests Philippe Mathieu-Daudé
2025-02-10 20:42 ` [PULL 30/32] tests/functional: Have microblaze tests inherit common parent class Philippe Mathieu-Daudé
2025-02-10 20:42 ` [PULL 31/32] hw/riscv/opentitan: Include missing 'exec/address-spaces.h' header Philippe Mathieu-Daudé
2025-02-10 20:42 ` [PULL 32/32] hw/net/smc91c111: Ignore attempt to pop from empty RX fifo Philippe Mathieu-Daudé
2025-02-11 18:26 ` [PULL 00/32] Misc HW patches for 2025-02-10 Stefan Hajnoczi
2025-02-11 18:48   ` Philippe Mathieu-Daudé
2025-02-11 18:53     ` Philippe Mathieu-Daudé
2025-02-11 19:03       ` Philippe Mathieu-Daudé
2025-02-12  0:41         ` Thomas Huth
2025-02-12  1:39           ` Thomas Huth
2025-02-12  4:45             ` Eldon Stegall
2025-02-12 19:31               ` Thomas Huth
2025-02-12  0:31       ` Thomas Huth
2025-02-12  9:10       ` Daniel P. Berrangé
2025-02-12 11:57         ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250210204204.54407-26-philmd@linaro.org \
    --to=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).