qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Thomas Huth" <thuth@redhat.com>,
	"Richard Henderson" <richard.henderson@linaro.org>
Subject: [PULL 29/32] tests/functional: Remove sleep() kludges from microblaze tests
Date: Mon, 10 Feb 2025 21:42:01 +0100	[thread overview]
Message-ID: <20250210204204.54407-30-philmd@linaro.org> (raw)
In-Reply-To: <20250210204204.54407-1-philmd@linaro.org>

Commit f0ec14c78c4 ("tests/avocado: Fix console data loss") fixed
QEMUMachine's problem with console, we don't need to use the sleep()
kludges.

Suggested-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20250206131052.30207-15-philmd@linaro.org>
---
 tests/functional/test_microblazeel_s3adsp1800.py | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/tests/functional/test_microblazeel_s3adsp1800.py b/tests/functional/test_microblazeel_s3adsp1800.py
index 715ef3f79ac..60aab4a45e8 100755
--- a/tests/functional/test_microblazeel_s3adsp1800.py
+++ b/tests/functional/test_microblazeel_s3adsp1800.py
@@ -7,8 +7,7 @@
 # This work is licensed under the terms of the GNU GPL, version 2 or
 # later. See the COPYING file in the top-level directory.
 
-import time
-from qemu_test import exec_command, exec_command_and_wait_for_pattern
+from qemu_test import exec_command_and_wait_for_pattern
 from qemu_test import QemuSystemTest, Asset
 from qemu_test import wait_for_console_pattern
 
@@ -31,9 +30,8 @@ def do_xmaton_le_test(self, machine):
         self.vm.add_args('-nic', f'user,tftp={tftproot}')
         self.vm.launch()
         wait_for_console_pattern(self, 'QEMU Advent Calendar 2023')
-        time.sleep(0.1)
-        exec_command(self, 'root')
-        time.sleep(0.1)
+        wait_for_console_pattern(self, 'buildroot login:')
+        exec_command_and_wait_for_pattern(self, 'root', '#')
         exec_command_and_wait_for_pattern(self,
                 'tftp -g -r xmaton.png 10.0.2.2 ; md5sum xmaton.png',
                 '821cd3cab8efd16ad6ee5acc3642a8ea')
-- 
2.47.1



  parent reply	other threads:[~2025-02-10 20:46 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-10 20:41 [PULL 00/32] Misc HW patches for 2025-02-10 Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 01/32] backends/tpm: Use qemu_hexdump_line() to avoid sprintf() Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 02/32] hw/intc/xilinx_intc: Make device endianness configurable Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 03/32] hw/net/xilinx_ethlite: " Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 04/32] hw/timer/xilinx_timer: " Philippe Mathieu-Daudé
2025-02-12  8:27   ` Thomas Huth
2025-02-12  9:19     ` Philippe Mathieu-Daudé
2025-02-12  9:34       ` Philippe Mathieu-Daudé
2025-02-12  9:55         ` Philippe Mathieu-Daudé
2025-02-12 10:24       ` Thomas Huth
2025-02-12 11:45         ` Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 05/32] hw/char/xilinx_uartlite: " Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 06/32] hw/ssi/xilinx_spi: " Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 07/32] hw/arm/xlnx-zynqmp: Use &error_abort for programming errors Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 08/32] hw/intc/apic: Fixes magic number use, removes outdated comment Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 09/32] hw/core/machine: Reject thread level cache Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 10/32] hw/sysbus: Use sizeof(BusState) in main_system_bus_create() Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 11/32] hw/sysbus: Declare QOM types using DEFINE_TYPES() macro Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 12/32] hw/sysbus: Introduce TYPE_DYNAMIC_SYS_BUS_DEVICE Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 13/32] hw/vfio: Have VFIO_PLATFORM devices inherit from DYNAMIC_SYS_BUS_DEVICE Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 14/32] hw/display: Have RAMFB device " Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 15/32] hw/i386: Have X86_IOMMU devices " Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 16/32] hw/net: Have eTSEC device " Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 17/32] hw/tpm: Have TPM TIS sysbus " Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 18/32] hw/xen: Prefer QOM cast for XenLegacyDevice Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 19/32] hw/xen: Have legacy Xen backend inherit from DYNAMIC_SYS_BUS_DEVICE Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 20/32] hw/boards: Convert no_sdcard flag to OnOffAuto tri-state Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 21/32] hw/boards: Explicit no_sdcard=false as ON_OFF_AUTO_OFF Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 22/32] hw/boards: Rename no_sdcard -> auto_create_sdcard Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 23/32] hw/boards: Do not create unusable default if=sd drives Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 24/32] hw/arm: Remove all invalid uses of auto_create_sdcard=true Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 25/32] hw/riscv: " Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 26/32] hw/boards: Ensure machine setting auto_create_sdcard expose a SD Bus Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 27/32] tests/functional: Explicit endianness of microblaze assets Philippe Mathieu-Daudé
2025-02-10 20:42 ` [PULL 28/32] tests/functional: Allow microblaze tests to take a machine name argument Philippe Mathieu-Daudé
2025-02-10 20:42 ` Philippe Mathieu-Daudé [this message]
2025-02-10 20:42 ` [PULL 30/32] tests/functional: Have microblaze tests inherit common parent class Philippe Mathieu-Daudé
2025-02-10 20:42 ` [PULL 31/32] hw/riscv/opentitan: Include missing 'exec/address-spaces.h' header Philippe Mathieu-Daudé
2025-02-10 20:42 ` [PULL 32/32] hw/net/smc91c111: Ignore attempt to pop from empty RX fifo Philippe Mathieu-Daudé
2025-02-11 18:26 ` [PULL 00/32] Misc HW patches for 2025-02-10 Stefan Hajnoczi
2025-02-11 18:48   ` Philippe Mathieu-Daudé
2025-02-11 18:53     ` Philippe Mathieu-Daudé
2025-02-11 19:03       ` Philippe Mathieu-Daudé
2025-02-12  0:41         ` Thomas Huth
2025-02-12  1:39           ` Thomas Huth
2025-02-12  4:45             ` Eldon Stegall
2025-02-12 19:31               ` Thomas Huth
2025-02-12  0:31       ` Thomas Huth
2025-02-12  9:10       ` Daniel P. Berrangé
2025-02-12 11:57         ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250210204204.54407-30-philmd@linaro.org \
    --to=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).