qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Richard Henderson" <richard.henderson@linaro.org>
Subject: [PULL 06/32] hw/ssi/xilinx_spi: Make device endianness configurable
Date: Mon, 10 Feb 2025 21:41:38 +0100	[thread overview]
Message-ID: <20250210204204.54407-7-philmd@linaro.org> (raw)
In-Reply-To: <20250210204204.54407-1-philmd@linaro.org>

Replace the DEVICE_NATIVE_ENDIAN MemoryRegionOps by a pair
of DEVICE_LITTLE_ENDIAN / DEVICE_BIG_ENDIAN.
Add the "little-endian" property to select the device
endianness, defaulting to little endian.
Set the proper endianness on the single machine using the
device.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20250206131052.30207-7-philmd@linaro.org>
---
 hw/microblaze/petalogix_ml605_mmu.c |  1 +
 hw/ssi/xilinx_spi.c                 | 24 +++++++++++++++---------
 2 files changed, 16 insertions(+), 9 deletions(-)

diff --git a/hw/microblaze/petalogix_ml605_mmu.c b/hw/microblaze/petalogix_ml605_mmu.c
index bbda70aa93b..a795c6385b4 100644
--- a/hw/microblaze/petalogix_ml605_mmu.c
+++ b/hw/microblaze/petalogix_ml605_mmu.c
@@ -175,6 +175,7 @@ petalogix_ml605_init(MachineState *machine)
         SSIBus *spi;
 
         dev = qdev_new("xlnx.xps-spi");
+        qdev_prop_set_bit(dev, "little-endian", true);
         qdev_prop_set_uint8(dev, "num-ss-bits", NUM_SPI_FLASHES);
         busdev = SYS_BUS_DEVICE(dev);
         sysbus_realize_and_unref(busdev, &error_fatal);
diff --git a/hw/ssi/xilinx_spi.c b/hw/ssi/xilinx_spi.c
index fd1ff12eb1d..299004ff36d 100644
--- a/hw/ssi/xilinx_spi.c
+++ b/hw/ssi/xilinx_spi.c
@@ -83,6 +83,7 @@ OBJECT_DECLARE_SIMPLE_TYPE(XilinxSPI, XILINX_SPI)
 struct XilinxSPI {
     SysBusDevice parent_obj;
 
+    bool little_endian_model;
     MemoryRegion mmio;
 
     qemu_irq irq;
@@ -313,14 +314,17 @@ done:
     xlx_spi_update_irq(s);
 }
 
-static const MemoryRegionOps spi_ops = {
-    .read = spi_read,
-    .write = spi_write,
-    .endianness = DEVICE_NATIVE_ENDIAN,
-    .valid = {
-        .min_access_size = 4,
-        .max_access_size = 4
-    }
+static const MemoryRegionOps spi_ops[2] = {
+    [0 ... 1] = {
+        .read = spi_read,
+        .write = spi_write,
+        .valid = {
+            .min_access_size = 4,
+            .max_access_size = 4,
+        },
+    },
+    [0].endianness = DEVICE_BIG_ENDIAN,
+    [1].endianness = DEVICE_LITTLE_ENDIAN,
 };
 
 static void xilinx_spi_realize(DeviceState *dev, Error **errp)
@@ -339,7 +343,8 @@ static void xilinx_spi_realize(DeviceState *dev, Error **errp)
         sysbus_init_irq(sbd, &s->cs_lines[i]);
     }
 
-    memory_region_init_io(&s->mmio, OBJECT(s), &spi_ops, s,
+    memory_region_init_io(&s->mmio, OBJECT(s),
+                          &spi_ops[s->little_endian_model], s,
                           "xilinx-spi", R_MAX * 4);
     sysbus_init_mmio(sbd, &s->mmio);
 
@@ -362,6 +367,7 @@ static const VMStateDescription vmstate_xilinx_spi = {
 };
 
 static const Property xilinx_spi_properties[] = {
+    DEFINE_PROP_BOOL("little-endian", XilinxSPI, little_endian_model, true),
     DEFINE_PROP_UINT8("num-ss-bits", XilinxSPI, num_cs, 1),
 };
 
-- 
2.47.1



  parent reply	other threads:[~2025-02-10 20:43 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-10 20:41 [PULL 00/32] Misc HW patches for 2025-02-10 Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 01/32] backends/tpm: Use qemu_hexdump_line() to avoid sprintf() Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 02/32] hw/intc/xilinx_intc: Make device endianness configurable Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 03/32] hw/net/xilinx_ethlite: " Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 04/32] hw/timer/xilinx_timer: " Philippe Mathieu-Daudé
2025-02-12  8:27   ` Thomas Huth
2025-02-12  9:19     ` Philippe Mathieu-Daudé
2025-02-12  9:34       ` Philippe Mathieu-Daudé
2025-02-12  9:55         ` Philippe Mathieu-Daudé
2025-02-12 10:24       ` Thomas Huth
2025-02-12 11:45         ` Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 05/32] hw/char/xilinx_uartlite: " Philippe Mathieu-Daudé
2025-02-10 20:41 ` Philippe Mathieu-Daudé [this message]
2025-02-10 20:41 ` [PULL 07/32] hw/arm/xlnx-zynqmp: Use &error_abort for programming errors Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 08/32] hw/intc/apic: Fixes magic number use, removes outdated comment Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 09/32] hw/core/machine: Reject thread level cache Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 10/32] hw/sysbus: Use sizeof(BusState) in main_system_bus_create() Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 11/32] hw/sysbus: Declare QOM types using DEFINE_TYPES() macro Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 12/32] hw/sysbus: Introduce TYPE_DYNAMIC_SYS_BUS_DEVICE Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 13/32] hw/vfio: Have VFIO_PLATFORM devices inherit from DYNAMIC_SYS_BUS_DEVICE Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 14/32] hw/display: Have RAMFB device " Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 15/32] hw/i386: Have X86_IOMMU devices " Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 16/32] hw/net: Have eTSEC device " Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 17/32] hw/tpm: Have TPM TIS sysbus " Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 18/32] hw/xen: Prefer QOM cast for XenLegacyDevice Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 19/32] hw/xen: Have legacy Xen backend inherit from DYNAMIC_SYS_BUS_DEVICE Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 20/32] hw/boards: Convert no_sdcard flag to OnOffAuto tri-state Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 21/32] hw/boards: Explicit no_sdcard=false as ON_OFF_AUTO_OFF Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 22/32] hw/boards: Rename no_sdcard -> auto_create_sdcard Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 23/32] hw/boards: Do not create unusable default if=sd drives Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 24/32] hw/arm: Remove all invalid uses of auto_create_sdcard=true Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 25/32] hw/riscv: " Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 26/32] hw/boards: Ensure machine setting auto_create_sdcard expose a SD Bus Philippe Mathieu-Daudé
2025-02-10 20:41 ` [PULL 27/32] tests/functional: Explicit endianness of microblaze assets Philippe Mathieu-Daudé
2025-02-10 20:42 ` [PULL 28/32] tests/functional: Allow microblaze tests to take a machine name argument Philippe Mathieu-Daudé
2025-02-10 20:42 ` [PULL 29/32] tests/functional: Remove sleep() kludges from microblaze tests Philippe Mathieu-Daudé
2025-02-10 20:42 ` [PULL 30/32] tests/functional: Have microblaze tests inherit common parent class Philippe Mathieu-Daudé
2025-02-10 20:42 ` [PULL 31/32] hw/riscv/opentitan: Include missing 'exec/address-spaces.h' header Philippe Mathieu-Daudé
2025-02-10 20:42 ` [PULL 32/32] hw/net/smc91c111: Ignore attempt to pop from empty RX fifo Philippe Mathieu-Daudé
2025-02-11 18:26 ` [PULL 00/32] Misc HW patches for 2025-02-10 Stefan Hajnoczi
2025-02-11 18:48   ` Philippe Mathieu-Daudé
2025-02-11 18:53     ` Philippe Mathieu-Daudé
2025-02-11 19:03       ` Philippe Mathieu-Daudé
2025-02-12  0:41         ` Thomas Huth
2025-02-12  1:39           ` Thomas Huth
2025-02-12  4:45             ` Eldon Stegall
2025-02-12 19:31               ` Thomas Huth
2025-02-12  0:31       ` Thomas Huth
2025-02-12  9:10       ` Daniel P. Berrangé
2025-02-12 11:57         ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250210204204.54407-7-philmd@linaro.org \
    --to=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).