qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Cédric Le Goater" <clg@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Alex Williamson" <alex.williamson@redhat.com>,
	"Cédric Le Goater" <clg@redhat.com>
Subject: [PULL 01/12] vfio/igd: Fix potential overflow in igd_gtt_memory_size()
Date: Tue, 11 Feb 2025 15:33:29 +0100	[thread overview]
Message-ID: <20250211143340.787996-2-clg@redhat.com> (raw)
In-Reply-To: <20250211143340.787996-1-clg@redhat.com>

The risk is mainly theoretical since the applied bit mask will keep
the 'ggms' shift value below 3. Nevertheless, let's use a 64 bit
integer type and resolve the coverity issue.

Resolves: Coverity CID 1585908
Fixes: 1e1eac5f3dcd ("vfio/igd: canonicalize memory size calculations")
Reviewed-by: Alex Williamson <alex.williamson@redhat.com>
Link: https://lore.kernel.org/r/20250107130604.669697-1-clg@redhat.com
Signed-off-by: Cédric Le Goater <clg@redhat.com>
---
 hw/vfio/igd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/vfio/igd.c b/hw/vfio/igd.c
index 0740a5dd8cc9346a92c4613194faa8dea42e1d98..b5303ea565d6a344d0a43273f288bbb4a7f48327 100644
--- a/hw/vfio/igd.c
+++ b/hw/vfio/igd.c
@@ -133,7 +133,7 @@ static uint64_t igd_gtt_memory_size(int gen, uint16_t gmch)
     } else {
         ggms = (gmch >> IGD_GMCH_GEN8_GGMS_SHIFT) & IGD_GMCH_GEN8_GGMS_MASK;
         if (ggms != 0) {
-            ggms = 1 << ggms;
+            ggms = 1ULL << ggms;
         }
     }
 
-- 
2.48.1



  reply	other threads:[~2025-02-11 14:35 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-11 14:33 [PULL 00/12] vfio queue Cédric Le Goater
2025-02-11 14:33 ` Cédric Le Goater [this message]
2025-02-11 14:33 ` [PULL 02/12] vfio/pci: declare generic quirks in a new header file Cédric Le Goater
2025-02-11 14:33 ` [PULL 03/12] vfio/pci: introduce config_offset field in VFIOConfigMirrorQuirk Cédric Le Goater
2025-02-11 14:33 ` [PULL 04/12] vfio/igd: use VFIOConfigMirrorQuirk for mirrored registers Cédric Le Goater
2025-02-11 14:33 ` [PULL 05/12] vfio/iommufd: Fix SIGSEV in iommufd_cdev_attach() Cédric Le Goater
2025-02-12 19:12   ` Michael Tokarev
2025-02-13  6:32     ` Cédric Le Goater
2025-02-13  6:42       ` Michael Tokarev
2025-02-13  8:48         ` Cédric Le Goater
2025-02-13  9:30           ` Michael Tokarev
2025-02-11 14:33 ` [PULL 06/12] util/error: Introduce warn_report_err_once() Cédric Le Goater
2025-02-11 14:33 ` [PULL 07/12] vfio/pci: Replace "iommu_device" by "vIOMMU" Cédric Le Goater
2025-02-11 14:33 ` [PULL 08/12] vfio: Rephrase comment in vfio_listener_region_add() error path Cédric Le Goater
2025-02-11 14:33 ` [PULL 09/12] vfio: Introduce vfio_get_vfio_device() Cédric Le Goater
2025-02-11 14:33 ` [PULL 10/12] vfio: Improve error reporting when MMIO region mapping fails Cédric Le Goater
2025-02-11 14:33 ` [PULL 11/12] vfio: Remove reports of DMA mapping errors in backends Cédric Le Goater
2025-02-11 14:33 ` [PULL 12/12] vfio: Remove superfluous error report in vfio_listener_region_add() Cédric Le Goater
2025-02-12 17:38 ` [PULL 00/12] vfio queue Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250211143340.787996-2-clg@redhat.com \
    --to=clg@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).