From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Paul Burton" <paulburton@kernel.org>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Huacai Chen" <chenhuacai@kernel.org>,
qemu-arm@nongnu.org, "Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Aleksandar Rikalo" <arikalo@gmail.com>,
"Sunil Muthuswamy" <sunilmut@microsoft.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Beniamino Galvani" <b.galvani@gmail.com>,
"Strahinja Jankovic" <strahinja.p.jankovic@gmail.com>,
"Alistair Francis" <alistair@alistair23.me>,
"Jason Wang" <jasowang@redhat.com>,
"Niek Linnenbank" <nieklinnenbank@gmail.com>
Subject: [PATCH 2/5] hw/mips: Mark Boston machine devices as little-endian
Date: Wed, 12 Feb 2025 12:39:35 +0100 [thread overview]
Message-ID: <20250212113938.38692-3-philmd@linaro.org> (raw)
In-Reply-To: <20250212113938.38692-1-philmd@linaro.org>
The Boston machine is only built as little-endian.
Therefore the DEVICE_NATIVE_ENDIAN definition expand to
DEVICE_LITTLE_ENDIAN (besides, the DEVICE_BIG_ENDIAN case
isn't tested). Simplify directly using DEVICE_LITTLE_ENDIAN.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/mips/boston.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/mips/boston.c b/hw/mips/boston.c
index 364c328032a..4690b254dda 100644
--- a/hw/mips/boston.c
+++ b/hw/mips/boston.c
@@ -220,7 +220,7 @@ static void boston_lcd_write(void *opaque, hwaddr addr,
static const MemoryRegionOps boston_lcd_ops = {
.read = boston_lcd_read,
.write = boston_lcd_write,
- .endianness = DEVICE_NATIVE_ENDIAN,
+ .endianness = DEVICE_LITTLE_ENDIAN,
};
static uint64_t boston_platreg_read(void *opaque, hwaddr addr,
@@ -299,7 +299,7 @@ static void boston_platreg_write(void *opaque, hwaddr addr,
static const MemoryRegionOps boston_platreg_ops = {
.read = boston_platreg_read,
.write = boston_platreg_write,
- .endianness = DEVICE_NATIVE_ENDIAN,
+ .endianness = DEVICE_LITTLE_ENDIAN,
};
static void mips_boston_instance_init(Object *obj)
@@ -758,7 +758,7 @@ static void boston_mach_init(MachineState *machine)
s->uart = serial_mm_init(sys_mem, boston_memmap[BOSTON_UART].base, 2,
get_cps_irq(&s->cps, 3), 10000000,
- serial_hd(0), DEVICE_NATIVE_ENDIAN);
+ serial_hd(0), DEVICE_LITTLE_ENDIAN);
lcd = g_new(MemoryRegion, 1);
memory_region_init_io(lcd, NULL, &boston_lcd_ops, s, "boston-lcd", 0x8);
--
2.47.1
next prev parent reply other threads:[~2025-02-12 11:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 11:39 [PATCH 0/5] hw: More DEVICE_ [NATIVE -> LITTLE] _ENDIAN conversions Philippe Mathieu-Daudé
2025-02-12 11:39 ` [PATCH 1/5] hw/arm: Mark Allwinner Technology devices as little-endian Philippe Mathieu-Daudé
2025-02-12 17:47 ` Richard Henderson
2025-02-12 11:39 ` Philippe Mathieu-Daudé [this message]
2025-02-12 17:51 ` [PATCH 2/5] hw/mips: Mark Boston machine " Richard Henderson
2025-02-12 11:39 ` [PATCH 3/5] hw/mips: Mark Loonson3 Virt " Philippe Mathieu-Daudé
2025-02-12 17:51 ` Richard Henderson
2025-02-12 11:39 ` [PATCH 4/5] hw/pci-host: Mark versatile regions " Philippe Mathieu-Daudé
2025-02-12 17:53 ` Richard Henderson
2025-02-12 11:39 ` [PATCH 5/5] target/i386: Mark WHPX APIC region " Philippe Mathieu-Daudé
2025-02-12 17:54 ` Richard Henderson
2025-02-16 21:03 ` [PATCH 0/5] hw: More DEVICE_ [NATIVE -> LITTLE] _ENDIAN conversions Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250212113938.38692-3-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=alistair@alistair23.me \
--cc=arikalo@gmail.com \
--cc=b.galvani@gmail.com \
--cc=chenhuacai@kernel.org \
--cc=jasowang@redhat.com \
--cc=jiaxun.yang@flygoat.com \
--cc=nieklinnenbank@gmail.com \
--cc=paulburton@kernel.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=strahinja.p.jankovic@gmail.com \
--cc=sunilmut@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).