From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH v3 17/19] hw/virtio/virtio-pci: Reduce generic_type_info scope
Date: Wed, 12 Feb 2025 22:32:47 +0100 [thread overview]
Message-ID: <20250212213249.45574-18-philmd@linaro.org> (raw)
In-Reply-To: <20250212213249.45574-1-philmd@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/virtio/virtio-pci.c | 25 +++++++++++++------------
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
index 6f0e1772669..99724deb3d9 100644
--- a/hw/virtio/virtio-pci.c
+++ b/hw/virtio/virtio-pci.c
@@ -2488,18 +2488,6 @@ void virtio_pci_types_register(const VirtioPCIDeviceTypeInfo *t)
.abstract = true,
.interfaces = t->interfaces,
};
- const TypeInfo generic_type_info = {
- .name = t->generic_name,
- .parent = t->base_name ?: base_name,
- .class_init = t->base_name ? virtio_pci_generic_class_init
- : virtio_pci_base_class_init,
- .class_data = t->base_name ? NULL : t,
- .interfaces = (const InterfaceInfo[]) {
- { INTERFACE_PCIE_DEVICE },
- { INTERFACE_CONVENTIONAL_PCI_DEVICE },
- { }
- },
- };
assert(t->base_name || !t->non_transitional_name);
assert(t->base_name || !t->transitional_name);
@@ -2507,6 +2495,19 @@ void virtio_pci_types_register(const VirtioPCIDeviceTypeInfo *t)
type_register_static(&base_type_info);
if (t->generic_name) {
+ const TypeInfo generic_type_info = {
+ .name = t->generic_name,
+ .parent = t->base_name ?: base_name,
+ .class_init = t->base_name ? virtio_pci_generic_class_init
+ : virtio_pci_base_class_init,
+ .class_data = t->base_name ? NULL : t,
+ .interfaces = (const InterfaceInfo[]) {
+ { INTERFACE_PCIE_DEVICE },
+ { INTERFACE_CONVENTIONAL_PCI_DEVICE },
+ { }
+ },
+ };
+
type_register_static(&generic_type_info);
}
--
2.47.1
next prev parent reply other threads:[~2025-02-12 21:35 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 21:32 [PATCH v3 00/19] qom: Constify class_data Philippe Mathieu-Daudé
2025-02-12 21:32 ` [PATCH v3 01/19] hw: Declare various const data as 'const' Philippe Mathieu-Daudé
2025-02-12 21:32 ` [PATCH v3 02/19] hw: Make class data 'const' Philippe Mathieu-Daudé
2025-02-12 21:32 ` [PATCH v3 03/19] target/i386: Constify X86CPUModel uses Philippe Mathieu-Daudé
2025-02-12 21:32 ` [PATCH v3 04/19] target/sparc: Constify SPARCCPUClass::cpu_def Philippe Mathieu-Daudé
2025-02-12 21:32 ` [PATCH v3 05/19] target/xtensa: Finalize config in xtensa_register_core() Philippe Mathieu-Daudé
2025-02-12 21:32 ` [PATCH v3 06/19] target/riscv: Declare RISCVCPUClass::misa_mxl_max as RISCVMXL Philippe Mathieu-Daudé
2025-02-17 5:08 ` Alistair Francis
2025-02-12 21:32 ` [PATCH v3 07/19] target/riscv: Convert misa_mxl_max using GLib macros Philippe Mathieu-Daudé
2025-02-17 5:13 ` Alistair Francis
2025-02-12 21:32 ` [PATCH v3 08/19] qom: Have class_base_init() take a const data argument Philippe Mathieu-Daudé
2025-02-12 21:32 ` [PATCH v3 09/19] qom: Have class_init() " Philippe Mathieu-Daudé
2025-02-12 21:32 ` [PATCH v3 10/19] qom: Constify TypeInfo::class_data Philippe Mathieu-Daudé
2025-02-12 21:32 ` [PATCH v3 11/19] qom: Constify InterfaceInfo[] interfaces Philippe Mathieu-Daudé
2025-02-12 21:32 ` [PATCH v3 12/19] hw/virtio/virtio-pci: Always allocate QOM type base_name Philippe Mathieu-Daudé
2025-02-12 22:06 ` Richard Henderson
2025-02-12 21:32 ` [PATCH v3 13/19] hw/virtio/virtio-pci: Assert before registering QOM types Philippe Mathieu-Daudé
2025-02-12 21:32 ` [PATCH v3 14/19] hw/virtio/virtio-pci: Do not access base_type_info.name directly Philippe Mathieu-Daudé
2025-02-12 21:32 ` [PATCH v3 15/19] hw/virtio/virtio-pci: Constify base_type_info Philippe Mathieu-Daudé
2025-02-12 21:32 ` [PATCH v3 16/19] hw/virtio/virtio-pci: Constify generic_type_info Philippe Mathieu-Daudé
2025-02-12 21:32 ` Philippe Mathieu-Daudé [this message]
2025-02-12 21:32 ` [PATCH v3 18/19] hw: Constify various TypeInfo and associated structures Philippe Mathieu-Daudé
2025-02-12 22:10 ` Richard Henderson
2025-02-12 21:32 ` [PATCH v3 19/19] qom: Require TypeInfo::class_data points to const data Philippe Mathieu-Daudé
2025-02-12 22:11 ` Richard Henderson
2025-02-18 16:51 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250212213249.45574-18-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).