qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>, qemu-devel@nongnu.org
Cc: "Evgeny Iakovlev" <eiakovlev@linux.microsoft.com>,
	"Rayhan Faizel" <rayhan.faizel@gmail.com>,
	"Luc Michel" <luc.michel@amd.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Yoshinori Sato" <ysato@users.sourceforge.jp>,
	"Magnus Damm" <magnus.damm@gmail.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Thomas Huth" <huth@tuxfamily.org>,
	"Shin'ichiro Kawasaki" <shinichiro.kawasaki@wdc.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	qemu-arm@nongnu.org
Subject: [PATCH 5/9] hw/char/bcm2835_aux: Really use RX FIFO depth
Date: Wed, 19 Feb 2025 22:08:37 +0100	[thread overview]
Message-ID: <20250219210841.94797-6-philmd@linaro.org> (raw)
In-Reply-To: <20250219210841.94797-1-philmd@linaro.org>

While we model a 8-elements RX FIFO since the PL011 model was
introduced in commit 97398d900ca ("bcm2835_aux: add emulation
of BCM2835 AUX block") we only read 1 char at a time!

Have the IOCanReadHandler handler return how many elements are
available, and use that in the IOReadHandler handler.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 hw/char/bcm2835_aux.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/hw/char/bcm2835_aux.c b/hw/char/bcm2835_aux.c
index 73ad5934067..c6e7eccf7dd 100644
--- a/hw/char/bcm2835_aux.c
+++ b/hw/char/bcm2835_aux.c
@@ -221,7 +221,7 @@ static int bcm2835_aux_can_receive(void *opaque)
 {
     BCM2835AuxState *s = opaque;
 
-    return s->read_count < BCM2835_AUX_RX_FIFO_LEN;
+    return BCM2835_AUX_RX_FIFO_LEN - s->read_count;
 }
 
 static void bcm2835_aux_put_fifo(void *opaque, uint8_t value)
@@ -243,7 +243,9 @@ static void bcm2835_aux_put_fifo(void *opaque, uint8_t value)
 
 static void bcm2835_aux_receive(void *opaque, const uint8_t *buf, int size)
 {
-    bcm2835_aux_put_fifo(opaque, *buf);
+    for (int i = 0; i < size; i++) {
+        bcm2835_aux_put_fifo(opaque, buf[i]);
+    }
 }
 
 static const MemoryRegionOps bcm2835_aux_ops = {
-- 
2.47.1



  parent reply	other threads:[~2025-02-19 21:09 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-19 21:08 [PATCH 0/9] hw/char: Improve RX FIFO depth uses Philippe Mathieu-Daudé
2025-02-19 21:08 ` [PATCH 1/9] hw/char/pl011: Warn when using disabled receiver Philippe Mathieu-Daudé
2025-02-20  8:11   ` Luc Michel
2025-02-19 21:08 ` [PATCH 2/9] hw/char/pl011: Simplify a bit pl011_can_receive() Philippe Mathieu-Daudé
2025-02-20  8:12   ` Luc Michel
2025-02-19 21:08 ` [PATCH 3/9] hw/char/pl011: Improve RX flow tracing events Philippe Mathieu-Daudé
2025-02-19 22:09   ` Alex Bennée
2025-02-20  8:14   ` Luc Michel
2025-02-19 21:08 ` [PATCH 4/9] hw/char/pl011: Really use RX FIFO depth Philippe Mathieu-Daudé
2025-02-20  8:17   ` Luc Michel
2025-02-19 21:08 ` Philippe Mathieu-Daudé [this message]
2025-02-20  8:21   ` [PATCH 5/9] hw/char/bcm2835_aux: " Luc Michel
2025-02-20  8:28     ` Philippe Mathieu-Daudé
2025-02-19 21:08 ` [PATCH 6/9] hw/char/imx_serial: " Philippe Mathieu-Daudé
2025-02-20  8:22   ` Luc Michel
2025-02-19 21:08 ` [PATCH 7/9] hw/char/mcf_uart: Use FIFO_DEPTH definition instead of magic values Philippe Mathieu-Daudé
2025-02-20  8:24   ` Luc Michel
2025-02-19 21:08 ` [PATCH 8/9] hw/char/mcf_uart: Really use RX FIFO depth Philippe Mathieu-Daudé
2025-02-20  8:26   ` Luc Michel
2025-02-19 21:08 ` [PATCH 9/9] hw/char/sh_serial: Return correct number of empty RX FIFO elements Philippe Mathieu-Daudé
2025-02-20  8:30   ` Luc Michel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250219210841.94797-6-philmd@linaro.org \
    --to=philmd@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=eiakovlev@linux.microsoft.com \
    --cc=huth@tuxfamily.org \
    --cc=luc.michel@amd.com \
    --cc=magnus.damm@gmail.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rayhan.faizel@gmail.com \
    --cc=shinichiro.kawasaki@wdc.com \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).