From: Stefano Brivio <sbrivio@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Stefano Garzarella <sgarzare@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
qemu-devel@nongnu.org, Jason Wang <jasowang@redhat.com>,
Thibaut Collet <thibaut.collet@6wind.com>
Subject: Re: [PATCH] vhost-user: Silence unsupported VHOST_USER_PROTOCOL_F_RARP error
Date: Thu, 20 Feb 2025 17:59:10 +0100 [thread overview]
Message-ID: <20250220175910.25688823@elisabeth> (raw)
In-Reply-To: <20250220102724-mutt-send-email-mst@kernel.org>
On Thu, 20 Feb 2025 10:28:20 -0500
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> On Fri, Jan 24, 2025 at 05:03:27PM +0100, Stefano Brivio wrote:
> > But I don't understand why we're leaving this as it is.
>
> So that people notice if there's some backend problem and
> announcements are not going out. should help debug migration
> issues. which we had, so we added this :)
The message mentions that the back-end fails to do something it didn't
and can't even do, that's (one reason) why it's wrong (and confusing)
and this patch is obviously correct.
Perhaps the commit title isn't entirely accurate (it should say "when
unsupported", I guess) but it's somewhat expected to sacrifice detail
in the name of brevity, there. A glimpse at the message is enough.
Laurent now added a workaround in passt to pretend that we support
VHOST_USER_PROTOCOL_F_RARP by doing nothing in the callback, report
success, and silence the warning:
https://passt.top/passt/commit/?id=dd6a6854c73a09c4091c1776ee7f349d1e1f966c
but having to do this kind of stuff is a bit unexpected while
interacting with another opensource project.
--
Stefano
next prev parent reply other threads:[~2025-02-20 17:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-21 10:00 [PATCH] vhost-user: Silence unsupported VHOST_USER_PROTOCOL_F_RARP error Laurent Vivier
2025-01-22 13:42 ` Stefano Garzarella
2025-01-22 13:59 ` Michael S. Tsirkin
2025-01-22 16:20 ` Stefano Garzarella
2025-01-22 16:29 ` Michael S. Tsirkin
2025-01-22 16:41 ` Laurent Vivier
2025-01-22 16:51 ` Stefano Garzarella
2025-01-22 17:22 ` Laurent Vivier
2025-01-22 17:30 ` Daniel P. Berrangé
2025-01-24 16:03 ` Stefano Brivio
2025-02-20 15:28 ` Michael S. Tsirkin
2025-02-20 16:59 ` Stefano Brivio [this message]
2025-02-20 18:21 ` Michael S. Tsirkin
2025-02-20 20:00 ` Stefano Brivio
2025-02-20 20:45 ` Michael S. Tsirkin
2025-02-21 1:18 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250220175910.25688823@elisabeth \
--to=sbrivio@redhat.com \
--cc=jasowang@redhat.com \
--cc=lvivier@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sgarzare@redhat.com \
--cc=thibaut.collet@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).