qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Subject: [PULL 03/43] monitor/hmp-cmds.c: Clean up hmp_dumpdtb printf
Date: Tue, 25 Feb 2025 18:04:29 +0000	[thread overview]
Message-ID: <20250225180510.1318207-4-peter.maydell@linaro.org> (raw)
In-Reply-To: <20250225180510.1318207-1-peter.maydell@linaro.org>

In hmp_dumpdtb(), we print a message when the command succeeds.  This
message is missing the trailing \n, so the HMP command prompt is
printed immediately after it.  We also weren't capitalizing 'DTB', or
quoting the filename in the message.  Fix these nits.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-id: 20250206151214.2947842-2-peter.maydell@linaro.org
---
 monitor/hmp-cmds.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
index 3825ff40a9b..7ded3378cfc 100644
--- a/monitor/hmp-cmds.c
+++ b/monitor/hmp-cmds.c
@@ -431,6 +431,6 @@ void hmp_dumpdtb(Monitor *mon, const QDict *qdict)
         return;
     }
 
-    monitor_printf(mon, "dtb dumped to %s", filename);
+    monitor_printf(mon, "DTB dumped to '%s'\n", filename);
 }
 #endif
-- 
2.43.0



  parent reply	other threads:[~2025-02-25 18:06 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-25 18:04 [PULL 00/43] target-arm queue Peter Maydell
2025-02-25 18:04 ` [PULL 01/43] hw/arm/smmuv3: Fill u.f_cd_fetch.addr for SMMU_EVT_F_CD_FETCH Peter Maydell
2025-02-25 18:04 ` [PULL 02/43] hw/arm/virt: Support larger highmem MMIO regions Peter Maydell
2025-02-25 18:04 ` Peter Maydell [this message]
2025-02-25 18:04 ` [PULL 04/43] hw/openrisc: Support monitor dumpdtb command Peter Maydell
2025-02-25 18:04 ` [PULL 05/43] hw/mips/boston: Check for error return from boston_fdt_filter() Peter Maydell
2025-02-25 18:04 ` [PULL 06/43] hw/mips/boston: Support dumpdtb monitor commands Peter Maydell
2025-02-25 18:04 ` [PULL 07/43] hw: Centralize handling of -machine dumpdtb option Peter Maydell
2025-02-25 18:04 ` [PULL 08/43] hw/core/machine.c: Make -machine dumpdtb=file.dtb with no DTB an error Peter Maydell
2025-02-25 18:04 ` [PULL 09/43] fpu: Make targets specify floatx80 default Inf at runtime Peter Maydell
2025-02-25 18:04 ` [PULL 10/43] target/m68k: Avoid using floatx80_infinity global const Peter Maydell
2025-02-25 18:04 ` [PULL 11/43] target/i386: " Peter Maydell
2025-02-25 18:04 ` [PULL 12/43] fpu: Pass float_status to floatx80_is_infinity() Peter Maydell
2025-02-25 18:04 ` [PULL 13/43] fpu: Make targets specify whether floatx80 Inf can have Int bit clear Peter Maydell
2025-02-25 18:04 ` [PULL 14/43] fpu: Pass float_status to floatx80_invalid_encoding() Peter Maydell
2025-02-25 18:04 ` [PULL 15/43] fpu: Make floatx80 invalid encoding settable at runtime Peter Maydell
2025-02-25 18:04 ` [PULL 16/43] fpu: Move m68k_denormal fmt flag into floatx80_behaviour Peter Maydell
2025-02-25 18:04 ` [PULL 17/43] fpu: Always decide no_signaling_nans() at runtime Peter Maydell
2025-02-25 18:04 ` [PULL 18/43] fpu: Always decide snan_bit_is_one() " Peter Maydell
2025-02-25 18:04 ` [PULL 19/43] fpu: Don't compile-time disable hardfloat for PPC targets Peter Maydell
2025-02-25 18:04 ` [PULL 20/43] fpu: Build only once Peter Maydell
2025-02-25 18:04 ` [PULL 21/43] target/arm: Move TCG-only VFP code into tcg/ subdir Peter Maydell
2025-02-25 18:04 ` [PULL 22/43] target/arm: Move FPSCR get/set helpers to tcg/vfp_helper.c Peter Maydell
2025-02-25 18:04 ` [PULL 23/43] target/arm: Move softfloat specific FPCR/FPSR handling to tcg/ Peter Maydell
2025-02-25 18:04 ` [PULL 24/43] target/arm: Rename vfp_helper.c to vfp_fpscr.c Peter Maydell
2025-02-25 18:04 ` [PULL 25/43] target/arm/hvf: Disable SME feature Peter Maydell
2025-02-25 18:04 ` [PULL 26/43] target/arm/hvf: sign extend the data for a load operation when SSE=1 Peter Maydell
2025-02-25 18:04 ` [PULL 27/43] hw/misc/npcm_clk: fix buffer-overflow Peter Maydell
2025-02-25 18:04 ` [PULL 28/43] hw/usb/hcd-dwc3: Align global registers size with Linux Peter Maydell
2025-02-25 18:04 ` [PULL 29/43] hw/pci-host/designware: Prevent device attachment on internal PCIe root bus Peter Maydell
2025-02-25 18:04 ` [PULL 30/43] hw/gpio/pca955*: Move Kconfig switches next to implementations Peter Maydell
2025-02-25 18:04 ` [PULL 31/43] hw/arm: Add i.MX 8M Plus EVK board Peter Maydell
2025-03-12  9:40   ` Thomas Huth
2025-03-12 10:05     ` Philippe Mathieu-Daudé
2025-03-12 10:20     ` Peter Maydell
2025-03-12 10:27       ` Philippe Mathieu-Daudé
2025-03-12 10:44         ` Cédric Le Goater
2025-03-12 11:13           ` Peter Maydell
2025-03-12 16:33             ` Bernhard Beschow
2025-02-25 18:04 ` [PULL 32/43] hw/arm/fsl-imx8mp: Implement clock tree Peter Maydell
2025-02-25 18:04 ` [PULL 33/43] hw/arm/fsl-imx8mp: Add SNVS Peter Maydell
2025-02-25 18:05 ` [PULL 34/43] hw/arm/fsl-imx8mp: Add USDHC storage controllers Peter Maydell
2025-02-25 18:05 ` [PULL 35/43] hw/arm/fsl-imx8mp: Add PCIe support Peter Maydell
2025-02-25 18:05 ` [PULL 36/43] hw/arm/fsl-imx8mp: Add GPIO controllers Peter Maydell
2025-02-25 18:05 ` [PULL 37/43] hw/arm/fsl-imx8mp: Add I2C controllers Peter Maydell
2025-02-25 18:05 ` [PULL 38/43] hw/arm/fsl-imx8mp: Add SPI controllers Peter Maydell
2025-02-25 18:05 ` [PULL 39/43] hw/arm/fsl-imx8mp: Add watchdog support Peter Maydell
2025-02-25 18:05 ` [PULL 40/43] hw/arm/fsl-imx8mp: Implement general purpose timers Peter Maydell
2025-02-25 18:05 ` [PULL 41/43] hw/arm/fsl-imx8mp: Add Ethernet controller Peter Maydell
2025-02-25 18:05 ` [PULL 42/43] hw/arm/fsl-imx8mp: Add USB support Peter Maydell
2025-02-25 18:05 ` [PULL 43/43] hw/arm/fsl-imx8mp: Add on-chip RAM Peter Maydell
2025-03-03 12:13 ` [PULL 00/43] target-arm queue Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250225180510.1318207-4-peter.maydell@linaro.org \
    --to=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).