From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: Igor Mammedov <imammedo@redhat.com>
Cc: "Michael S . Tsirkin" <mst@redhat.com>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
"Shiju Jose" <shiju.jose@huawei.com>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Ani Sinha" <anisinha@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Shannon Zhao" <shannon.zhaosl@gmail.com>,
"Yanan Wang" <wangyanan55@huawei.com>,
"Zhao Liu" <zhao1.liu@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 08/14] acpi/generic_event_device: add logic to detect if HEST addr is available
Date: Thu, 27 Feb 2025 08:19:27 +0100 [thread overview]
Message-ID: <20250227081927.726a1938@foz.lan> (raw)
In-Reply-To: <20250226165226.49b88429@imammedo.users.ipa.redhat.com>
Em Wed, 26 Feb 2025 16:52:26 +0100
Igor Mammedov <imammedo@redhat.com> escreveu:
> On Fri, 21 Feb 2025 15:35:17 +0100
> Mauro Carvalho Chehab <mchehab+huawei@kernel.org> wrote:
>
> > diff --git a/hw/acpi/generic_event_device.c b/hw/acpi/generic_event_device.c
> > index 5346cae573b7..14d8513a5440 100644
> > --- a/hw/acpi/generic_event_device.c
> > +++ b/hw/acpi/generic_event_device.c
> > @@ -318,6 +318,7 @@ static void acpi_ged_send_event(AcpiDeviceIf *adev, AcpiEventStatusBits ev)
> >
> > static const Property acpi_ged_properties[] = {
> > DEFINE_PROP_UINT32("ged-event", AcpiGedState, ged_event_bitmap, 0),
> > + DEFINE_PROP_BOOL("x-has-hest-addr", AcpiGedState, ghes_state.use_hest_addr, false),
>
> you below set it for 9.2 to false, so
> shouldn't it be set to true by default here?
Yes, but it is too early to do that here, as the DSDT table was not
updated to contain the GED device.
We're switching it to true later on, at patch 11::
d8c44ee13fbe ("arm/virt: Wire up a GED error device for ACPI / GHES")
Thanks,
Mauro
next prev parent reply other threads:[~2025-02-27 7:20 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-21 14:35 [PATCH v4 00/14] Change ghes to use HEST-based offsets and add support for error inject Mauro Carvalho Chehab
2025-02-21 14:35 ` [PATCH v4 01/14] acpi/ghes: prepare to change the way HEST offsets are calculated Mauro Carvalho Chehab
2025-02-26 14:37 ` Igor Mammedov
2025-02-27 11:45 ` Mauro Carvalho Chehab
2025-02-27 12:22 ` Igor Mammedov
2025-02-21 14:35 ` [PATCH v4 02/14] acpi/ghes: add a firmware file with HEST address Mauro Carvalho Chehab
2025-02-26 14:48 ` Igor Mammedov
2025-02-21 14:35 ` [PATCH v4 03/14] acpi/ghes: Use HEST table offsets when preparing GHES records Mauro Carvalho Chehab
2025-02-26 15:16 ` Igor Mammedov
2025-02-21 14:35 ` [PATCH v4 04/14] acpi/ghes: don't hard-code the number of sources for HEST table Mauro Carvalho Chehab
2025-02-26 15:48 ` Igor Mammedov
2025-02-21 14:35 ` [PATCH v4 05/14] acpi/ghes: add a notifier to notify when error data is ready Mauro Carvalho Chehab
2025-02-21 14:35 ` [PATCH v4 06/14] acpi/ghes: create an ancillary acpi_ghes_get_state() function Mauro Carvalho Chehab
2025-02-26 15:27 ` Igor Mammedov
2025-02-21 14:35 ` [PATCH v4 07/14] acpi/generic_event_device: Update GHES migration to cover hest addr Mauro Carvalho Chehab
2025-02-21 14:35 ` [PATCH v4 08/14] acpi/generic_event_device: add logic to detect if HEST addr is available Mauro Carvalho Chehab
2025-02-26 15:52 ` Igor Mammedov
2025-02-27 7:19 ` Mauro Carvalho Chehab [this message]
2025-02-27 7:26 ` Mauro Carvalho Chehab
2025-02-27 9:50 ` Igor Mammedov
2025-02-21 14:35 ` [PATCH v4 09/14] acpi/generic_event_device: add an APEI error device Mauro Carvalho Chehab
2025-02-21 14:35 ` [PATCH v4 10/14] tests/acpi: virt: allow acpi table changes for a new table: HEST Mauro Carvalho Chehab
2025-02-26 15:55 ` Igor Mammedov
2025-02-21 14:35 ` [PATCH v4 11/14] arm/virt: Wire up a GED error device for ACPI / GHES Mauro Carvalho Chehab
2025-02-26 15:58 ` Igor Mammedov
2025-02-21 14:35 ` [PATCH v4 12/14] tests/acpi: virt: add a HEST table to aarch64 virt and update DSDT Mauro Carvalho Chehab
2025-02-21 14:35 ` [PATCH v4 13/14] qapi/acpi-hest: add an interface to do generic CPER error injection Mauro Carvalho Chehab
2025-02-21 14:35 ` [PATCH v4 14/14] scripts/ghes_inject: add a script to generate GHES error inject Mauro Carvalho Chehab
2025-02-26 14:16 ` [PATCH v4 00/14] Change ghes to use HEST-based offsets and add support for " Igor Mammedov
2025-02-26 14:39 ` Mauro Carvalho Chehab
2025-02-26 14:51 ` Igor Mammedov
2025-02-26 16:00 ` Igor Mammedov
2025-02-27 9:54 ` Igor Mammedov
2025-02-27 11:05 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250227081927.726a1938@foz.lan \
--to=mchehab+huawei@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=anisinha@redhat.com \
--cc=eduardo@habkost.net \
--cc=imammedo@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shannon.zhaosl@gmail.com \
--cc=shiju.jose@huawei.com \
--cc=wangyanan55@huawei.com \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).