From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BD162C021BE for ; Thu, 27 Feb 2025 07:28:11 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tnYIr-0002JJ-NT; Thu, 27 Feb 2025 02:27:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tnYIT-0002Hg-U7; Thu, 27 Feb 2025 02:27:07 -0500 Received: from tor.source.kernel.org ([2600:3c04::f03c:95ff:fe5e:7468]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tnYIM-0003m8-UR; Thu, 27 Feb 2025 02:27:02 -0500 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 38EA461142; Thu, 27 Feb 2025 07:26:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED916C4CEDD; Thu, 27 Feb 2025 07:26:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740641205; bh=41nmpp5KDbERU9SbSANLYVIk9B28KAHdXRn1eUEpQ6k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dNuiow7FIYRNbE/filmO2qq1r5obkAwoY+YUY+n5iXQZ+yOAV5/qpFn5T45fII7/c IKWiHUPOEJmZVeNoTiOOYD426DXuEz2cxlv6XgBUd8fpFUmfkUQRCxrMkyGfszqHKh v0FheXupVnu0NyTy6wyq1QCR4ks/ydF3Ea9qtauQYh9oJD1JEZv1rP5VtXOsV7rhxq 8PTIFRqQ+V+7cr6ap0qewi9ye77u/bxU9wLbubRBeDE3CYnYFUjbVZDec1+oiWOFs1 zUJHo4TsE9DXBp3RMPgECzehRGotqHCqvZpuEPR/HrPphI4QKyVUrySypmxn6vULr7 ZAc87g8prv8rw== Date: Thu, 27 Feb 2025 08:26:38 +0100 From: Mauro Carvalho Chehab To: Igor Mammedov Cc: "Michael S . Tsirkin" , Jonathan Cameron , Shiju Jose , qemu-arm@nongnu.org, qemu-devel@nongnu.org, Philippe =?UTF-8?B?TWF0aGll?= =?UTF-8?B?dS1EYXVkw6k=?= , Ani Sinha , Eduardo Habkost , Marcel Apfelbaum , Peter Maydell , Shannon Zhao , Yanan Wang , Zhao Liu , linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 08/14] acpi/generic_event_device: add logic to detect if HEST addr is available Message-ID: <20250227082638.7db90257@foz.lan> In-Reply-To: <20250227081927.726a1938@foz.lan> References: <20250226165226.49b88429@imammedo.users.ipa.redhat.com> <20250227081927.726a1938@foz.lan> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2600:3c04::f03c:95ff:fe5e:7468; envelope-from=mchehab+huawei@kernel.org; helo=tor.source.kernel.org X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.44, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Em Thu, 27 Feb 2025 08:19:27 +0100 Mauro Carvalho Chehab escreveu: > Em Wed, 26 Feb 2025 16:52:26 +0100 > Igor Mammedov escreveu: > > > On Fri, 21 Feb 2025 15:35:17 +0100 > > Mauro Carvalho Chehab wrote: > > > > > > diff --git a/hw/acpi/generic_event_device.c b/hw/acpi/generic_event_device.c > > > index 5346cae573b7..14d8513a5440 100644 > > > --- a/hw/acpi/generic_event_device.c > > > +++ b/hw/acpi/generic_event_device.c > > > @@ -318,6 +318,7 @@ static void acpi_ged_send_event(AcpiDeviceIf *adev, AcpiEventStatusBits ev) > > > > > > static const Property acpi_ged_properties[] = { > > > DEFINE_PROP_UINT32("ged-event", AcpiGedState, ged_event_bitmap, 0), > > > + DEFINE_PROP_BOOL("x-has-hest-addr", AcpiGedState, ghes_state.use_hest_addr, false), > > > > you below set it for 9.2 to false, so > > shouldn't it be set to true by default here? > > Yes, but it is too early to do that here, as the DSDT table was not > updated to contain the GED device. > > We're switching it to true later on, at patch 11:: > > d8c44ee13fbe ("arm/virt: Wire up a GED error device for ACPI / GHES") Hmm... too many rebases that on my head things are becoming shady ;-) Originally, this was setting it to true, but you requested to move it to another patch during one of the patch reorder requests. Anyway, after all those rebases, I guess it is now safe to set it to true here without breaking bisectability. I'll move the hunk back to this patch. Thanks, Mauro