From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, berrange@redhat.com, eduardo@habkost.net
Subject: [PATCH v2 6/6] qdev: Improve a few more PropertyInfo @description members
Date: Thu, 27 Feb 2025 09:56:01 +0100 [thread overview]
Message-ID: <20250227085601.4140852-7-armbru@redhat.com> (raw)
In-Reply-To: <20250227085601.4140852-1-armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
hw/block/xen-block.c | 2 +-
hw/core/qdev-properties-system.c | 2 +-
hw/core/qdev-properties.c | 1 +
hw/s390x/ccw-device.c | 4 ++--
target/sparc/cpu.c | 1 +
5 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/hw/block/xen-block.c b/hw/block/xen-block.c
index 7c9d1b658c..2098286b5f 100644
--- a/hw/block/xen-block.c
+++ b/hw/block/xen-block.c
@@ -662,7 +662,7 @@ invalid:
*/
static const PropertyInfo xen_block_prop_vdev = {
.type = "str",
- .description = "Virtual Disk specifier: d*p*/xvd*/hd*/sd*",
+ .description = "Virtual Disk specifier (d*p*/xvd*/hd*/sd*)",
.get = xen_block_get_vdev,
.set = xen_block_set_vdev,
};
diff --git a/hw/core/qdev-properties-system.c b/hw/core/qdev-properties-system.c
index aa7600bce6..1f01eb3e59 100644
--- a/hw/core/qdev-properties-system.c
+++ b/hw/core/qdev-properties-system.c
@@ -985,7 +985,7 @@ inval:
const PropertyInfo qdev_prop_pci_host_devaddr = {
.type = "str",
- .description = "Address (bus/device/function) of "
+ .description = "Address (bus:device.function) of "
"the host device, example: 04:10.0",
.get = get_pci_host_devaddr,
.set = set_pci_host_devaddr,
diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c
index 5a801057db..c04df3b337 100644
--- a/hw/core/qdev-properties.c
+++ b/hw/core/qdev-properties.c
@@ -247,6 +247,7 @@ static void set_bool(Object *obj, Visitor *v, const char *name, void *opaque,
const PropertyInfo qdev_prop_bool = {
.type = "bool",
+ .description = "on/off",
.get = get_bool,
.set = set_bool,
.set_default_value = set_default_value_bool,
diff --git a/hw/s390x/ccw-device.c b/hw/s390x/ccw-device.c
index 1d4b8ea35c..1ea9934f6c 100644
--- a/hw/s390x/ccw-device.c
+++ b/hw/s390x/ccw-device.c
@@ -75,8 +75,8 @@ static void ccw_device_set_loadparm(Object *obj, Visitor *v,
const PropertyInfo ccw_loadparm = {
.type = "str",
- .description = "Up to 8 chars in set of [A-Za-z0-9. ] to pass"
- " to the guest loader/kernel",
+ .description = "Up to 8 chars in set of [A-Za-z0-9. ] to select"
+ " a guest kernel",
.get = ccw_device_get_loadparm,
.set = ccw_device_set_loadparm,
};
diff --git a/target/sparc/cpu.c b/target/sparc/cpu.c
index c8ea35be76..f0613f8a8e 100644
--- a/target/sparc/cpu.c
+++ b/target/sparc/cpu.c
@@ -939,6 +939,7 @@ static void sparc_set_nwindows(Object *obj, Visitor *v, const char *name,
static const PropertyInfo qdev_prop_nwindows = {
.type = "int",
+ .description = "Number of register windows",
.get = sparc_get_nwindows,
.set = sparc_set_nwindows,
};
--
2.48.1
next prev parent reply other threads:[~2025-02-27 8:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-27 8:55 [PATCH v2 0/6] Property type reporting improvements Markus Armbruster
2025-02-27 8:55 ` [PATCH v2 1/6] qdev: Delete unused qdev_prop_enum Markus Armbruster
2025-02-27 9:16 ` Daniel P. Berrangé
2025-02-27 8:55 ` [PATCH v2 2/6] qdev: Change qdev_prop_pci_devfn member @name from "int32" to "str" Markus Armbruster
2025-02-27 9:20 ` Daniel P. Berrangé
2025-02-27 8:55 ` [PATCH v2 3/6] qdev: Rename PropertyInfo member @name to @type Markus Armbruster
2025-02-27 9:21 ` Daniel P. Berrangé
2025-02-27 8:55 ` [PATCH v2 4/6] qdev: Change values of PropertyInfo member @type to be QAPI types Markus Armbruster
2025-02-27 9:25 ` Daniel P. Berrangé
2025-02-27 10:22 ` Markus Armbruster
2025-02-27 8:56 ` [PATCH v2 5/6] qdev: Improve PropertyInfo member @description for enum properties Markus Armbruster
2025-02-27 9:29 ` Daniel P. Berrangé
2025-02-27 8:56 ` Markus Armbruster [this message]
2025-02-27 9:31 ` [PATCH v2 6/6] qdev: Improve a few more PropertyInfo @description members Daniel P. Berrangé
2025-02-27 10:25 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250227085601.4140852-7-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eduardo@habkost.net \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).