From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B3F57C021BE for ; Thu, 27 Feb 2025 09:23:40 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tna6v-0003Sn-5U; Thu, 27 Feb 2025 04:23:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tna6k-0003QS-GV for qemu-devel@nongnu.org; Thu, 27 Feb 2025 04:23:06 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tna6h-00072i-W2 for qemu-devel@nongnu.org; Thu, 27 Feb 2025 04:23:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740648182; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bvc3U+oxlRfGkjPKGcsbVZOouyuZCVX/xbNNQfW1YfE=; b=RPJQO7dpHkOh8H86YwWSLuWZxcpGhHWh4q5z2zM19XdlQRB0XPkqcJR+J1xp+alUVNJb+4 nw0+d17LiRzFvq2lFIKzQP/ntqjOsBSxd67J/NTh6FTviJBW4HOprCOL+GCAa2yzu89PvR zdVV+9XduR8BlpyYIwKFo5EXN0EbKWM= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-303-go8mvwsoN0Oo73ckSQbGwQ-1; Thu, 27 Feb 2025 04:23:00 -0500 X-MC-Unique: go8mvwsoN0Oo73ckSQbGwQ-1 X-Mimecast-MFC-AGG-ID: go8mvwsoN0Oo73ckSQbGwQ_1740648179 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-38f4cce15c8so265919f8f.2 for ; Thu, 27 Feb 2025 01:23:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740648179; x=1741252979; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bvc3U+oxlRfGkjPKGcsbVZOouyuZCVX/xbNNQfW1YfE=; b=ePF3xZBWyrKImCXt/GuVjxtD00D9MWHgWGI7LmT0EbIDt+7J/9hwitxnVDCQbFU2Q+ A5wr6RX9Bf+Pm4CX8ok1v+CtHCjazVOtB2FdYAL/C1nCYZ2Utq31sk+ECzmpO1mRylvo w7ewrwz1ODnHJwCowCWuACxR8gAjxjTLdsIZ8HEJvp+8JxQWV8WPp6MU8ARwDEJinptq aaBSHYU7xry3oER+Seofpx63mLT8s0yUNYRLaVoMNlh8gRxZ/z4DYGzDuu08vBdm1O6W Jx3U/1shaNm5Rl5gJY4J5aV5F7Vc6U2mUegFaLKxgOK/AQJzN9hucvBqtokrv/EWoGYp yxhQ== X-Forwarded-Encrypted: i=1; AJvYcCVxYjRs4Szn2J7huOdhs3xPQSP2RA+qsGxTSkgVNs72CuOOtMkuTZPLhc8z4wJT67lnksXZQT737EBj@nongnu.org X-Gm-Message-State: AOJu0YxdfaSzhBliNZ2GcH3UrDGKwC8x3ghDgP0I4h2RJhT9w6MpgD6b czUdrpY3dIfK2tTrJr1s93S3xHdVY5z4tjMc/g2y9lSZxfH8PGBm078LrfUXfEmRxpfXOnrG3CG 54h3j6oR32Kn/bnqEIbYCHsWuycOgO5hOT5s1QQot4ikmcMtUpOXD X-Gm-Gg: ASbGncv2JdCSe+l36SzcO4oohhKooVkjoBpKNlnWqQCF/sO013+toSgmibcEe9v3agK ljjqf/uJGSEm6PhKVU78YH5qzpTgrQDvvhNSo0xInFVI7fiGhC8zKFpk4qnLGWVhj/ElowOhW3z YQ0TLXEfWjIA/Tcqj6GNo3dp+R+0YenCyNNCzBzHyATan474CtiUGntrhG53M2nBpaMuaOsdR23 SU3Fma5g94NLh937GVuh/da8OmZRczLIkVpRhOFIPshZ+3Ed6n2kuHeWsz/oLj+uLHiov+XHKum 7HzU+7qOJvLUIcPhQ3G/ZGTb/VbcJnT0QS0Uf4I4PxzjWtbxLtzsSB8TSKJPx5k= X-Received: by 2002:a05:6000:4021:b0:38e:d4b3:9454 with SMTP id ffacd0b85a97d-390cc63234amr7744991f8f.34.1740648178992; Thu, 27 Feb 2025 01:22:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IEY54InkZjeoTNKzDwyztQKqMxzMHIajou66g+i8NzPePg0lroQPT6XK0MIss9/huXJWUf8uQ== X-Received: by 2002:a05:6000:4021:b0:38e:d4b3:9454 with SMTP id ffacd0b85a97d-390cc63234amr7744969f8f.34.1740648178606; Thu, 27 Feb 2025 01:22:58 -0800 (PST) Received: from imammedo.users.ipa.redhat.com (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-390e47a6d0asm1404033f8f.27.2025.02.27.01.22.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Feb 2025 01:22:57 -0800 (PST) Date: Thu, 27 Feb 2025 10:22:55 +0100 From: Igor Mammedov To: Mauro Carvalho Chehab Cc: "Michael S . Tsirkin" , Jonathan Cameron , Shiju Jose , qemu-arm@nongnu.org, qemu-devel@nongnu.org, Ani Sinha , Dongjiu Geng , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 03/14] acpi/ghes: Use HEST table offsets when preparing GHES records Message-ID: <20250227102255.6843705e@imammedo.users.ipa.redhat.com> In-Reply-To: <20250226171406.19c2de6b@sal.lan> References: <9610ff88cf6fdc59cbfc8871d653fd890391be1e.1738345063.git.mchehab+huawei@kernel.org> <20250203153423.3e4de17c@imammedo.users.ipa.redhat.com> <20250221070221.329bdfb0@foz.lan> <20250225104327.0a2d1cb4@imammedo.users.ipa.redhat.com> <20250226171406.19c2de6b@sal.lan> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.44, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, 26 Feb 2025 17:14:06 +0100 Mauro Carvalho Chehab wrote: > Em Tue, 25 Feb 2025 10:43:27 +0100 > Igor Mammedov escreveu: > > > On Fri, 21 Feb 2025 07:02:21 +0100 > > Mauro Carvalho Chehab wrote: > > > > > Em Mon, 3 Feb 2025 15:34:23 +0100 > > > Igor Mammedov escreveu: > > > > > > > On Fri, 31 Jan 2025 18:42:44 +0100 > > > > Mauro Carvalho Chehab wrote: > > > > > > > > > There are two pointers that are needed during error injection: > > > > > > > > > > 1. The start address of the CPER block to be stored; > > > > > 2. The address of the ack. > > > > > > > > > > It is preferable to calculate them from the HEST table. This allows > > > > > checking the source ID, the size of the table and the type of the > > > > > HEST error block structures. > > > > > > > > > > Yet, keep the old code, as this is needed for migration purposes. > > > > > > > > > > Signed-off-by: Mauro Carvalho Chehab > > > > > --- > > > > > hw/acpi/ghes.c | 132 ++++++++++++++++++++++++++++++++++++----- > > > > > include/hw/acpi/ghes.h | 1 + > > > > > 2 files changed, 119 insertions(+), 14 deletions(-) > > > > > > > > > > diff --git a/hw/acpi/ghes.c b/hw/acpi/ghes.c > > > > > index 27478f2d5674..8f284fd191a6 100644 > > > > > --- a/hw/acpi/ghes.c > > > > > +++ b/hw/acpi/ghes.c > > > > > @@ -41,6 +41,12 @@ > > > > > /* Address offset in Generic Address Structure(GAS) */ > > > > > #define GAS_ADDR_OFFSET 4 > > > > > > > > > > +/* > > > > > + * ACPI spec 1.0b > > > > > + * 5.2.3 System Description Table Header > > > > > + */ > > > > > +#define ACPI_DESC_HEADER_OFFSET 36 > > > > > + > > > > > /* > > > > > * The total size of Generic Error Data Entry > > > > > * ACPI 6.1/6.2: 18.3.2.7.1 Generic Error Data, > > > > > @@ -61,6 +67,25 @@ > > > > > */ > > > > > #define ACPI_GHES_GESB_SIZE 20 > > > > > > > > > > +/* > > > > > + * Offsets with regards to the start of the HEST table stored at > > > > > + * ags->hest_addr_le, > > > > > > > > If I read this literary, then offsets above are not what > > > > declared later in this patch. > > > > I'd really drop this comment altogether as it's confusing, > > > > and rather get variables/macro naming right > > > > > > > > > according with the memory layout map at > > > > > + * docs/specs/acpi_hest_ghes.rst. > > > > > + */ > > > > > > > > what we need is update to above doc, describing new and old ways. > > > > a separate patch. > > > > > > I can't see anything that should be changed at > > > docs/specs/acpi_hest_ghes.rst, as this series doesn't change the > > > firmware layout: we're still using two firmware tables: > > > > > > - etc/acpi/tables, with HEST on it; > > > - etc/hardware_errors, with: > > > - error block addresses; > > > - read_ack registers; > > > - CPER records. > > > > > > The only changes that this series introduce are related to how > > > the error generation logic navigates between HEST and hw_errors > > > firmware. This is not described at acpi_hest_ghes.rst, and both > > > ways follow ACPI specs to the letter. > > > > > > The only difference is that the code which populates the CPER > > > record and the error/read offsets doesn't require to know how > > > the HEST table generation placed offsets, as it will basically > > > reproduce what OSPM firmware does when handling HEST events. > > > > section 8 describes old way to get to address to record old CPER, > > so it needs to amended to also describe a new approach and say > > which way is used for which version. > > > > possibly section 11 might need some messaging as well. > > Ok, I'll modify it and place at the end of the series. Please > see below if the new text is ok for you. > > --- > > [PATCH] docs/specs/acpi_hest_ghes.rst: update it to reflect some changes s/^^^/docs: hest: add new "etc/acpi_table_hest_addr" and update workflow/ > > While the HEST layout didn't change, there are some internal > changes related to how offsets are calculated and how memory error > events are triggered. > > Update specs to reflect such changes. > > Signed-off-by: Mauro Carvalho Chehab > > diff --git a/docs/specs/acpi_hest_ghes.rst b/docs/specs/acpi_hest_ghes.rst > index c3e9f8d9a702..f22d2eefdec7 100644 > --- a/docs/specs/acpi_hest_ghes.rst > +++ b/docs/specs/acpi_hest_ghes.rst > @@ -89,12 +89,21 @@ Design Details > addresses in the "error_block_address" fields with a pointer to the > respective "Error Status Data Block" in the "etc/hardware_errors" blob. > > -(8) QEMU defines a third and write-only fw_cfg blob which is called > - "etc/hardware_errors_addr". Through that blob, the firmware can send back > - the guest-side allocation addresses to QEMU. The "etc/hardware_errors_addr" > - blob contains a 8-byte entry. QEMU generates a single WRITE_POINTER command > - for the firmware. The firmware will write back the start address of > - "etc/hardware_errors" blob to the fw_cfg file "etc/hardware_errors_addr". > +(8) QEMU defines a third and write-only fw_cfg blob to store the location > + where the error block offsets, read ack registers and CPER records are > + stored. > + > + Up to QEMU 9.2, the location was at "etc/hardware_errors_addr", and > + contains an offset for the beginning of "etc/hardware_errors". > + > + Newer versions place the location at "etc/acpi_table_hest_addr", > + pointing to the beginning of the HEST table. > + > + Through that such offsets, the firmware can send back the guest-side ^^^^^^^^^^^^^^^^^^^^^^^^^ can't parse that, suggest to just drop the phrase > + allocation addresses to QEMU. They contain a 8-byte entry. QEMU generates > + a single WRITE_POINTER command for the firmware. The firmware will write > + back the start address of either "etc/hardware_errors" or HEST table at ^^^^ drop this? > + the correspoinding address firmware. > > (9) When QEMU gets a SIGBUS from the kernel, QEMU writes CPER into corresponding > "Error Status Data Block", guest memory, and then injects platform specific > @@ -105,8 +114,6 @@ Design Details > kernel, on receiving notification, guest APEI driver could read the CPER error > and take appropriate action. > > -(11) kvm_arch_on_sigbus_vcpu() uses source_id as index in "etc/hardware_errors" to > - find out "Error Status Data Block" entry corresponding to error source. So supported > - source_id values should be assigned here and not be changed afterwards to make sure > - that guest will write error into expected "Error Status Data Block" even if guest was > - migrated to a newer QEMU. > +(11) kvm_arch_on_sigbus_vcpu() report RAS errors via a SEA notifications, > + when a SIGBUS event is triggered. > The logic to convert a SEA notification > + into a source ID is defined inside ghes.c source file. that's cheating and not documentation by any means > > >