qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] chardev: express dependency on io/
@ 2025-02-27 12:50 Paolo Bonzini
  2025-02-27 13:11 ` Daniel P. Berrangé
  0 siblings, 1 reply; 2+ messages in thread
From: Paolo Bonzini @ 2025-02-27 12:50 UTC (permalink / raw)
  To: qemu-devel

chardev is using qio functions, so express that in the Meson internal
dependency.  (I found this when adding character devices bindings for
Rust; they initially needed the io dependency added by hand).

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meson.build b/meson.build
index 0a2c61d2bfa..9b1c0ba6346 100644
--- a/meson.build
+++ b/meson.build
@@ -4013,7 +4013,7 @@ libchardev = static_library('chardev', chardev_ss.sources() + genh,
                             build_by_default: false)
 
 chardev = declare_dependency(objects: libchardev.extract_all_objects(recursive: false),
-                             dependencies: chardev_ss.dependencies())
+                             dependencies: [chardev_ss.dependencies(), io])
 
 hwcore_ss = hwcore_ss.apply({})
 libhwcore = static_library('hwcore', sources: hwcore_ss.sources() + genh,
-- 
2.48.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] chardev: express dependency on io/
  2025-02-27 12:50 [PATCH] chardev: express dependency on io/ Paolo Bonzini
@ 2025-02-27 13:11 ` Daniel P. Berrangé
  0 siblings, 0 replies; 2+ messages in thread
From: Daniel P. Berrangé @ 2025-02-27 13:11 UTC (permalink / raw)
  To: Paolo Bonzini; +Cc: qemu-devel

On Thu, Feb 27, 2025 at 01:50:03PM +0100, Paolo Bonzini wrote:
> chardev is using qio functions, so express that in the Meson internal
> dependency.  (I found this when adding character devices bindings for
> Rust; they initially needed the io dependency added by hand).
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-02-27 13:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-27 12:50 [PATCH] chardev: express dependency on io/ Paolo Bonzini
2025-02-27 13:11 ` Daniel P. Berrangé

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).