From: Nicholas Piggin <npiggin@gmail.com>
To: qemu-ppc@nongnu.org
Cc: Nicholas Piggin <npiggin@gmail.com>, qemu-devel@nongnu.org
Subject: [PATCH 0/3] target/ppc: Fixes for TCG TLB modeling of some MMU SPRs
Date: Mon, 3 Mar 2025 21:23:11 +1000 [thread overview]
Message-ID: <20250303112315.586478-1-npiggin@gmail.com> (raw)
Any register or memory value that is used by the .tlb_fill
function (e.g., in ppc_xlate()) can affect what gets put in TCG's
TLB, so changing it requires either: that the ISA permits cached
address translations that become incoherent vs the changed value;
that TCG TLB is "tagged" with the changing value (e.g., with mmuidx);
or that the TCG TLB is flushed.
ppc is missing a few such flushes. Other than the AMR flush, Linux/KVM
probably covers such SPR changes with other flushes (e.g., context
switching between guests or guest/host will update LPCR and LPIDR and
LPIDR update already causes a TLB flush), which explains why they
haven't caused obvious bugs.
Thanks,
Nick
Nicholas Piggin (3):
target/ppc: flush TLB on HRMOR and LPCR SPR updates
target/ppc: Avoid work if MMU SPRs are written with same value
target/ppc: add missing TLB flushes for memory protection key SPR
updates
target/ppc/helper.h | 3 ++
target/ppc/spr_common.h | 1 +
target/ppc/cpu.c | 12 +++++-
target/ppc/cpu_init.c | 6 +--
target/ppc/misc_helper.c | 85 +++++++++++++++++++++++++++++++++++++++-
target/ppc/translate.c | 62 ++++++-----------------------
6 files changed, 114 insertions(+), 55 deletions(-)
--
2.47.1
next reply other threads:[~2025-03-03 11:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-03 11:23 Nicholas Piggin [this message]
2025-03-03 11:23 ` [PATCH 1/3] target/ppc: flush TLB on HRMOR and LPCR SPR updates Nicholas Piggin
2025-03-03 11:23 ` [PATCH 2/3] target/ppc: Avoid work if MMU SPRs are written with same value Nicholas Piggin
2025-03-03 11:23 ` [PATCH 3/3] target/ppc: add missing TLB flushes for memory protection key SPR updates Nicholas Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250303112315.586478-1-npiggin@gmail.com \
--to=npiggin@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).