qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
	David Hildenbrand <david@redhat.com>
Subject: [PULL 11/15] tests/functional/test_virtio_balloon: Only use KVM for running this test
Date: Fri,  7 Mar 2025 12:53:10 +0100	[thread overview]
Message-ID: <20250307115314.1096373-12-thuth@redhat.com> (raw)
In-Reply-To: <20250307115314.1096373-1-thuth@redhat.com>

The virtio_balloon test is currently hanging for unknown reasons
when being run on the shared gitlab CI runners (which don't provide
KVM, thus it's running in TCG mode there). All other functional tests
that use the same asset (the Fedora 31 kernel) have already been
marked to work only with KVM in the past, so those other tests are
skipped on the shared gitlab CI runners. As long as the problem isn't
fully understood and fixed, let's do the same with the virtio_balloon
test to avoid that the CI is failing here.

Message-ID: <20250307063904.1081961-1-thuth@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/functional/test_virtio_balloon.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/functional/test_virtio_balloon.py b/tests/functional/test_virtio_balloon.py
index 082bf08c4e8..5877b6c408c 100755
--- a/tests/functional/test_virtio_balloon.py
+++ b/tests/functional/test_virtio_balloon.py
@@ -110,6 +110,7 @@ def assert_running_stats(self, then):
 
     def test_virtio_balloon_stats(self):
         self.set_machine('q35')
+        self.require_accelerator("kvm")
         kernel_path = self.ASSET_KERNEL.fetch()
         initrd_path = self.ASSET_INITRD.fetch()
         diskimage_path = self.ASSET_DISKIMAGE.fetch()
@@ -122,7 +123,7 @@ def test_virtio_balloon_stats(self):
         # reset, we can reliably catch the clean stats again in BIOS
         # phase before the guest OS launches
         self.vm.add_args("-boot", "menu=on")
-        self.vm.add_args("-machine", "q35,accel=kvm:tcg")
+        self.vm.add_args("-accel", "kvm")
         self.vm.add_args("-device", "virtio-balloon,id=balloon")
         self.vm.add_args('-drive',
                          f'file={diskimage_path},if=none,id=drv0,snapshot=on')
-- 
2.48.1



  parent reply	other threads:[~2025-03-07 11:55 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-07 11:52 [PULL 00/15] Functional and s390x patches before 10.0 soft-freeze Thomas Huth
2025-03-07 11:53 ` [PULL 01/15] tests/functional: remove unused 'bin_prefix' variable Thomas Huth
2025-03-07 11:53 ` [PULL 02/15] tests/functional: set 'qemu_bin' as an object level field Thomas Huth
2025-03-07 11:53 ` [PULL 03/15] tests/functional: reduce tuxrun maxmem to work on 32-bit hosts Thomas Huth
2025-03-07 11:53 ` [PULL 04/15] tests/functional: skip memaddr tests on 32-bit builds Thomas Huth
2025-03-07 11:53 ` [PULL 05/15] tests/functional: drop unused 'get_tag' method Thomas Huth
2025-03-07 11:53 ` [PULL 06/15] tests/functional: stop output from zstd command when uncompressing Thomas Huth
2025-03-07 11:53 ` [PULL 07/15] tests/functional: Move the code for testing HTTP downloads to a common function Thomas Huth
2025-03-07 11:53 ` [PULL 08/15] tests/functional/test_mips_malta: Add a network test via the pcnet NIC Thomas Huth
2025-03-07 11:53 ` [PULL 09/15] tests/functional: Increase the timeout of the mips64el_replay test Thomas Huth
2025-03-07 11:53 ` [PULL 10/15] tests/functional: fix race in virtio balloon test Thomas Huth
2025-03-07 12:34   ` Philippe Mathieu-Daudé
2025-03-07 12:39     ` Thomas Huth
2025-03-07 12:42       ` Philippe Mathieu-Daudé
2025-03-07 12:45       ` Daniel P. Berrangé
2025-03-07 11:53 ` Thomas Huth [this message]
2025-03-07 11:53 ` [PULL 12/15] doc: add missing 'Asset' type in function test doc Thomas Huth
2025-03-07 11:53 ` [PULL 13/15] MAINTAINERS: Add docs/devel/testing/functional.rst to the functional section Thomas Huth
2025-03-07 11:53 ` [PULL 14/15] s390x/pci: add support for guests that request direct mapping Thomas Huth
2025-03-07 11:53 ` [PULL 15/15] s390x/pci: indicate QEMU supports relaxed translation for passthrough Thomas Huth
2025-03-09  0:41 ` [PULL 00/15] Functional and s390x patches before 10.0 soft-freeze Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250307115314.1096373-12-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=david@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).