From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Yi Liu" <yi.l.liu@intel.com>,
"Pierrick Bouvier" <pierrick.bouvier@linaro.org>,
"Alex Williamson" <alex.williamson@redhat.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Tony Krowiak" <akrowiak@linux.ibm.com>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Halil Pasic" <pasic@linux.ibm.com>,
"Thomas Huth" <thuth@redhat.com>,
"David Hildenbrand" <david@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Matthew Rosato" <mjrosato@linux.ibm.com>,
"Tomita Moeko" <tomitamoeko@gmail.com>,
qemu-ppc@nongnu.org,
"Daniel Henrique Barboza" <danielhb413@gmail.com>,
"Eric Farman" <farman@linux.ibm.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Peter Xu" <peterx@redhat.com>,
kvm@vger.kernel.org, "Zhenzhong Duan" <zhenzhong.duan@intel.com>,
qemu-s390x@nongnu.org, "Eric Auger" <eric.auger@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Harsh Prateek Bora" <harshpb@linux.ibm.com>,
"Cédric Le Goater" <clg@redhat.com>,
"Ilya Leoshkevich" <iii@linux.ibm.com>,
"Jason Herne" <jjherne@linux.ibm.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH v2 17/21] hw/vfio/ap: Check CONFIG_IOMMUFD at runtime using iommufd_builtin()
Date: Sun, 9 Mar 2025 00:09:13 +0100 [thread overview]
Message-ID: <20250308230917.18907-18-philmd@linaro.org> (raw)
In-Reply-To: <20250308230917.18907-1-philmd@linaro.org>
Convert the compile time check on the CONFIG_IOMMUFD definition
by a runtime one by calling iommufd_builtin().
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/vfio/ap.c | 25 ++++++++++++-------------
1 file changed, 12 insertions(+), 13 deletions(-)
diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c
index c7ab4ff57ad..a4ec2b5f9ac 100644
--- a/hw/vfio/ap.c
+++ b/hw/vfio/ap.c
@@ -11,7 +11,6 @@
*/
#include "qemu/osdep.h"
-#include CONFIG_DEVICES /* CONFIG_IOMMUFD */
#include <linux/vfio.h>
#include <sys/ioctl.h>
#include "qapi/error.h"
@@ -193,10 +192,11 @@ static void vfio_ap_unrealize(DeviceState *dev)
static const Property vfio_ap_properties[] = {
DEFINE_PROP_STRING("sysfsdev", VFIOAPDevice, vdev.sysfsdev),
-#ifdef CONFIG_IOMMUFD
+};
+
+static const Property vfio_ap_iommufd_properties[] = {
DEFINE_PROP_LINK("iommufd", VFIOAPDevice, vdev.iommufd,
TYPE_IOMMUFD_BACKEND, IOMMUFDBackend *),
-#endif
};
static void vfio_ap_reset(DeviceState *dev)
@@ -234,21 +234,20 @@ static void vfio_ap_instance_init(Object *obj)
vbasedev->mdev = true;
}
-#ifdef CONFIG_IOMMUFD
static void vfio_ap_set_fd(Object *obj, const char *str, Error **errp)
{
vfio_device_set_fd(&VFIO_AP_DEVICE(obj)->vdev, str, errp);
}
-#endif
static void vfio_ap_class_init(ObjectClass *klass, void *data)
{
DeviceClass *dc = DEVICE_CLASS(klass);
device_class_set_props(dc, vfio_ap_properties);
-#ifdef CONFIG_IOMMUFD
- object_class_property_add_str(klass, "fd", NULL, vfio_ap_set_fd);
-#endif
+ if (iommufd_builtin()) {
+ device_class_set_props(dc, vfio_ap_iommufd_properties);
+ object_class_property_add_str(klass, "fd", NULL, vfio_ap_set_fd);
+ }
dc->vmsd = &vfio_ap_vmstate;
dc->desc = "VFIO-based AP device assignment";
set_bit(DEVICE_CATEGORY_MISC, dc->categories);
@@ -261,11 +260,11 @@ static void vfio_ap_class_init(ObjectClass *klass, void *data)
object_class_property_set_description(klass, /* 3.1 */
"sysfsdev",
"Host sysfs path of assigned device");
-#ifdef CONFIG_IOMMUFD
- object_class_property_set_description(klass, /* 9.0 */
- "iommufd",
- "Set host IOMMUFD backend device");
-#endif
+ if (iommufd_builtin()) {
+ object_class_property_set_description(klass, /* 9.0 */
+ "iommufd",
+ "Set host IOMMUFD backend device");
+ }
}
static const TypeInfo vfio_ap_info = {
--
2.47.1
next prev parent reply other threads:[~2025-03-08 23:13 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-08 23:08 [PATCH v2 00/21] hw/vfio: Build various objects once Philippe Mathieu-Daudé
2025-03-08 23:08 ` [PATCH v2 01/21] hw/vfio/common: Include missing 'system/tcg.h' header Philippe Mathieu-Daudé
2025-03-10 8:08 ` Eric Auger
2025-03-08 23:08 ` [PATCH v2 02/21] hw/vfio/spapr: Do not include <linux/kvm.h> Philippe Mathieu-Daudé
2025-03-10 8:08 ` Eric Auger
2025-03-08 23:08 ` [PATCH v2 03/21] hw/vfio: Compile some common objects once Philippe Mathieu-Daudé
2025-03-10 8:19 ` Eric Auger
2025-03-08 23:09 ` [PATCH v2 04/21] hw/vfio: Compile more " Philippe Mathieu-Daudé
2025-03-10 8:20 ` Eric Auger
2025-03-08 23:09 ` [PATCH v2 05/21] hw/vfio: Compile iommufd.c once Philippe Mathieu-Daudé
2025-03-10 8:23 ` Eric Auger
2025-03-08 23:09 ` [PATCH v2 06/21] system: Declare qemu_[min/max]rampagesize() in 'system/hostmem.h' Philippe Mathieu-Daudé
2025-03-10 8:28 ` Eric Auger
2025-03-08 23:09 ` [PATCH v2 07/21] hw/vfio: Compile display.c once Philippe Mathieu-Daudé
2025-03-10 8:29 ` Eric Auger
2025-03-08 23:09 ` [PATCH v2 08/21] system/kvm: Expose kvm_irqchip_[add, remove]_change_notifier() Philippe Mathieu-Daudé
2025-03-09 18:54 ` [PATCH v2 08/21] system/kvm: Expose kvm_irqchip_[add,remove]_change_notifier() Richard Henderson
2025-03-10 8:35 ` Eric Auger
2025-03-08 23:09 ` [PATCH v2 09/21] hw/vfio/pci: Convert CONFIG_KVM check to runtime one Philippe Mathieu-Daudé
2025-03-10 9:54 ` Eric Auger
2025-03-10 12:54 ` BALATON Zoltan
2025-03-10 14:53 ` Eric Auger
2025-03-11 8:54 ` Philippe Mathieu-Daudé
2025-03-08 23:09 ` [PATCH v2 10/21] qom: Introduce type_is_registered() Philippe Mathieu-Daudé
2025-03-09 19:14 ` Richard Henderson
2025-03-10 7:38 ` Cédric Le Goater
2025-03-10 9:54 ` Eric Auger
2025-03-08 23:09 ` [PATCH v2 11/21] hw/vfio/igd: Define TYPE_VFIO_PCI_IGD_LPC_BRIDGE Philippe Mathieu-Daudé
2025-03-10 7:38 ` Cédric Le Goater
2025-03-10 9:54 ` Eric Auger
2025-03-08 23:09 ` [PATCH v2 12/21] hw/vfio/igd: Check CONFIG_VFIO_IGD at runtime using vfio_igd_builtin() Philippe Mathieu-Daudé
2025-03-10 7:37 ` Cédric Le Goater
2025-03-10 13:43 ` Philippe Mathieu-Daudé
2025-03-10 13:51 ` Cédric Le Goater
2025-03-10 15:23 ` Philippe Mathieu-Daudé
2025-03-10 15:16 ` Tomita Moeko
2025-03-08 23:09 ` [PATCH v2 13/21] hw/vfio/igd: Compile once Philippe Mathieu-Daudé
2025-03-10 7:39 ` Cédric Le Goater
2025-03-10 7:52 ` Cédric Le Goater
2025-03-08 23:09 ` [PATCH v2 14/21] system/iommufd: Introduce iommufd_builtin() helper Philippe Mathieu-Daudé
2025-03-08 23:09 ` [PATCH v2 15/21] hw/vfio/pci: Check CONFIG_IOMMUFD at runtime using iommufd_builtin() Philippe Mathieu-Daudé
2025-03-10 4:11 ` Duan, Zhenzhong
2025-03-10 13:37 ` Philippe Mathieu-Daudé
2025-03-11 1:54 ` Duan, Zhenzhong
2025-03-11 7:20 ` Philippe Mathieu-Daudé
2025-03-08 23:09 ` [PATCH v2 16/21] hw/vfio/pci: Compile once Philippe Mathieu-Daudé
2025-03-08 23:09 ` Philippe Mathieu-Daudé [this message]
2025-03-08 23:09 ` [PATCH v2 18/21] hw/vfio/ccw: Check CONFIG_IOMMUFD at runtime using iommufd_builtin() Philippe Mathieu-Daudé
2025-03-08 23:09 ` [PATCH v2 19/21] hw/vfio/s390x: Compile AP and CCW once Philippe Mathieu-Daudé
2025-03-08 23:09 ` [PATCH v2 20/21] hw/vfio/platform: Check CONFIG_IOMMUFD at runtime using iommufd_builtin Philippe Mathieu-Daudé
2025-03-08 23:09 ` [PATCH v2 21/21] hw/vfio/platform: Compile once Philippe Mathieu-Daudé
2025-03-10 8:03 ` [PATCH v2 00/21] hw/vfio: Build various objects once Cédric Le Goater
2025-03-10 13:38 ` Philippe Mathieu-Daudé
2025-03-11 8:08 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250308230917.18907-18-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=akrowiak@linux.ibm.com \
--cc=alex.bennee@linaro.org \
--cc=alex.williamson@redhat.com \
--cc=berrange@redhat.com \
--cc=borntraeger@linux.ibm.com \
--cc=clg@redhat.com \
--cc=danielhb413@gmail.com \
--cc=david@redhat.com \
--cc=eduardo@habkost.net \
--cc=eric.auger@redhat.com \
--cc=farman@linux.ibm.com \
--cc=harshpb@linux.ibm.com \
--cc=iii@linux.ibm.com \
--cc=imammedo@redhat.com \
--cc=jjherne@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=mjrosato@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
--cc=tomitamoeko@gmail.com \
--cc=yi.l.liu@intel.com \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).