qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Yi Liu" <yi.l.liu@intel.com>,
	"Pierrick Bouvier" <pierrick.bouvier@linaro.org>,
	"Alex Williamson" <alex.williamson@redhat.com>,
	"Christian Borntraeger" <borntraeger@linux.ibm.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Tony Krowiak" <akrowiak@linux.ibm.com>,
	"Nicholas Piggin" <npiggin@gmail.com>,
	"Halil Pasic" <pasic@linux.ibm.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"David Hildenbrand" <david@redhat.com>,
	"Igor Mammedov" <imammedo@redhat.com>,
	"Matthew Rosato" <mjrosato@linux.ibm.com>,
	"Tomita Moeko" <tomitamoeko@gmail.com>,
	qemu-ppc@nongnu.org,
	"Daniel Henrique Barboza" <danielhb413@gmail.com>,
	"Eric Farman" <farman@linux.ibm.com>,
	"Eduardo Habkost" <eduardo@habkost.net>,
	"Peter Xu" <peterx@redhat.com>,
	kvm@vger.kernel.org, "Zhenzhong Duan" <zhenzhong.duan@intel.com>,
	qemu-s390x@nongnu.org, "Eric Auger" <eric.auger@redhat.com>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Harsh Prateek Bora" <harshpb@linux.ibm.com>,
	"Cédric Le Goater" <clg@redhat.com>,
	"Ilya Leoshkevich" <iii@linux.ibm.com>,
	"Jason Herne" <jjherne@linux.ibm.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH v2 08/21] system/kvm: Expose kvm_irqchip_[add, remove]_change_notifier()
Date: Sun,  9 Mar 2025 00:09:04 +0100	[thread overview]
Message-ID: <20250308230917.18907-9-philmd@linaro.org> (raw)
In-Reply-To: <20250308230917.18907-1-philmd@linaro.org>

Currently kvm_irqchip_add_irqfd_notifier() and
kvm_irqchip_remove_irqfd_notifier() are only declared on
target specific code. There is not particular reason to,
as their prototypes don't use anything target related.

Move their declaration with common prototypes, otherwise
the next commit would trigger:

  hw/vfio/pci.c: In function ‘vfio_realize’:
  hw/vfio/pci.c:3178:9: error: implicit declaration of function ‘kvm_irqchip_add_change_notifier’
   3178 |         kvm_irqchip_add_change_notifier(&vdev->irqchip_change_notifier);
        |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        |         kvm_irqchip_add_irqfd_notifier
  hw/vfio/pci.c:3236:9: error: implicit declaration of function ‘kvm_irqchip_remove_change_notifier’
   3236 |         kvm_irqchip_remove_change_notifier(&vdev->irqchip_change_notifier);
        |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        |         kvm_irqchip_remove_irqfd_notifier

Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 include/system/kvm.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/system/kvm.h b/include/system/kvm.h
index ab17c09a551..75673fb794e 100644
--- a/include/system/kvm.h
+++ b/include/system/kvm.h
@@ -412,10 +412,6 @@ int kvm_irqchip_send_msi(KVMState *s, MSIMessage msg);
 
 void kvm_irqchip_add_irq_route(KVMState *s, int gsi, int irqchip, int pin);
 
-void kvm_irqchip_add_change_notifier(Notifier *n);
-void kvm_irqchip_remove_change_notifier(Notifier *n);
-void kvm_irqchip_change_notify(void);
-
 struct kvm_guest_debug;
 struct kvm_debug_exit_arch;
 
@@ -517,6 +513,10 @@ void kvm_irqchip_release_virq(KVMState *s, int virq);
 void kvm_add_routing_entry(KVMState *s,
                            struct kvm_irq_routing_entry *entry);
 
+void kvm_irqchip_add_change_notifier(Notifier *n);
+void kvm_irqchip_remove_change_notifier(Notifier *n);
+void kvm_irqchip_change_notify(void);
+
 int kvm_irqchip_add_irqfd_notifier_gsi(KVMState *s, EventNotifier *n,
                                        EventNotifier *rn, int virq);
 int kvm_irqchip_remove_irqfd_notifier_gsi(KVMState *s, EventNotifier *n,
-- 
2.47.1



  parent reply	other threads:[~2025-03-08 23:10 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-08 23:08 [PATCH v2 00/21] hw/vfio: Build various objects once Philippe Mathieu-Daudé
2025-03-08 23:08 ` [PATCH v2 01/21] hw/vfio/common: Include missing 'system/tcg.h' header Philippe Mathieu-Daudé
2025-03-10  8:08   ` Eric Auger
2025-03-08 23:08 ` [PATCH v2 02/21] hw/vfio/spapr: Do not include <linux/kvm.h> Philippe Mathieu-Daudé
2025-03-10  8:08   ` Eric Auger
2025-03-08 23:08 ` [PATCH v2 03/21] hw/vfio: Compile some common objects once Philippe Mathieu-Daudé
2025-03-10  8:19   ` Eric Auger
2025-03-08 23:09 ` [PATCH v2 04/21] hw/vfio: Compile more " Philippe Mathieu-Daudé
2025-03-10  8:20   ` Eric Auger
2025-03-08 23:09 ` [PATCH v2 05/21] hw/vfio: Compile iommufd.c once Philippe Mathieu-Daudé
2025-03-10  8:23   ` Eric Auger
2025-03-08 23:09 ` [PATCH v2 06/21] system: Declare qemu_[min/max]rampagesize() in 'system/hostmem.h' Philippe Mathieu-Daudé
2025-03-10  8:28   ` Eric Auger
2025-03-08 23:09 ` [PATCH v2 07/21] hw/vfio: Compile display.c once Philippe Mathieu-Daudé
2025-03-10  8:29   ` Eric Auger
2025-03-08 23:09 ` Philippe Mathieu-Daudé [this message]
2025-03-09 18:54   ` [PATCH v2 08/21] system/kvm: Expose kvm_irqchip_[add,remove]_change_notifier() Richard Henderson
2025-03-10  8:35   ` Eric Auger
2025-03-08 23:09 ` [PATCH v2 09/21] hw/vfio/pci: Convert CONFIG_KVM check to runtime one Philippe Mathieu-Daudé
2025-03-10  9:54   ` Eric Auger
2025-03-10 12:54     ` BALATON Zoltan
2025-03-10 14:53       ` Eric Auger
2025-03-11  8:54       ` Philippe Mathieu-Daudé
2025-03-08 23:09 ` [PATCH v2 10/21] qom: Introduce type_is_registered() Philippe Mathieu-Daudé
2025-03-09 19:14   ` Richard Henderson
2025-03-10  7:38   ` Cédric Le Goater
2025-03-10  9:54   ` Eric Auger
2025-03-08 23:09 ` [PATCH v2 11/21] hw/vfio/igd: Define TYPE_VFIO_PCI_IGD_LPC_BRIDGE Philippe Mathieu-Daudé
2025-03-10  7:38   ` Cédric Le Goater
2025-03-10  9:54   ` Eric Auger
2025-03-08 23:09 ` [PATCH v2 12/21] hw/vfio/igd: Check CONFIG_VFIO_IGD at runtime using vfio_igd_builtin() Philippe Mathieu-Daudé
2025-03-10  7:37   ` Cédric Le Goater
2025-03-10 13:43     ` Philippe Mathieu-Daudé
2025-03-10 13:51       ` Cédric Le Goater
2025-03-10 15:23         ` Philippe Mathieu-Daudé
2025-03-10 15:16       ` Tomita Moeko
2025-03-08 23:09 ` [PATCH v2 13/21] hw/vfio/igd: Compile once Philippe Mathieu-Daudé
2025-03-10  7:39   ` Cédric Le Goater
2025-03-10  7:52   ` Cédric Le Goater
2025-03-08 23:09 ` [PATCH v2 14/21] system/iommufd: Introduce iommufd_builtin() helper Philippe Mathieu-Daudé
2025-03-08 23:09 ` [PATCH v2 15/21] hw/vfio/pci: Check CONFIG_IOMMUFD at runtime using iommufd_builtin() Philippe Mathieu-Daudé
2025-03-10  4:11   ` Duan, Zhenzhong
2025-03-10 13:37     ` Philippe Mathieu-Daudé
2025-03-11  1:54       ` Duan, Zhenzhong
2025-03-11  7:20         ` Philippe Mathieu-Daudé
2025-03-08 23:09 ` [PATCH v2 16/21] hw/vfio/pci: Compile once Philippe Mathieu-Daudé
2025-03-08 23:09 ` [PATCH v2 17/21] hw/vfio/ap: Check CONFIG_IOMMUFD at runtime using iommufd_builtin() Philippe Mathieu-Daudé
2025-03-08 23:09 ` [PATCH v2 18/21] hw/vfio/ccw: " Philippe Mathieu-Daudé
2025-03-08 23:09 ` [PATCH v2 19/21] hw/vfio/s390x: Compile AP and CCW once Philippe Mathieu-Daudé
2025-03-08 23:09 ` [PATCH v2 20/21] hw/vfio/platform: Check CONFIG_IOMMUFD at runtime using iommufd_builtin Philippe Mathieu-Daudé
2025-03-08 23:09 ` [PATCH v2 21/21] hw/vfio/platform: Compile once Philippe Mathieu-Daudé
2025-03-10  8:03 ` [PATCH v2 00/21] hw/vfio: Build various objects once Cédric Le Goater
2025-03-10 13:38   ` Philippe Mathieu-Daudé
2025-03-11  8:08 ` Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250308230917.18907-9-philmd@linaro.org \
    --to=philmd@linaro.org \
    --cc=akrowiak@linux.ibm.com \
    --cc=alex.bennee@linaro.org \
    --cc=alex.williamson@redhat.com \
    --cc=berrange@redhat.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=clg@redhat.com \
    --cc=danielhb413@gmail.com \
    --cc=david@redhat.com \
    --cc=eduardo@habkost.net \
    --cc=eric.auger@redhat.com \
    --cc=farman@linux.ibm.com \
    --cc=harshpb@linux.ibm.com \
    --cc=iii@linux.ibm.com \
    --cc=imammedo@redhat.com \
    --cc=jjherne@linux.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=mjrosato@linux.ibm.com \
    --cc=npiggin@gmail.com \
    --cc=pasic@linux.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=pierrick.bouvier@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=thuth@redhat.com \
    --cc=tomitamoeko@gmail.com \
    --cc=yi.l.liu@intel.com \
    --cc=zhenzhong.duan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).