From: "Anthony PERARD" <anthony.perard@vates.tech>
To: qemu-devel@nongnu.org
Cc: "Stefano Stabellini" <stefano.stabellini@amd.com>,
"Anthony PERARD" <anthony.perard@vates.tech>
Subject: [PULL 3/3] xen: No need to flush the mapcache for grants
Date: Mon, 10 Mar 2025 14:45:35 +0000 [thread overview]
Message-ID: <20250310144516.28828-4-anthony.perard@vates.tech> (raw)
In-Reply-To: <20250310144516.28828-1-anthony.perard@vates.tech>
From: Stefano Stabellini <stefano.stabellini@amd.com>
On IOREQ_TYPE_INVALIDATE we need to invalidate the mapcache for regular
mappings. Since recently we started reusing the mapcache also to keep
track of grants mappings. However, there is no need to remove grant
mappings on IOREQ_TYPE_INVALIDATE requests, we shouldn't do that. So
remove the function call.
Fixes: 9ecdd4bf08 (xen: mapcache: Add support for grant mappings)
Cc: qemu-stable@nongnu.org
Reported-by: Olaf Hering <olaf@aepfle.de>
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@amd.com>
Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>
Signed-off-by: Edgar E. Iglesias <edgar.iglesias@amd.com>
Reviewed-by: Anthony PERARD <anthony.perard@vates.tech>
Message-Id: <20250206194915.3357743-2-edgar.iglesias@gmail.com>
Signed-off-by: Anthony PERARD <anthony.perard@vates.tech>
---
hw/xen/xen-mapcache.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/xen/xen-mapcache.c b/hw/xen/xen-mapcache.c
index 00bfbcc6fb..698b5c53ed 100644
--- a/hw/xen/xen-mapcache.c
+++ b/hw/xen/xen-mapcache.c
@@ -700,7 +700,6 @@ void xen_invalidate_map_cache(void)
bdrv_drain_all();
xen_invalidate_map_cache_single(mapcache);
- xen_invalidate_map_cache_single(mapcache_grants);
}
static uint8_t *xen_replace_cache_entry_unlocked(MapCache *mc,
--
Anthony Perard | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
next prev parent reply other threads:[~2025-03-10 15:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-10 14:45 [PULL 0/3] xen queue 2025-03-10 Anthony PERARD
2025-03-10 14:45 ` [PULL 1/3] xen/passthrough: use gsi to map pirq when dom0 is PVH Anthony PERARD
2025-03-10 14:45 ` [PULL 2/3] hw/xen: Add "mode" parameter to xen-block devices Anthony PERARD
2025-03-10 14:45 ` Anthony PERARD [this message]
2025-03-11 5:04 ` [PULL 0/3] xen queue 2025-03-10 Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250310144516.28828-4-anthony.perard@vates.tech \
--to=anthony.perard@vates.tech \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).