From: Nicholas Piggin <npiggin@gmail.com>
To: Thomas Huth <thuth@redhat.com>
Cc: "Nicholas Piggin" <npiggin@gmail.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Daniel P. Berrangé" <berrange@redhat.com>,
qemu-devel@nongnu.org
Subject: [PATCH 0/3] tests/functional/asset: improve partial-download handling
Date: Wed, 12 Mar 2025 15:17:35 +1000 [thread overview]
Message-ID: <20250312051739.938441-1-npiggin@gmail.com> (raw)
Continuing discussion from
https://lore.kernel.org/qemu-devel/20250311131327.903329-1-npiggin@gmail.com/
I added a basic short-download detection, cleaned up download retry
failure, and added an AssetError class that can help us be a bit
smarter about what to do with failures. That's extended to treating
short downloads similarly to non-404 HTTP errors in that it won't
fail the precache step, just skip the asset.
I still think that no asset errors should cache precache to fail
including 404 and hash mismatch, but that they should be punted to
the individual test cases that use those assets. IMO they should cause
test failure rather than test skip, so it's more obvious. But that can
be topic for later discussion. For now, this basically does the right
thing with the NetBSD archive short download problem and treats it the
way we would treat a 503 (which it essentially is), and that gets us
past the CI failures in functional-system-debian and
functional-system-fedora that are hitting upstream testing now.
Thanks,
Nick
Nicholas Piggin (3):
tests/functional/asset: Fail assert fetch when retries are exceeded
tests/functional/asset: Verify downloaded size
tests/functional/asset: Add AssetError exception class
tests/functional/qemu_test/asset.py | 60 +++++++++++++++++++++--------
1 file changed, 45 insertions(+), 15 deletions(-)
--
2.47.1
next reply other threads:[~2025-03-12 5:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-12 5:17 Nicholas Piggin [this message]
2025-03-12 5:17 ` [PATCH 1/3] tests/functional/asset: Fail assert fetch when retries are exceeded Nicholas Piggin
2025-03-12 6:40 ` Thomas Huth
2025-03-12 8:13 ` Daniel P. Berrangé
2025-03-12 5:17 ` [PATCH 2/3] tests/functional/asset: Verify downloaded size Nicholas Piggin
2025-03-12 6:49 ` Thomas Huth
2025-03-12 5:17 ` [PATCH 3/3] tests/functional/asset: Add AssetError exception class Nicholas Piggin
2025-03-12 6:56 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250312051739.938441-1-npiggin@gmail.com \
--to=npiggin@gmail.com \
--cc=berrange@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).