qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kurz <groug@kaod.org>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Fabiano Rosas <farosas@suse.de>,
	Christian Schoenebeck <qemu_oss@crudebyte.com>,
	Greg Kurz <groug@kaod.org>, Laurent Vivier <lvivier@redhat.com>
Subject: [PATCH v3 0/6] 9pfs: Fix ftruncate-after-unlink
Date: Wed, 12 Mar 2025 16:29:26 +0100	[thread overview]
Message-ID: <20250312152933.383967-1-groug@kaod.org> (raw)

QEMU 9.2 already fixed the long standing limitation of failing fstat() on
unlinked files. This series does something similar for ftruncate().

The following program can be straced inside the guest with a shared fs in
passthrough mode over 9p2000.L.

int main(void)
{
	struct stat st;
	int fd = creat("./foo", 0000);

	ftruncate(fd, 100);
	unlink("./foo");
	ftruncate(fd, 1000);
}

Before :

creat("./foo", 000)                     = 3
ftruncate(3, 100)                       = -1 EACCES (Permission denied)
unlink("./foo")                         = 0
ftruncate(3, 1000)                      = -1 ENOENT (No such file or directory)

After :

creat("./foo", 000)                     = 3
ftruncate(3, 100)                       = 0
unlink("./foo")                         = 0
ftruncate(3, 1000)                      = 0

Cheers,

--
Greg

Christian Schoenebeck (1):
  tests/9p: add 'Tsetattr' request to test client

Greg Kurz (5):
  9pfs: local : Introduce local_fid_fd() helper
  9pfs: Don't use file descriptors in core code
  9pfs: Introduce ftruncate file op
  9pfs: Introduce futimens file op
  tests/9p: Test `Tsetattr` can truncate unlinked file

 fsdev/file-op-9p.h                    |  5 +++
 hw/9pfs/9p-local.c                    | 49 ++++++++++++++++++++-------
 hw/9pfs/9p-synth.c                    | 22 ++++++++++++
 hw/9pfs/9p-util.h                     |  1 +
 hw/9pfs/9p.c                          | 21 +++++++++---
 hw/9pfs/cofs.c                        | 37 ++++++++++++++++++++
 hw/9pfs/coth.h                        |  4 +++
 tests/qtest/libqos/virtio-9p-client.c | 49 +++++++++++++++++++++++++++
 tests/qtest/libqos/virtio-9p-client.h | 34 +++++++++++++++++++
 tests/qtest/virtio-9p-test.c          | 15 ++++++++
 10 files changed, 219 insertions(+), 18 deletions(-)

-- 
2.48.1



             reply	other threads:[~2025-03-12 15:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-12 15:29 Greg Kurz [this message]
2025-03-12 15:29 ` [PATCH v3 1/6] 9pfs: local : Introduce local_fid_fd() helper Greg Kurz
2025-03-12 15:29 ` [PATCH v3 2/6] 9pfs: Don't use file descriptors in core code Greg Kurz
2025-03-12 15:29 ` [PATCH v3 3/6] 9pfs: Introduce ftruncate file op Greg Kurz
2025-03-12 15:29 ` [PATCH v3 4/6] 9pfs: Introduce futimens " Greg Kurz
2025-03-12 15:29 ` [PATCH v3 5/6] tests/9p: add 'Tsetattr' request to test client Greg Kurz
2025-03-12 15:29 ` [PATCH v3 6/6] tests/9p: Test `Tsetattr` can truncate unlinked file Greg Kurz
2025-03-12 16:21   ` Christian Schoenebeck
2025-03-18 19:01 ` [PATCH v3 0/6] 9pfs: Fix ftruncate-after-unlink Christian Schoenebeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250312152933.383967-1-groug@kaod.org \
    --to=groug@kaod.org \
    --cc=farosas@suse.de \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu_oss@crudebyte.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).