From: Greg Kurz <groug@kaod.org>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Fabiano Rosas <farosas@suse.de>,
Christian Schoenebeck <qemu_oss@crudebyte.com>,
Greg Kurz <groug@kaod.org>, Laurent Vivier <lvivier@redhat.com>
Subject: [PATCH v3 1/6] 9pfs: local : Introduce local_fid_fd() helper
Date: Wed, 12 Mar 2025 16:29:27 +0100 [thread overview]
Message-ID: <20250312152933.383967-2-groug@kaod.org> (raw)
In-Reply-To: <20250312152933.383967-1-groug@kaod.org>
Factor out duplicated code to a single helper. More users to come.
Reviewed-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Signed-off-by: Greg Kurz <groug@kaod.org>
v2: - simplified local_fid_fd()
---
hw/9pfs/9p-local.c | 23 ++++++++++-------------
1 file changed, 10 insertions(+), 13 deletions(-)
diff --git a/hw/9pfs/9p-local.c b/hw/9pfs/9p-local.c
index 928523afcc6c..99b9560a528b 100644
--- a/hw/9pfs/9p-local.c
+++ b/hw/9pfs/9p-local.c
@@ -766,16 +766,19 @@ out:
return err;
}
-static int local_fstat(FsContext *fs_ctx, int fid_type,
- V9fsFidOpenState *fs, struct stat *stbuf)
+static int local_fid_fd(int fid_type, V9fsFidOpenState *fs)
{
- int err, fd;
-
if (fid_type == P9_FID_DIR) {
- fd = dirfd(fs->dir.stream);
+ return dirfd(fs->dir.stream);
} else {
- fd = fs->fd;
+ return fs->fd;
}
+}
+
+static int local_fstat(FsContext *fs_ctx, int fid_type,
+ V9fsFidOpenState *fs, struct stat *stbuf)
+{
+ int err, fd = local_fid_fd(fid_type, fs);
err = fstat(fd, stbuf);
if (err) {
@@ -1167,13 +1170,7 @@ out:
static int local_fsync(FsContext *ctx, int fid_type,
V9fsFidOpenState *fs, int datasync)
{
- int fd;
-
- if (fid_type == P9_FID_DIR) {
- fd = dirfd(fs->dir.stream);
- } else {
- fd = fs->fd;
- }
+ int fd = local_fid_fd(fid_type, fs);
if (datasync) {
return qemu_fdatasync(fd);
--
2.48.1
next prev parent reply other threads:[~2025-03-12 15:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-12 15:29 [PATCH v3 0/6] 9pfs: Fix ftruncate-after-unlink Greg Kurz
2025-03-12 15:29 ` Greg Kurz [this message]
2025-03-12 15:29 ` [PATCH v3 2/6] 9pfs: Don't use file descriptors in core code Greg Kurz
2025-03-12 15:29 ` [PATCH v3 3/6] 9pfs: Introduce ftruncate file op Greg Kurz
2025-03-12 15:29 ` [PATCH v3 4/6] 9pfs: Introduce futimens " Greg Kurz
2025-03-12 15:29 ` [PATCH v3 5/6] tests/9p: add 'Tsetattr' request to test client Greg Kurz
2025-03-12 15:29 ` [PATCH v3 6/6] tests/9p: Test `Tsetattr` can truncate unlinked file Greg Kurz
2025-03-12 16:21 ` Christian Schoenebeck
2025-03-18 19:01 ` [PATCH v3 0/6] 9pfs: Fix ftruncate-after-unlink Christian Schoenebeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250312152933.383967-2-groug@kaod.org \
--to=groug@kaod.org \
--cc=farosas@suse.de \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu_oss@crudebyte.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).