qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kurz <groug@kaod.org>
To: qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Fabiano Rosas <farosas@suse.de>,
	Christian Schoenebeck <qemu_oss@crudebyte.com>,
	Greg Kurz <groug@kaod.org>, Laurent Vivier <lvivier@redhat.com>
Subject: [PATCH v3 6/6] tests/9p: Test `Tsetattr` can truncate unlinked file
Date: Wed, 12 Mar 2025 16:29:32 +0100	[thread overview]
Message-ID: <20250312152933.383967-7-groug@kaod.org> (raw)
In-Reply-To: <20250312152933.383967-1-groug@kaod.org>

Enhance the `use-after-unlink` test with a new check for the
case where the client wants to alter the size of an unlinked
file for which it still has an active fid.

Suggested-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Signed-off-by: Greg Kurz <groug@kaod.org>

v3: - check the size of the truncated file
---
 tests/qtest/virtio-9p-test.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/tests/qtest/virtio-9p-test.c b/tests/qtest/virtio-9p-test.c
index f515a9bb157b..ac38ccf59513 100644
--- a/tests/qtest/virtio-9p-test.c
+++ b/tests/qtest/virtio-9p-test.c
@@ -736,6 +736,20 @@ static void fs_use_after_unlink(void *obj, void *data,
         .data = buf
     }).count;
     g_assert_cmpint(count, ==, write_count);
+
+    /* truncate file to (arbitrarily chosen) size 2001 */
+    tsetattr({
+        .client = v9p, .fid = fid_file, .attr = (v9fs_attr) {
+            .valid = P9_SETATTR_SIZE,
+            .size = 2001
+        }
+     });
+    /* truncate apparently succeeded, let's double-check the size */
+    tgetattr({
+        .client = v9p, .fid = fid_file, .request_mask = P9_GETATTR_BASIC,
+        .rgetattr.attr = &attr
+    });
+    g_assert_cmpint(attr.size, ==, 2001);
 }
 
 static void cleanup_9p_local_driver(void *data)
-- 
2.48.1



  parent reply	other threads:[~2025-03-12 15:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-12 15:29 [PATCH v3 0/6] 9pfs: Fix ftruncate-after-unlink Greg Kurz
2025-03-12 15:29 ` [PATCH v3 1/6] 9pfs: local : Introduce local_fid_fd() helper Greg Kurz
2025-03-12 15:29 ` [PATCH v3 2/6] 9pfs: Don't use file descriptors in core code Greg Kurz
2025-03-12 15:29 ` [PATCH v3 3/6] 9pfs: Introduce ftruncate file op Greg Kurz
2025-03-12 15:29 ` [PATCH v3 4/6] 9pfs: Introduce futimens " Greg Kurz
2025-03-12 15:29 ` [PATCH v3 5/6] tests/9p: add 'Tsetattr' request to test client Greg Kurz
2025-03-12 15:29 ` Greg Kurz [this message]
2025-03-12 16:21   ` [PATCH v3 6/6] tests/9p: Test `Tsetattr` can truncate unlinked file Christian Schoenebeck
2025-03-18 19:01 ` [PATCH v3 0/6] 9pfs: Fix ftruncate-after-unlink Christian Schoenebeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250312152933.383967-7-groug@kaod.org \
    --to=groug@kaod.org \
    --cc=farosas@suse.de \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu_oss@crudebyte.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).