* [PATCH v2] ppc/spapr: fix default cpu for pre-9.0 machines.
@ 2025-03-13 9:47 Harsh Prateek Bora
2025-03-13 10:22 ` Daniel P. Berrangé
2025-03-13 10:42 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: Harsh Prateek Bora @ 2025-03-13 9:47 UTC (permalink / raw)
To: qemu-devel, qemu-ppc; +Cc: npiggin, berrange, philmd
When POWER10 CPU was made as default, we missed keeping POWER9 as
default for older pseries releases (pre-9.0) at that time.
This caused breakge in default cpu evaluation for older pseries
machines and hence this fix.
Fixes: 51113013f3 ("ppc/spapr: change pseries machine default to POWER10 CPU")
Cc: qemu-stable@nongnu.org
Signed-off-by: Harsh Prateek Bora <harshpb@linux.ibm.com>
---
v2: addressed review comments from Philippe, Daniel
---
hw/ppc/spapr.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index c15340a58d..825afba4f4 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -4781,6 +4781,7 @@ static void spapr_machine_8_2_class_options(MachineClass *mc)
{
spapr_machine_9_0_class_options(mc);
compat_props_add(mc->compat_props, hw_compat_8_2, hw_compat_8_2_len);
+ mc->default_cpu_type = POWERPC_CPU_TYPE_NAME("power9_v2.2");
}
DEFINE_SPAPR_MACHINE(8, 2);
--
2.43.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] ppc/spapr: fix default cpu for pre-9.0 machines.
2025-03-13 9:47 [PATCH v2] ppc/spapr: fix default cpu for pre-9.0 machines Harsh Prateek Bora
@ 2025-03-13 10:22 ` Daniel P. Berrangé
2025-03-13 10:42 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Daniel P. Berrangé @ 2025-03-13 10:22 UTC (permalink / raw)
To: Harsh Prateek Bora; +Cc: qemu-devel, qemu-ppc, npiggin, philmd
On Thu, Mar 13, 2025 at 03:17:05PM +0530, Harsh Prateek Bora wrote:
> When POWER10 CPU was made as default, we missed keeping POWER9 as
> default for older pseries releases (pre-9.0) at that time.
> This caused breakge in default cpu evaluation for older pseries
> machines and hence this fix.
>
> Fixes: 51113013f3 ("ppc/spapr: change pseries machine default to POWER10 CPU")
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Harsh Prateek Bora <harshpb@linux.ibm.com>
> ---
> v2: addressed review comments from Philippe, Daniel
> ---
> hw/ppc/spapr.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] ppc/spapr: fix default cpu for pre-9.0 machines.
2025-03-13 9:47 [PATCH v2] ppc/spapr: fix default cpu for pre-9.0 machines Harsh Prateek Bora
2025-03-13 10:22 ` Daniel P. Berrangé
@ 2025-03-13 10:42 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-03-13 10:42 UTC (permalink / raw)
To: Harsh Prateek Bora, qemu-devel, qemu-ppc; +Cc: npiggin, berrange
On 13/3/25 10:47, Harsh Prateek Bora wrote:
> When POWER10 CPU was made as default, we missed keeping POWER9 as
> default for older pseries releases (pre-9.0) at that time.
> This caused breakge in default cpu evaluation for older pseries
> machines and hence this fix.
>
> Fixes: 51113013f3 ("ppc/spapr: change pseries machine default to POWER10 CPU")
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Harsh Prateek Bora <harshpb@linux.ibm.com>
> ---
> v2: addressed review comments from Philippe, Daniel
> ---
> hw/ppc/spapr.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index c15340a58d..825afba4f4 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -4781,6 +4781,7 @@ static void spapr_machine_8_2_class_options(MachineClass *mc)
> {
> spapr_machine_9_0_class_options(mc);
> compat_props_add(mc->compat_props, hw_compat_8_2, hw_compat_8_2_len);
> + mc->default_cpu_type = POWERPC_CPU_TYPE_NAME("power9_v2.2");
Ah, this makes more sense!
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> }
>
> DEFINE_SPAPR_MACHINE(8, 2);
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-13 10:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-13 9:47 [PATCH v2] ppc/spapr: fix default cpu for pre-9.0 machines Harsh Prateek Bora
2025-03-13 10:22 ` Daniel P. Berrangé
2025-03-13 10:42 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).