From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DE67AC35FF3 for ; Thu, 13 Mar 2025 16:44:49 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tslaf-0003NW-7d; Thu, 13 Mar 2025 12:39:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tslab-0003Kr-Oz for qemu-devel@nongnu.org; Thu, 13 Mar 2025 12:39:22 -0400 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tslaZ-0005cc-6i for qemu-devel@nongnu.org; Thu, 13 Mar 2025 12:39:21 -0400 Received: by mail-pj1-x1032.google.com with SMTP id 98e67ed59e1d1-2ff799d99dcso2532005a91.1 for ; Thu, 13 Mar 2025 09:39:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741883957; x=1742488757; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wT5ohu0Ui7xrH+jgYqMJMpKemGPcZNvy7jzdyuAyzEs=; b=I+btRbSOhbOMqUegHG4u04V1Ri+EsE9yosfXL59KyAcmvqz5ns7Nw5c7fpK8HxdZ5d Gu2gtgagPk+Cv9a4xbtxKAnhGae3Ei/R3tdjWgY4HZt94Nw0178ZXDJKLwkdCkxK30Pb xmRROKJ6uW3AvN6n2gJDwmwed5WdP/TsqCmbz/xEJX1sWBBPvD4m1aAGlYbukFShaEOG zboW8j3TSI4QmaA8qHSgV7ApEVrozRVxSzLGhqcJr1i35QDqYaPY83KgkJzsi89thGCD uLX6EGtga8f2yhfvTdHD8EM8awBCSWo5k5IdhPkIinZbj4RtEC4Gmm42HWWlwqiuWzZi 4tDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741883957; x=1742488757; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wT5ohu0Ui7xrH+jgYqMJMpKemGPcZNvy7jzdyuAyzEs=; b=Va/eIIIymFGeqXMHzDnHcFtwP26Wi7lnviqmlESAqDiFGSL8/vIT6GxBKyD4lGmMFY j7bG/zTXzJHqVKcHNvDHjUQuqF+JE7StDJX3aatoi1s8EqSHAWBh7PbSQ3c4+yCPMgUo X8QAzcACWDj/zI9xkJ7kDfcwFR5bP76HK/7RF6LyhQZu12nu7AMyh0E5hyveH/hN1BOc 7vo4tfmSTzzNR6rbGrE0rr6vFTw7YINrthq9byrS95/2JIgFBhdGok1MSnXQxrCrHecU zhGY1TQjKDKN8hvWcJGeW/es72m5v+rSp65Hm4/WmpNE+Rwu0hh5isATF87AE8WBahNm dcfw== X-Gm-Message-State: AOJu0YwGtGAh2eGqQAloZZHDPhkspYlmn4hc9ls4M8NBZc+0pwVH0hGx PQlfzqF9mdEnLJaow8XNdFXihZUnNBSTiosyVFROk+RHvNjRnn9KNVHfYpQVtV9olV3MlvtiqEq tFwg= X-Gm-Gg: ASbGnctAWaeMmsrwF+NZOy+4n6k39Uqf59Gy/0jhlFstsqub/IPv77tJ47Xm+XR63DH rbubMGqo3eLGrXvSeWmBUIAE+kL0aGAJrny8VFfzWg1PFg/irKWsPDFCkJUC8i51Wv8sFsdWiJg xAakWP/IS5BGK1wRhfHTDcSr4lCbMstO67Dj2EysaZNOTRNNIxnzEGk/mgExgJQ0lVXBriMiOgF s25QMWs+i/y1sOXeQD6LCmk+hixucT5bP8F9H4/lTbVVud+clG/UONbD8WNleZm38L/mQoCdGlN e5feuTyanqIrlaZu76YWPDmoegiR+irnWfqe6FHtLAxc X-Google-Smtp-Source: AGHT+IGT0TQa6IzxQKmV0c+iT9Ap/Go2mov47rFQ/lft0hbXJmOXflaiO0g7vmiNGPWVgJAiRn5xgQ== X-Received: by 2002:a17:90b:2710:b0:2ff:6fc3:79c3 with SMTP id 98e67ed59e1d1-3014e8435admr275040a91.9.1741883957269; Thu, 13 Mar 2025 09:39:17 -0700 (PDT) Received: from pc.. ([38.39.164.180]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-30119265938sm4020084a91.39.2025.03.13.09.39.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Mar 2025 09:39:16 -0700 (PDT) From: Pierrick Bouvier To: qemu-devel@nongnu.org Cc: Paul Durrant , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Harsh Prateek Bora , Liu Zhiwei , "Edgar E. Iglesias" , xen-devel@lists.xenproject.org, Peter Xu , alex.bennee@linaro.org, manos.pitsidianakis@linaro.org, Stefano Stabellini , Paolo Bonzini , qemu-ppc@nongnu.org, Richard Henderson , kvm@vger.kernel.org, David Hildenbrand , Palmer Dabbelt , Weiwei Li , qemu-riscv@nongnu.org, Alistair Francis , Anthony PERARD , Yoshinori Sato , Daniel Henrique Barboza , Nicholas Piggin , Pierrick Bouvier Subject: [PATCH v4 05/17] exec/memory.h: make devend_memop "target defines" agnostic Date: Thu, 13 Mar 2025 09:38:51 -0700 Message-Id: <20250313163903.1738581-6-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250313163903.1738581-1-pierrick.bouvier@linaro.org> References: <20250313163903.1738581-1-pierrick.bouvier@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::1032; envelope-from=pierrick.bouvier@linaro.org; helo=mail-pj1-x1032.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Will allow to make system/memory.c common later. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier --- include/exec/memory.h | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/include/exec/memory.h b/include/exec/memory.h index da21e9150b5..069021ac3ff 100644 --- a/include/exec/memory.h +++ b/include/exec/memory.h @@ -3138,25 +3138,17 @@ address_space_write_cached(MemoryRegionCache *cache, hwaddr addr, MemTxResult address_space_set(AddressSpace *as, hwaddr addr, uint8_t c, hwaddr len, MemTxAttrs attrs); -#ifdef COMPILING_PER_TARGET /* enum device_endian to MemOp. */ static inline MemOp devend_memop(enum device_endian end) { QEMU_BUILD_BUG_ON(DEVICE_HOST_ENDIAN != DEVICE_LITTLE_ENDIAN && DEVICE_HOST_ENDIAN != DEVICE_BIG_ENDIAN); -#if HOST_BIG_ENDIAN != TARGET_BIG_ENDIAN - /* Swap if non-host endianness or native (target) endianness */ - return (end == DEVICE_HOST_ENDIAN) ? 0 : MO_BSWAP; -#else - const int non_host_endianness = - DEVICE_LITTLE_ENDIAN ^ DEVICE_BIG_ENDIAN ^ DEVICE_HOST_ENDIAN; - - /* In this case, native (target) endianness needs no swap. */ - return (end == non_host_endianness) ? MO_BSWAP : 0; -#endif + bool big_endian = (end == DEVICE_NATIVE_ENDIAN + ? target_words_bigendian() + : end == DEVICE_BIG_ENDIAN); + return big_endian ? MO_BE : MO_LE; } -#endif /* COMPILING_PER_TARGET */ /* * Inhibit technologies that require discarding of pages in RAM blocks, e.g., -- 2.39.5