From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2AD84C282DE for ; Thu, 13 Mar 2025 19:25:57 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tso9z-0002nF-49; Thu, 13 Mar 2025 15:24:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tso9u-0002mN-Is; Thu, 13 Mar 2025 15:23:59 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tso9s-0000sY-IB; Thu, 13 Mar 2025 15:23:58 -0400 Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 52DGo4CD014085; Thu, 13 Mar 2025 19:23:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=pp1; bh=y1kX6VQJVWYuIJ0xxxrSTkMZ/55l df8TZ1IX5tGHtfc=; b=IJe7xQa1ZrRSLBeNaVllk/eWv70wsRWloNA1WIKfQ9XT g7clBwaWP1glaiSkWftow3LETpcP2oAkCg+gZfH0+dBqOlwT2KzPFh8FvYlZ6x33 DbvAUFKCrOosSCGvBzeIEHFMHiNe+oACjPw225VfKcuSxr738DdYS+YDDAU34/1e gT4ceE2mb5pi64K9g5Ku4IpsO02V/VRFxHsZXWPXAEahdP4Y3TZMw+cMU/sNEBCT cFFAxRkKWZC17mRW6oAc+vhh4n35iXNfuIdKNSp2ZghYrSTCSRRkMt88iMaSFolC PXMAMLN7FNtDGzj2XlajdbK89rOV4CaIyAgGhfxOMw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 45bhg0dwkj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 13 Mar 2025 19:23:54 +0000 (GMT) Received: from m0353725.ppops.net (m0353725.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 52DJNsvs012717; Thu, 13 Mar 2025 19:23:54 GMT Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 45bhg0dwkf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 13 Mar 2025 19:23:54 +0000 (GMT) Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 52DGBwId015361; Thu, 13 Mar 2025 19:23:53 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 45atspkfn6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 13 Mar 2025 19:23:53 +0000 Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 52DJNnZi22872554 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 13 Mar 2025 19:23:50 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C47D620043; Thu, 13 Mar 2025 19:23:49 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 81B3820040; Thu, 13 Mar 2025 19:23:47 +0000 (GMT) Received: from li-3c92a0cc-27cf-11b2-a85c-b804d9ca68fa.ibm.com (unknown [9.124.223.53]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 13 Mar 2025 19:23:47 +0000 (GMT) From: Aditya Gupta To: Cc: , Nicholas Piggin , Daniel Henrique Barboza , Harsh Prateek Bora , Sourabh Jain , Mahesh J Salgaonkar , Hari Bathini Subject: [PATCH v2 0/8] Implement Firmware Assisted Dump for PSeries Date: Fri, 14 Mar 2025 00:53:33 +0530 Message-ID: <20250313192341.132171-1-adityag@linux.ibm.com> X-Mailer: git-send-email 2.48.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: neVnzWxS-X61dQVwlXY13yr-dlEqQ5re X-Proofpoint-ORIG-GUID: BnZQvVqSRx_iNFJcgbM674x_fTyaCEue X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1093,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-13_08,2025-03-13_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 mlxlogscore=999 lowpriorityscore=0 spamscore=0 impostorscore=0 bulkscore=0 clxscore=1015 mlxscore=0 phishscore=0 adultscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2503130145 Received-SPF: pass client-ip=148.163.158.5; envelope-from=adityag@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Overview ========= Implemented Firmware Assisted Dump (fadump) on PSeries machine in QEMU. Fadump is an alternative dump mechanism to kdump, in which we the firmware does a memory preserving boot, and the second/crashkernel is booted fresh like a normal system reset, instead of the crashed kernel loading the second/crashkernel in case of kdump. This requires implementing the "ibm,configure-kernel-dump" RTAS call in QEMU. While booting with fadump=on, Linux will register fadump memory regions. Some memory regions like Real Mode Memory regions, and custom memory regions declared by OS basically require copying the requested memory range to a destination While other memory regions are populated by the firmware/platform (QEMU in this case), such as CPU State Data and HPTE. We pass the sizes for these data segment to the kernel as it needs to know how much memory to reserve (ibm,configure-kernel-dump-sizes). Then after a crash, once Linux does a OS terminate call, we trigger fadump if fadump was registered. Implementing the fadump boot as: * pause all vcpus (will save registers later) * preserve memory regions specified by fadump * do a memory preserving reboot (using GUEST_RESET as it doesn't clear the memory) And then we pass a metadata (firmware memory structure) as "ibm,kernel-dump" in the device tree, containing all details of the preserved memory regions to the kernel. Refer the Patch #7/8: "hw/ppc: Enable fadump for PSeries" for logs of a succesfful fadump crash Note: HPTE region has not been implemented. It's not planned as of now. Testing ======= Has been tested with following QEMU options: * firmware: x-vof and SLOF * tcg & kvm * l1 guest and l2 guest * with/without smp * cma/nocma * default crashkernel values (can fail with big initrd) and crashkernel=1G Git Tree for Testing ==================== https://github.com/adi-g15-ibm/qemu/tree/fadump-pseries-v2 Note: You will need a way to get the /proc/vmcore out of the VM for testing with crash-utility I use the following command line which sets up networking: "-net user,hostfwd=tcp::10022-:22 -net nic" And a rootfs with ssh support, then copy the /proc/vmcore with networking (can do compression using gzip before ssh, but compression might take lot of time if done inside the VM) Test vmcore for Testing with crash-utility ========================================== Can use vmlinux and vmcore available at https://github.com/adi-g15-ibm/qemu/releases/tag/test-images-fadump-pseries-v2 Above vmcore was generated with upstream qemu with these fadump patches applied, and in a KVM VM A limitation with above vmcore is it was a single CPU VM Changelog ========= v2: + rearrange code so that no unused functions get introduced in any patch + add functional test for pseries as suggested by nick + fix multiple issues pointed by harsh and nick + fix bug in cpu register saving where it was being stored in little-endian - removed 'is_next_boot_fadump' and used fadump header's status flag to store it + fixed multiple style issues (naming, unneeded diffs etc) Aditya Gupta (8): hw/ppc: Implement skeleton code for fadump in PSeries hw/ppc: Implement fadump register command hw/ppc: Trigger Fadump boot if fadump is registered hw/ppc: Preserve memory regions registered for fadump hw/ppc: Implement saving CPU state in Fadump hw/ppc: Pass dump-sizes property for fadump in device tree hw/ppc: Enable fadump for PSeries tests/functional: Add test for fadump in PSeries hw/ppc/meson.build | 1 + hw/ppc/spapr.c | 72 +++ hw/ppc/spapr_fadump.c | 679 ++++++++++++++++++++++ hw/ppc/spapr_rtas.c | 71 +++ include/hw/ppc/spapr.h | 11 +- include/hw/ppc/spapr_fadump.h | 121 ++++ tests/functional/meson.build | 2 + tests/functional/qemu_test/linuxkernel.py | 59 ++ tests/functional/test_ppc64_fadump.py | 185 ++++++ 9 files changed, 1200 insertions(+), 1 deletion(-) create mode 100644 hw/ppc/spapr_fadump.c create mode 100644 include/hw/ppc/spapr_fadump.h create mode 100755 tests/functional/test_ppc64_fadump.py -- 2.48.1