* Re: [PATCH] host/include/loongarch64: Fix inline assembly compatibility with Clang
2025-03-14 3:31 [PATCH] host/include/loongarch64: Fix inline assembly compatibility with Clang Yao Zi
@ 2025-03-14 20:32 ` Richard Henderson
2025-03-17 1:06 ` bibo mao
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Richard Henderson @ 2025-03-14 20:32 UTC (permalink / raw)
To: Yao Zi, qemu-devel; +Cc: Philippe Mathieu-Daudé
On 3/13/25 20:31, Yao Zi wrote:
> Clang on LoongArch only accepts fp register names in the dollar-prefixed
> form, while GCC allows omitting the dollar. Change registers in ASM
> clobbers to the dollar-prefixed form to make user emulators buildable
> with Clang on loongarch64. No functional change invovled.
>
> Signed-off-by: Yao Zi<ziyao@disroot.org>
> ---
> host/include/loongarch64/host/atomic128-ldst.h.inc | 4 ++--
> host/include/loongarch64/host/bufferiszero.c.inc | 6 ++++--
> host/include/loongarch64/host/load-extract-al16-al8.h.inc | 2 +-
> 3 files changed, 7 insertions(+), 5 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] host/include/loongarch64: Fix inline assembly compatibility with Clang
2025-03-14 3:31 [PATCH] host/include/loongarch64: Fix inline assembly compatibility with Clang Yao Zi
2025-03-14 20:32 ` Richard Henderson
@ 2025-03-17 1:06 ` bibo mao
2025-03-20 9:39 ` gaosong
2025-03-21 2:06 ` bibo mao
3 siblings, 0 replies; 5+ messages in thread
From: bibo mao @ 2025-03-17 1:06 UTC (permalink / raw)
To: Yao Zi, qemu-devel; +Cc: Richard Henderson, Philippe Mathieu-Daudé
Reviewed-by: Mao Bibo <maobibo@loongson.cn>
On 2025/3/14 上午11:31, Yao Zi wrote:
> Clang on LoongArch only accepts fp register names in the dollar-prefixed
> form, while GCC allows omitting the dollar. Change registers in ASM
> clobbers to the dollar-prefixed form to make user emulators buildable
> with Clang on loongarch64. No functional change invovled.
>
> Signed-off-by: Yao Zi <ziyao@disroot.org>
> ---
> host/include/loongarch64/host/atomic128-ldst.h.inc | 4 ++--
> host/include/loongarch64/host/bufferiszero.c.inc | 6 ++++--
> host/include/loongarch64/host/load-extract-al16-al8.h.inc | 2 +-
> 3 files changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/host/include/loongarch64/host/atomic128-ldst.h.inc b/host/include/loongarch64/host/atomic128-ldst.h.inc
> index 9a4a8f8b9e..754d2143f0 100644
> --- a/host/include/loongarch64/host/atomic128-ldst.h.inc
> +++ b/host/include/loongarch64/host/atomic128-ldst.h.inc
> @@ -28,7 +28,7 @@ static inline Int128 atomic16_read_ro(const Int128 *ptr)
> asm("vld $vr0, %2, 0\n\t"
> "vpickve2gr.d %0, $vr0, 0\n\t"
> "vpickve2gr.d %1, $vr0, 1"
> - : "=r"(l), "=r"(h) : "r"(ptr), "m"(*ptr) : "f0");
> + : "=r"(l), "=r"(h) : "r"(ptr), "m"(*ptr) : "$f0");
>
> return int128_make128(l, h);
> }
> @@ -46,7 +46,7 @@ static inline void atomic16_set(Int128 *ptr, Int128 val)
> asm("vinsgr2vr.d $vr0, %1, 0\n\t"
> "vinsgr2vr.d $vr0, %2, 1\n\t"
> "vst $vr0, %3, 0"
> - : "=m"(*ptr) : "r"(l), "r"(h), "r"(ptr) : "f0");
> + : "=m"(*ptr) : "r"(l), "r"(h), "r"(ptr) : "$f0");
> }
>
> #endif /* LOONGARCH_ATOMIC128_LDST_H */
> diff --git a/host/include/loongarch64/host/bufferiszero.c.inc b/host/include/loongarch64/host/bufferiszero.c.inc
> index 69891eac80..bb2598fdc3 100644
> --- a/host/include/loongarch64/host/bufferiszero.c.inc
> +++ b/host/include/loongarch64/host/bufferiszero.c.inc
> @@ -61,7 +61,8 @@ static bool buffer_is_zero_lsx(const void *buf, size_t len)
> "2:"
> : "=&r"(ret), "+r"(p)
> : "r"(buf), "r"(e), "r"(l)
> - : "f0", "f1", "f2", "f3", "f4", "f5", "f6", "f7", "f8", "fcc0");
> + : "$f0", "$f1", "$f2", "$f3", "$f4", "$f5", "$f6", "$f7", "$f8",
> + "$fcc0");
>
> return ret;
> }
> @@ -119,7 +120,8 @@ static bool buffer_is_zero_lasx(const void *buf, size_t len)
> "3:"
> : "=&r"(ret), "+r"(p)
> : "r"(buf), "r"(e), "r"(l)
> - : "f0", "f1", "f2", "f3", "f4", "f5", "f6", "f7", "f8", "fcc0");
> + : "$f0", "$f1", "$f2", "$f3", "$f4", "$f5", "$f6", "$f7", "$f8",
> + "$fcc0");
>
> return ret;
> }
> diff --git a/host/include/loongarch64/host/load-extract-al16-al8.h.inc b/host/include/loongarch64/host/load-extract-al16-al8.h.inc
> index d1fb59d8af..9528521e7d 100644
> --- a/host/include/loongarch64/host/load-extract-al16-al8.h.inc
> +++ b/host/include/loongarch64/host/load-extract-al16-al8.h.inc
> @@ -31,7 +31,7 @@ static inline uint64_t load_atom_extract_al16_or_al8(void *pv, int s)
> asm("vld $vr0, %2, 0\n\t"
> "vpickve2gr.d %0, $vr0, 0\n\t"
> "vpickve2gr.d %1, $vr0, 1"
> - : "=r"(l), "=r"(h) : "r"(ptr_align), "m"(*ptr_align) : "f0");
> + : "=r"(l), "=r"(h) : "r"(ptr_align), "m"(*ptr_align) : "$f0");
>
> return (l >> shr) | (h << (-shr & 63));
> }
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] host/include/loongarch64: Fix inline assembly compatibility with Clang
2025-03-14 3:31 [PATCH] host/include/loongarch64: Fix inline assembly compatibility with Clang Yao Zi
2025-03-14 20:32 ` Richard Henderson
2025-03-17 1:06 ` bibo mao
@ 2025-03-20 9:39 ` gaosong
2025-03-21 2:06 ` bibo mao
3 siblings, 0 replies; 5+ messages in thread
From: gaosong @ 2025-03-20 9:39 UTC (permalink / raw)
To: Yao Zi, qemu-devel, Thomas Huth
Cc: Richard Henderson, Philippe Mathieu-Daudé, qemu-stable,
Michael Tokarev, bibo mao
在 2025/3/14 上午11:31, Yao Zi 写道:
> Clang on LoongArch only accepts fp register names in the dollar-prefixed
> form, while GCC allows omitting the dollar. Change registers in ASM
> clobbers to the dollar-prefixed form to make user emulators buildable
> with Clang on loongarch64. No functional change invovled.
>
> Signed-off-by: Yao Zi <ziyao@disroot.org>
> ---
> host/include/loongarch64/host/atomic128-ldst.h.inc | 4 ++--
> host/include/loongarch64/host/bufferiszero.c.inc | 6 ++++--
> host/include/loongarch64/host/load-extract-al16-al8.h.inc | 2 +-
> 3 files changed, 7 insertions(+), 5 deletions(-)
Cc: qemu-stable@nongnu.org
resolves: https://gitlab.com/qemu-project/qemu/-/issues/2871
> diff --git a/host/include/loongarch64/host/atomic128-ldst.h.inc b/host/include/loongarch64/host/atomic128-ldst.h.inc
> index 9a4a8f8b9e..754d2143f0 100644
> --- a/host/include/loongarch64/host/atomic128-ldst.h.inc
> +++ b/host/include/loongarch64/host/atomic128-ldst.h.inc
> @@ -28,7 +28,7 @@ static inline Int128 atomic16_read_ro(const Int128 *ptr)
> asm("vld $vr0, %2, 0\n\t"
> "vpickve2gr.d %0, $vr0, 0\n\t"
> "vpickve2gr.d %1, $vr0, 1"
> - : "=r"(l), "=r"(h) : "r"(ptr), "m"(*ptr) : "f0");
> + : "=r"(l), "=r"(h) : "r"(ptr), "m"(*ptr) : "$f0");
>
> return int128_make128(l, h);
> }
> @@ -46,7 +46,7 @@ static inline void atomic16_set(Int128 *ptr, Int128 val)
> asm("vinsgr2vr.d $vr0, %1, 0\n\t"
> "vinsgr2vr.d $vr0, %2, 1\n\t"
> "vst $vr0, %3, 0"
> - : "=m"(*ptr) : "r"(l), "r"(h), "r"(ptr) : "f0");
> + : "=m"(*ptr) : "r"(l), "r"(h), "r"(ptr) : "$f0");
> }
>
> #endif /* LOONGARCH_ATOMIC128_LDST_H */
> diff --git a/host/include/loongarch64/host/bufferiszero.c.inc b/host/include/loongarch64/host/bufferiszero.c.inc
> index 69891eac80..bb2598fdc3 100644
> --- a/host/include/loongarch64/host/bufferiszero.c.inc
> +++ b/host/include/loongarch64/host/bufferiszero.c.inc
> @@ -61,7 +61,8 @@ static bool buffer_is_zero_lsx(const void *buf, size_t len)
> "2:"
> : "=&r"(ret), "+r"(p)
> : "r"(buf), "r"(e), "r"(l)
> - : "f0", "f1", "f2", "f3", "f4", "f5", "f6", "f7", "f8", "fcc0");
> + : "$f0", "$f1", "$f2", "$f3", "$f4", "$f5", "$f6", "$f7", "$f8",
> + "$fcc0");
>
> return ret;
> }
> @@ -119,7 +120,8 @@ static bool buffer_is_zero_lasx(const void *buf, size_t len)
> "3:"
> : "=&r"(ret), "+r"(p)
> : "r"(buf), "r"(e), "r"(l)
> - : "f0", "f1", "f2", "f3", "f4", "f5", "f6", "f7", "f8", "fcc0");
> + : "$f0", "$f1", "$f2", "$f3", "$f4", "$f5", "$f6", "$f7", "$f8",
> + "$fcc0");
>
> return ret;
> }
> diff --git a/host/include/loongarch64/host/load-extract-al16-al8.h.inc b/host/include/loongarch64/host/load-extract-al16-al8.h.inc
> index d1fb59d8af..9528521e7d 100644
> --- a/host/include/loongarch64/host/load-extract-al16-al8.h.inc
> +++ b/host/include/loongarch64/host/load-extract-al16-al8.h.inc
> @@ -31,7 +31,7 @@ static inline uint64_t load_atom_extract_al16_or_al8(void *pv, int s)
> asm("vld $vr0, %2, 0\n\t"
> "vpickve2gr.d %0, $vr0, 0\n\t"
> "vpickve2gr.d %1, $vr0, 1"
> - : "=r"(l), "=r"(h) : "r"(ptr_align), "m"(*ptr_align) : "f0");
> + : "=r"(l), "=r"(h) : "r"(ptr_align), "m"(*ptr_align) : "$f0");
>
> return (l >> shr) | (h << (-shr & 63));
> }
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] host/include/loongarch64: Fix inline assembly compatibility with Clang
2025-03-14 3:31 [PATCH] host/include/loongarch64: Fix inline assembly compatibility with Clang Yao Zi
` (2 preceding siblings ...)
2025-03-20 9:39 ` gaosong
@ 2025-03-21 2:06 ` bibo mao
3 siblings, 0 replies; 5+ messages in thread
From: bibo mao @ 2025-03-21 2:06 UTC (permalink / raw)
To: Yao Zi, qemu-devel; +Cc: Richard Henderson, Philippe Mathieu-Daudé
applied to loongarch-next.
Regards
Bibo Mao
On 2025/3/14 上午11:31, Yao Zi wrote:
> Clang on LoongArch only accepts fp register names in the dollar-prefixed
> form, while GCC allows omitting the dollar. Change registers in ASM
> clobbers to the dollar-prefixed form to make user emulators buildable
> with Clang on loongarch64. No functional change invovled.
>
> Signed-off-by: Yao Zi <ziyao@disroot.org>
> ---
> host/include/loongarch64/host/atomic128-ldst.h.inc | 4 ++--
> host/include/loongarch64/host/bufferiszero.c.inc | 6 ++++--
> host/include/loongarch64/host/load-extract-al16-al8.h.inc | 2 +-
> 3 files changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/host/include/loongarch64/host/atomic128-ldst.h.inc b/host/include/loongarch64/host/atomic128-ldst.h.inc
> index 9a4a8f8b9e..754d2143f0 100644
> --- a/host/include/loongarch64/host/atomic128-ldst.h.inc
> +++ b/host/include/loongarch64/host/atomic128-ldst.h.inc
> @@ -28,7 +28,7 @@ static inline Int128 atomic16_read_ro(const Int128 *ptr)
> asm("vld $vr0, %2, 0\n\t"
> "vpickve2gr.d %0, $vr0, 0\n\t"
> "vpickve2gr.d %1, $vr0, 1"
> - : "=r"(l), "=r"(h) : "r"(ptr), "m"(*ptr) : "f0");
> + : "=r"(l), "=r"(h) : "r"(ptr), "m"(*ptr) : "$f0");
>
> return int128_make128(l, h);
> }
> @@ -46,7 +46,7 @@ static inline void atomic16_set(Int128 *ptr, Int128 val)
> asm("vinsgr2vr.d $vr0, %1, 0\n\t"
> "vinsgr2vr.d $vr0, %2, 1\n\t"
> "vst $vr0, %3, 0"
> - : "=m"(*ptr) : "r"(l), "r"(h), "r"(ptr) : "f0");
> + : "=m"(*ptr) : "r"(l), "r"(h), "r"(ptr) : "$f0");
> }
>
> #endif /* LOONGARCH_ATOMIC128_LDST_H */
> diff --git a/host/include/loongarch64/host/bufferiszero.c.inc b/host/include/loongarch64/host/bufferiszero.c.inc
> index 69891eac80..bb2598fdc3 100644
> --- a/host/include/loongarch64/host/bufferiszero.c.inc
> +++ b/host/include/loongarch64/host/bufferiszero.c.inc
> @@ -61,7 +61,8 @@ static bool buffer_is_zero_lsx(const void *buf, size_t len)
> "2:"
> : "=&r"(ret), "+r"(p)
> : "r"(buf), "r"(e), "r"(l)
> - : "f0", "f1", "f2", "f3", "f4", "f5", "f6", "f7", "f8", "fcc0");
> + : "$f0", "$f1", "$f2", "$f3", "$f4", "$f5", "$f6", "$f7", "$f8",
> + "$fcc0");
>
> return ret;
> }
> @@ -119,7 +120,8 @@ static bool buffer_is_zero_lasx(const void *buf, size_t len)
> "3:"
> : "=&r"(ret), "+r"(p)
> : "r"(buf), "r"(e), "r"(l)
> - : "f0", "f1", "f2", "f3", "f4", "f5", "f6", "f7", "f8", "fcc0");
> + : "$f0", "$f1", "$f2", "$f3", "$f4", "$f5", "$f6", "$f7", "$f8",
> + "$fcc0");
>
> return ret;
> }
> diff --git a/host/include/loongarch64/host/load-extract-al16-al8.h.inc b/host/include/loongarch64/host/load-extract-al16-al8.h.inc
> index d1fb59d8af..9528521e7d 100644
> --- a/host/include/loongarch64/host/load-extract-al16-al8.h.inc
> +++ b/host/include/loongarch64/host/load-extract-al16-al8.h.inc
> @@ -31,7 +31,7 @@ static inline uint64_t load_atom_extract_al16_or_al8(void *pv, int s)
> asm("vld $vr0, %2, 0\n\t"
> "vpickve2gr.d %0, $vr0, 0\n\t"
> "vpickve2gr.d %1, $vr0, 1"
> - : "=r"(l), "=r"(h) : "r"(ptr_align), "m"(*ptr_align) : "f0");
> + : "=r"(l), "=r"(h) : "r"(ptr_align), "m"(*ptr_align) : "$f0");
>
> return (l >> shr) | (h << (-shr & 63));
> }
>
^ permalink raw reply [flat|nested] 5+ messages in thread