qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jonah Palmer <jonah.palmer@oracle.com>
To: qemu-devel@nongnu.org
Cc: eperezma@redhat.com, peterx@redhat.com, mst@redhat.com,
	jasowant@redhat.com, lvivier@redhat.com, dtatulea@nvidia.com,
	leiyan@redhat.com, parav@mellanox.com, sgarzare@redhat.com,
	si-wei.liu@oracle.com, lingshan.zhu@intel.com,
	boris.ostrovsky@oracle.com, jonah.palmer@oracle.com
Subject: [PATCH v3 3/7] vdpa: set backend capabilities at vhost_vdpa_init
Date: Fri, 14 Mar 2025 09:01:50 -0400	[thread overview]
Message-ID: <20250314130204.11380-4-jonah.palmer@oracle.com> (raw)
In-Reply-To: <20250314130204.11380-1-jonah.palmer@oracle.com>

From: Eugenio Pérez <eperezma@redhat.com>

The backend does not reset them until the vdpa file descriptor is closed
so there is no harm in doing it only once.

This allows the destination of a live migration to premap memory in
batches, using VHOST_BACKEND_F_IOTLB_BATCH.

Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
Signed-off-by: Jonah Palmer <jonah.palmer@oracle.com>
---
 hw/virtio/vhost-vdpa.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
index 79224d18d8..939a5a28a1 100644
--- a/hw/virtio/vhost-vdpa.c
+++ b/hw/virtio/vhost-vdpa.c
@@ -636,6 +636,12 @@ static int vhost_vdpa_init(struct vhost_dev *dev, void *opaque, Error **errp)
     v->dev = dev;
     dev->opaque =  opaque ;
     v->shared->listener = vhost_vdpa_memory_listener;
+
+    ret = vhost_vdpa_set_backend_cap(dev);
+    if (unlikely(ret != 0)) {
+        return ret;
+    }
+
     vhost_vdpa_init_svq(dev, v);
 
     error_propagate(&dev->migration_blocker, v->migration_blocker);
@@ -1565,7 +1571,6 @@ const VhostOps vdpa_ops = {
         .vhost_set_vring_kick = vhost_vdpa_set_vring_kick,
         .vhost_set_vring_call = vhost_vdpa_set_vring_call,
         .vhost_get_features = vhost_vdpa_get_features,
-        .vhost_set_backend_cap = vhost_vdpa_set_backend_cap,
         .vhost_set_owner = vhost_vdpa_set_owner,
         .vhost_set_vring_endian = NULL,
         .vhost_backend_memslots_limit = vhost_vdpa_memslots_limit,
-- 
2.43.5



  parent reply	other threads:[~2025-03-14 13:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-14 13:01 [PATCH v3 0/7] Move memory listener register to vhost_vdpa_init Jonah Palmer
2025-03-14 13:01 ` [PATCH v3 1/7] vdpa: check for iova tree initialized at net_client_start Jonah Palmer
2025-03-14 13:01 ` [PATCH v3 2/7] vdpa: reorder vhost_vdpa_set_backend_cap Jonah Palmer
2025-03-14 13:01 ` Jonah Palmer [this message]
2025-03-14 13:01 ` [PATCH v3 4/7] vdpa: add listener_registered Jonah Palmer
2025-03-14 13:01 ` [PATCH v3 5/7] vdpa: reorder listener assignment Jonah Palmer
2025-03-14 13:01 ` [PATCH v3 6/7] vdpa: move iova_tree allocation to net_vhost_vdpa_init Jonah Palmer
2025-03-14 13:01 ` [PATCH v3 7/7] vdpa: move memory listener register to vhost_vdpa_init Jonah Palmer
2025-03-18  1:53 ` [PATCH v3 0/7] Move " Lei Yang
2025-03-18  2:14   ` Jason Wang
2025-03-18 14:06     ` Lei Yang
2025-03-18 18:09       ` Dragos Tatulea
2025-03-19  0:14       ` Si-Wei Liu
2025-03-20 15:07         ` Lei Yang
2025-03-20 15:48           ` Dragos Tatulea
2025-03-21  6:45             ` Lei Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250314130204.11380-4-jonah.palmer@oracle.com \
    --to=jonah.palmer@oracle.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=dtatulea@nvidia.com \
    --cc=eperezma@redhat.com \
    --cc=jasowant@redhat.com \
    --cc=leiyan@redhat.com \
    --cc=lingshan.zhu@intel.com \
    --cc=lvivier@redhat.com \
    --cc=mst@redhat.com \
    --cc=parav@mellanox.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sgarzare@redhat.com \
    --cc=si-wei.liu@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).