From: Zhao Liu <zhao1.liu@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-rust@nongnu.org,
Zhao Liu <zhao1.liu@intel.com>
Subject: [PATCH v2 00/14] rust/vmstate: Clean up, fix, enhance & test
Date: Tue, 18 Mar 2025 16:32:34 +0800 [thread overview]
Message-ID: <20250318083248.1402990-1-zhao1.liu@intel.com> (raw)
Hi,
This series is in preparation for HPET migration support (in particular,
to support varray and vmstate_validate), and it also cleans up and fixes
the current vmstate.
Patch Summary
=============
Patch 1-9: Clean up & fix for vmstate_of & vmstate_struct, where the
issues are catched by unit tests.
Patch 10: Add vmstate_validate support, and vmstate_validate can accept
safe "test" callback.
Patch 11-14: Add unit test to cover as much as possible cases to be
compatible with C version macros.
* Note while in principle Rust's vmstate pattern doesn't
have to match the C version, the C vmstate macros are
rich enough to cover as much logic as possible. So
checking against the C version is the most effective way
to detect the error.
Change Log
==========
Changes since v1:
* Drop the patch about prefix separator ", " before [0 .. num] in
vmstate macros.
* Drop the pacth which changed "vmsd" to "ident" type in macros.
* Drop the pacth about adding "version" argument.
* Add a `with_exist_check()` method to help add callback in future.
* Drop addr_of & public VMStateFlags API in unit test.
* Clean up TODO comment.
Best Regards,
Zhao
---
Zhao Liu (14):
rust/vmstate: Remove unnecessary unsafe
rust/vmstate: Fix num_offset in vmstate macros
rust/vmstate: Fix num field when varray flags are set
rust/vmstate: Fix size field of VMStateField with VMS_ARRAY_OF_POINTER
flag
rust/vmstate: Fix type check for varray in vmstate_struct
rust/vmstate: Fix "cannot infer type" error in vmstate_struct
rust/vmstate: Fix unnecessary VMState bound of with_varray_flag()
rust/vmstate: Relax array check when build varray in vmstate_struct
rust/vmstate: Re-implement VMState trait for timer binding
rust/vmstate: Support vmstate_validate
rust/vmstate: Add unit test for vmstate_of macro
rust/vmstate: Add unit test for vmstate_{of|struct} macro
rust/vmstate: Add unit test for pointer case
rust/vmstate: Add unit test for vmstate_validate
rust/qemu-api/meson.build | 5 +-
rust/qemu-api/src/assertions.rs | 15 +
rust/qemu-api/src/vmstate.rs | 115 +++++--
rust/qemu-api/tests/tests.rs | 2 +
rust/qemu-api/tests/vmstate_tests.rs | 447 +++++++++++++++++++++++++++
5 files changed, 564 insertions(+), 20 deletions(-)
create mode 100644 rust/qemu-api/tests/vmstate_tests.rs
--
2.34.1
next reply other threads:[~2025-03-18 8:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-18 8:32 Zhao Liu [this message]
2025-03-18 8:32 ` [PATCH v2 01/14] rust/vmstate: Remove unnecessary unsafe Zhao Liu
2025-03-18 8:32 ` [PATCH v2 02/14] rust/vmstate: Fix num_offset in vmstate macros Zhao Liu
2025-03-18 8:32 ` [PATCH v2 03/14] rust/vmstate: Fix num field when varray flags are set Zhao Liu
2025-03-18 8:32 ` [PATCH v2 04/14] rust/vmstate: Fix size field of VMStateField with VMS_ARRAY_OF_POINTER flag Zhao Liu
2025-03-18 8:32 ` [PATCH v2 05/14] rust/vmstate: Fix type check for varray in vmstate_struct Zhao Liu
2025-03-18 8:32 ` [PATCH v2 06/14] rust/vmstate: Fix "cannot infer type" error " Zhao Liu
2025-03-18 8:32 ` [PATCH v2 07/14] rust/vmstate: Fix unnecessary VMState bound of with_varray_flag() Zhao Liu
2025-03-18 8:32 ` [PATCH v2 08/14] rust/vmstate: Relax array check when build varray in vmstate_struct Zhao Liu
2025-03-18 8:32 ` [PATCH v2 09/14] rust/vmstate: Re-implement VMState trait for timer binding Zhao Liu
2025-03-18 8:32 ` [PATCH v2 10/14] rust/vmstate: Support vmstate_validate Zhao Liu
2025-03-18 10:11 ` Paolo Bonzini
2025-03-18 12:23 ` Zhao Liu
2025-03-18 12:32 ` Paolo Bonzini
2025-03-18 13:07 ` Zhao Liu
2025-03-18 8:32 ` [PATCH v2 11/14] rust/vmstate: Add unit test for vmstate_of macro Zhao Liu
2025-03-18 8:32 ` [PATCH v2 12/14] rust/vmstate: Add unit test for vmstate_{of|struct} macro Zhao Liu
2025-03-18 8:32 ` [PATCH v2 13/14] rust/vmstate: Add unit test for pointer case Zhao Liu
2025-03-18 8:32 ` [PATCH v2 14/14] rust/vmstate: Add unit test for vmstate_validate Zhao Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250318083248.1402990-1-zhao1.liu@intel.com \
--to=zhao1.liu@intel.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-rust@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).