qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Zhao Liu <zhao1.liu@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-rust@nongnu.org,
	Zhao Liu <zhao1.liu@intel.com>
Subject: [PATCH v2 09/14] rust/vmstate: Re-implement VMState trait for timer binding
Date: Tue, 18 Mar 2025 16:32:43 +0800	[thread overview]
Message-ID: <20250318083248.1402990-10-zhao1.liu@intel.com> (raw)
In-Reply-To: <20250318083248.1402990-1-zhao1.liu@intel.com>

At present, Rust side has a timer binding "timer::Timer", so the vmstate
for timer should base on that binding instead of the raw
"binding::QEMUTimer".

It's possible to apply impl_vmstate_transparent for cell::Opaque and
then impl_vmstate_forward for timer::Timer. But binding::QEMUTimer
shouldn't be used directly, so that vmstate for such raw timer type is
useless.

Thus, apply impl_vmstate_scalar for timer::Timer. And since Opaque<> is
useful, apply impl_vmstate_transparent for cell::Opaque as well.

Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
---
 rust/qemu-api/src/vmstate.rs | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/rust/qemu-api/src/vmstate.rs b/rust/qemu-api/src/vmstate.rs
index 0b5af1c90b11..01f06ed7379e 100644
--- a/rust/qemu-api/src/vmstate.rs
+++ b/rust/qemu-api/src/vmstate.rs
@@ -27,12 +27,7 @@
 use core::{marker::PhantomData, mem, ptr::NonNull};
 
 pub use crate::bindings::{VMStateDescription, VMStateField};
-use crate::{
-    bindings::{self, VMStateFlags},
-    prelude::*,
-    qom::Owned,
-    zeroable::Zeroable,
-};
+use crate::{bindings::VMStateFlags, prelude::*, qom::Owned, zeroable::Zeroable};
 
 /// This macro is used to call a function with a generic argument bound
 /// to the type of a field.  The function must take a
@@ -344,6 +339,7 @@ unsafe impl<$base> VMState for $type where $base: VMState $($where)* {
 impl_vmstate_transparent!(std::pin::Pin<T> where T: VMState);
 impl_vmstate_transparent!(crate::cell::BqlCell<T> where T: VMState);
 impl_vmstate_transparent!(crate::cell::BqlRefCell<T> where T: VMState);
+impl_vmstate_transparent!(crate::cell::Opaque<T> where T: VMState);
 
 #[macro_export]
 macro_rules! impl_vmstate_bitsized {
@@ -390,7 +386,7 @@ unsafe impl VMState for $type {
 impl_vmstate_scalar!(vmstate_info_uint16, u16, VMS_VARRAY_UINT16);
 impl_vmstate_scalar!(vmstate_info_uint32, u32, VMS_VARRAY_UINT32);
 impl_vmstate_scalar!(vmstate_info_uint64, u64);
-impl_vmstate_scalar!(vmstate_info_timer, bindings::QEMUTimer);
+impl_vmstate_scalar!(vmstate_info_timer, crate::timer::Timer);
 
 // Pointer types using the underlying type's VMState plus VMS_POINTER
 // Note that references are not supported, though references to cells
-- 
2.34.1



  parent reply	other threads:[~2025-03-18  8:16 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-18  8:32 [PATCH v2 00/14] rust/vmstate: Clean up, fix, enhance & test Zhao Liu
2025-03-18  8:32 ` [PATCH v2 01/14] rust/vmstate: Remove unnecessary unsafe Zhao Liu
2025-03-18  8:32 ` [PATCH v2 02/14] rust/vmstate: Fix num_offset in vmstate macros Zhao Liu
2025-03-18  8:32 ` [PATCH v2 03/14] rust/vmstate: Fix num field when varray flags are set Zhao Liu
2025-03-18  8:32 ` [PATCH v2 04/14] rust/vmstate: Fix size field of VMStateField with VMS_ARRAY_OF_POINTER flag Zhao Liu
2025-03-18  8:32 ` [PATCH v2 05/14] rust/vmstate: Fix type check for varray in vmstate_struct Zhao Liu
2025-03-18  8:32 ` [PATCH v2 06/14] rust/vmstate: Fix "cannot infer type" error " Zhao Liu
2025-03-18  8:32 ` [PATCH v2 07/14] rust/vmstate: Fix unnecessary VMState bound of with_varray_flag() Zhao Liu
2025-03-18  8:32 ` [PATCH v2 08/14] rust/vmstate: Relax array check when build varray in vmstate_struct Zhao Liu
2025-03-18  8:32 ` Zhao Liu [this message]
2025-03-18  8:32 ` [PATCH v2 10/14] rust/vmstate: Support vmstate_validate Zhao Liu
2025-03-18 10:11   ` Paolo Bonzini
2025-03-18 12:23     ` Zhao Liu
2025-03-18 12:32       ` Paolo Bonzini
2025-03-18 13:07         ` Zhao Liu
2025-03-18  8:32 ` [PATCH v2 11/14] rust/vmstate: Add unit test for vmstate_of macro Zhao Liu
2025-03-18  8:32 ` [PATCH v2 12/14] rust/vmstate: Add unit test for vmstate_{of|struct} macro Zhao Liu
2025-03-18  8:32 ` [PATCH v2 13/14] rust/vmstate: Add unit test for pointer case Zhao Liu
2025-03-18  8:32 ` [PATCH v2 14/14] rust/vmstate: Add unit test for vmstate_validate Zhao Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250318083248.1402990-10-zhao1.liu@intel.com \
    --to=zhao1.liu@intel.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-rust@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).