From: Zhao Liu <zhao1.liu@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-rust@nongnu.org,
Zhao Liu <zhao1.liu@intel.com>
Subject: [PATCH v2 07/14] rust/vmstate: Fix unnecessary VMState bound of with_varray_flag()
Date: Tue, 18 Mar 2025 16:32:41 +0800 [thread overview]
Message-ID: <20250318083248.1402990-8-zhao1.liu@intel.com> (raw)
In-Reply-To: <20250318083248.1402990-1-zhao1.liu@intel.com>
The VMState type bound is not used in with_varray_flag().
And for vmstate_struct, Rust cannot infer the type of `num` from the
call_func_with_field(), so this causes the compiling error because it
complains "cannot satisfy `_: VMState`" in with_varray_flag().
Note Rust can infer the type in vmstate_of macro so that
with_varray_flag() can work at there. It is possible that the different
initialization ways in the two macros cause differences in Rust's
type inference.
But in fact, the VMState type bound is not used in with_varray_flag()
and vmstate_varray_flag() has already checked the VMState type, it's
safe to drop VMState bound of with_varray_flag(), which can fix the
above compiling error.
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
---
rust/qemu-api/src/vmstate.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/rust/qemu-api/src/vmstate.rs b/rust/qemu-api/src/vmstate.rs
index 3be3a7260fe9..792a74fdfc08 100644
--- a/rust/qemu-api/src/vmstate.rs
+++ b/rust/qemu-api/src/vmstate.rs
@@ -275,7 +275,7 @@ pub const fn with_pointer_flag(mut self) -> Self {
}
#[must_use]
- pub const fn with_varray_flag<T: VMState>(mut self, flag: VMStateFlags) -> VMStateField {
+ pub const fn with_varray_flag(mut self, flag: VMStateFlags) -> VMStateField {
assert!((self.flags.0 & VMStateFlags::VMS_ARRAY.0) != 0);
self.flags = VMStateFlags(self.flags.0 & !VMStateFlags::VMS_ARRAY.0);
self.flags = VMStateFlags(self.flags.0 | flag.0);
--
2.34.1
next prev parent reply other threads:[~2025-03-18 8:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-18 8:32 [PATCH v2 00/14] rust/vmstate: Clean up, fix, enhance & test Zhao Liu
2025-03-18 8:32 ` [PATCH v2 01/14] rust/vmstate: Remove unnecessary unsafe Zhao Liu
2025-03-18 8:32 ` [PATCH v2 02/14] rust/vmstate: Fix num_offset in vmstate macros Zhao Liu
2025-03-18 8:32 ` [PATCH v2 03/14] rust/vmstate: Fix num field when varray flags are set Zhao Liu
2025-03-18 8:32 ` [PATCH v2 04/14] rust/vmstate: Fix size field of VMStateField with VMS_ARRAY_OF_POINTER flag Zhao Liu
2025-03-18 8:32 ` [PATCH v2 05/14] rust/vmstate: Fix type check for varray in vmstate_struct Zhao Liu
2025-03-18 8:32 ` [PATCH v2 06/14] rust/vmstate: Fix "cannot infer type" error " Zhao Liu
2025-03-18 8:32 ` Zhao Liu [this message]
2025-03-18 8:32 ` [PATCH v2 08/14] rust/vmstate: Relax array check when build varray " Zhao Liu
2025-03-18 8:32 ` [PATCH v2 09/14] rust/vmstate: Re-implement VMState trait for timer binding Zhao Liu
2025-03-18 8:32 ` [PATCH v2 10/14] rust/vmstate: Support vmstate_validate Zhao Liu
2025-03-18 10:11 ` Paolo Bonzini
2025-03-18 12:23 ` Zhao Liu
2025-03-18 12:32 ` Paolo Bonzini
2025-03-18 13:07 ` Zhao Liu
2025-03-18 8:32 ` [PATCH v2 11/14] rust/vmstate: Add unit test for vmstate_of macro Zhao Liu
2025-03-18 8:32 ` [PATCH v2 12/14] rust/vmstate: Add unit test for vmstate_{of|struct} macro Zhao Liu
2025-03-18 8:32 ` [PATCH v2 13/14] rust/vmstate: Add unit test for pointer case Zhao Liu
2025-03-18 8:32 ` [PATCH v2 14/14] rust/vmstate: Add unit test for vmstate_validate Zhao Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250318083248.1402990-8-zhao1.liu@intel.com \
--to=zhao1.liu@intel.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-rust@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).