From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Stefan Hajnoczi" <stefanha@redhat.com>,
"Matheus Tavares Bernardino" <quic_mathbern@quicinc.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Fabiano Rosas" <farosas@suse.de>
Subject: [PULL 8/8] tests/functional/test_migration: Use "ncat" instead of "nc" in the exec test
Date: Wed, 19 Mar 2025 14:18:51 +0100 [thread overview]
Message-ID: <20250319131851.148817-9-thuth@redhat.com> (raw)
In-Reply-To: <20250319131851.148817-1-thuth@redhat.com>
From: Thomas Huth <thuth@redhat.com>
"nc" can either be GNU netcat, OpenBSD netcat or NMap ncat. At
least GNU netcat currently does not work with this test anymore,
though the comment in the test says otherwise. GNU netcat seems
to be quite unmaintained nowadays, according to its website
(https://netcat.sourceforge.net/), the last public release is from
2004, so we should rather avoid that binary.
In our CI, we are only using "ncat" in the containers (it's the only
flavor that lcitool supports), thus to avoid silent regressions with
the other netcats, let's limit this test to "ncat" only now.
Reported-by: Matheus Tavares Bernardino <quic_mathbern@quicinc.com>
Message-ID: <20250319105617.133191-1-thuth@redhat.com>
Reviewed-by: Matheus Tavares Bernardino <quic_mathbern@quicinc.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Acked-by: Fabiano Rosas <farosas@suse.de>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/functional/test_migration.py | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/tests/functional/test_migration.py b/tests/functional/test_migration.py
index 44804113cfe..181223a69e3 100755
--- a/tests/functional/test_migration.py
+++ b/tests/functional/test_migration.py
@@ -87,13 +87,12 @@ def test_migration_with_unix(self):
dest_uri = 'unix:%s/qemu-test.sock' % socket_path
self.do_migrate(dest_uri)
- @skipIfMissingCommands('nc')
+ @skipIfMissingCommands('ncat')
def test_migration_with_exec(self):
- """The test works for both netcat-traditional and netcat-openbsd packages."""
with Ports() as ports:
free_port = self._get_free_port(ports)
- dest_uri = 'exec:nc -l localhost %u' % free_port
- src_uri = 'exec:nc localhost %u' % free_port
+ dest_uri = 'exec:ncat -l localhost %u' % free_port
+ src_uri = 'exec:ncat localhost %u' % free_port
self.do_migrate(dest_uri, src_uri)
if __name__ == '__main__':
--
2.48.1
prev parent reply other threads:[~2025-03-19 13:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-19 13:18 [PULL 0/8] Functional and s390x patches for v10.0-rc1 Thomas Huth
2025-03-19 13:18 ` [PULL 1/8] hw/virtio: Also include md stubs in case CONFIG_VIRTIO_PCI is not set Thomas Huth
2025-03-19 13:18 ` [PULL 2/8] tests/functional/test_arm_orangepi: rename test class to 'OrangePiMachine' Thomas Huth
2025-03-19 13:18 ` [PULL 3/8] tests/functional: remove all class level fields Thomas Huth
2025-03-19 13:18 ` [PULL 4/8] docs/system: Use the meson binary from the pyvenv Thomas Huth
2025-03-19 13:18 ` [PULL 5/8] docs/system/arm: Use "functional tests" instead of "integration tests" Thomas Huth
2025-03-19 13:18 ` [PULL 6/8] docs/devel/testing/functional: Add a section about logging Thomas Huth
2025-03-19 13:18 ` [PULL 7/8] tests/functional/test_x86_64_kvm_xen: Remove avocado tags Thomas Huth
2025-03-19 13:18 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250319131851.148817-9-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=farosas@suse.de \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quic_mathbern@quicinc.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).