qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] target/hppa: Remove duplicated CPU_RESOLVING_TYPE definition
@ 2025-03-21 18:42 Philippe Mathieu-Daudé
  2025-03-23 19:14 ` Richard Henderson
  0 siblings, 1 reply; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-03-21 18:42 UTC (permalink / raw)
  To: qemu-devel; +Cc: Richard Henderson, Helge Deller, Philippe Mathieu-Daudé

The CPU_RESOLVING_TYPE definition was added in commit
0dacec874fa ("cpu: add CPU_RESOLVING_TYPE macro"), but
then added again in commit d3ae32d4d20. Remove the
duplication.

Fixes: d3ae32d4d20 ("target/hppa: Implement cpu_list")
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 target/hppa/cpu.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/target/hppa/cpu.h b/target/hppa/cpu.h
index 7be4a1d3800..8b36642b591 100644
--- a/target/hppa/cpu.h
+++ b/target/hppa/cpu.h
@@ -391,6 +391,4 @@ void hppa_cpu_alarm_timer(void *);
 #endif
 G_NORETURN void hppa_dynamic_excp(CPUHPPAState *env, int excp, uintptr_t ra);
 
-#define CPU_RESOLVING_TYPE TYPE_HPPA_CPU
-
 #endif /* HPPA_CPU_H */
-- 
2.47.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] target/hppa: Remove duplicated CPU_RESOLVING_TYPE definition
  2025-03-21 18:42 [PATCH] target/hppa: Remove duplicated CPU_RESOLVING_TYPE definition Philippe Mathieu-Daudé
@ 2025-03-23 19:14 ` Richard Henderson
  0 siblings, 0 replies; 2+ messages in thread
From: Richard Henderson @ 2025-03-23 19:14 UTC (permalink / raw)
  To: Philippe Mathieu-Daudé, qemu-devel; +Cc: Helge Deller

On 3/21/25 11:42, Philippe Mathieu-Daudé wrote:
> The CPU_RESOLVING_TYPE definition was added in commit
> 0dacec874fa ("cpu: add CPU_RESOLVING_TYPE macro"), but
> then added again in commit d3ae32d4d20. Remove the
> duplication.
> 
> Fixes: d3ae32d4d20 ("target/hppa: Implement cpu_list")
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   target/hppa/cpu.h | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/target/hppa/cpu.h b/target/hppa/cpu.h
> index 7be4a1d3800..8b36642b591 100644
> --- a/target/hppa/cpu.h
> +++ b/target/hppa/cpu.h
> @@ -391,6 +391,4 @@ void hppa_cpu_alarm_timer(void *);
>   #endif
>   G_NORETURN void hppa_dynamic_excp(CPUHPPAState *env, int excp, uintptr_t ra);
>   
> -#define CPU_RESOLVING_TYPE TYPE_HPPA_CPU
> -
>   #endif /* HPPA_CPU_H */

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-03-23 19:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-21 18:42 [PATCH] target/hppa: Remove duplicated CPU_RESOLVING_TYPE definition Philippe Mathieu-Daudé
2025-03-23 19:14 ` Richard Henderson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).