From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org,
"Pierrick Bouvier" <pierrick.bouvier@linaro.org>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH-for-10.1 12/13] hw/arm/realview: Replace arm_feature() -> arm_cpu_has_feature()
Date: Thu, 3 Apr 2025 00:23:32 +0200 [thread overview]
Message-ID: <20250402222334.66511-13-philmd@linaro.org> (raw)
In-Reply-To: <20250402222334.66511-1-philmd@linaro.org>
By using arm_cpu_has_feature() instead of arm_feature()
we don't need to include "cpu.h" anymore.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/arm/realview.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/hw/arm/realview.c b/hw/arm/realview.c
index f81d084eb80..48cfe05add0 100644
--- a/hw/arm/realview.c
+++ b/hw/arm/realview.c
@@ -9,7 +9,6 @@
#include "qemu/osdep.h"
#include "qapi/error.h"
-#include "cpu.h"
#include "hw/sysbus.h"
#include "hw/arm/boot.h"
#include "hw/arm/primecell.h"
@@ -31,6 +30,7 @@
#include "hw/sd/sd.h"
#include "audio/audio.h"
#include "target/arm/cpu-qom.h"
+#include "target/arm/cpu_has_feature.h"
#define SMP_BOOT_ADDR 0xe0000000
#define SMP_BOOTREG_ADDR 0x10000030
@@ -77,7 +77,6 @@ static void realview_init(MachineState *machine,
enum realview_board_type board_type)
{
ARMCPU *cpu = NULL;
- CPUARMState *env;
MemoryRegion *sysmem = get_system_memory();
MemoryRegion *ram_lo;
MemoryRegion *ram_hi = g_new(MemoryRegion, 1);
@@ -138,16 +137,15 @@ static void realview_init(MachineState *machine,
cpu_irq[n] = qdev_get_gpio_in(DEVICE(cpuobj), ARM_CPU_IRQ);
}
cpu = ARM_CPU(first_cpu);
- env = &cpu->env;
- if (arm_feature(env, ARM_FEATURE_V7)) {
+ if (arm_cpu_has_feature(cpu, ARM_FEATURE_V7)) {
if (is_mpcore) {
proc_id = 0x0c000000;
} else {
proc_id = 0x0e000000;
}
- } else if (arm_feature(env, ARM_FEATURE_V6K)) {
+ } else if (arm_cpu_has_feature(cpu, ARM_FEATURE_V6K)) {
proc_id = 0x06000000;
- } else if (arm_feature(env, ARM_FEATURE_V6)) {
+ } else if (arm_cpu_has_feature(cpu, ARM_FEATURE_V6)) {
proc_id = 0x04000000;
} else {
proc_id = 0x02000000;
--
2.47.1
next prev parent reply other threads:[~2025-04-02 22:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-02 22:23 [PATCH-for-10.1 00/13] arm: Spring header cleanups Philippe Mathieu-Daudé
2025-04-02 22:23 ` [PATCH-for-10.1 01/13] target/arm/cpu-features: Include missing 'cpu.h' header Philippe Mathieu-Daudé
2025-04-02 22:23 ` [PATCH-for-10.1 02/13] target/arm/qmp: " Philippe Mathieu-Daudé
2025-04-02 22:23 ` [PATCH-for-10.1 03/13] target/arm/kvm: Include missing 'cpu-qom.h' header Philippe Mathieu-Daudé
2025-04-02 22:23 ` [PATCH-for-10.1 04/13] target/arm/hvf: " Philippe Mathieu-Daudé
2025-04-02 22:23 ` [PATCH-for-10.1 05/13] hw/arm: Remove unnecessary 'cpu.h' header Philippe Mathieu-Daudé
2025-04-02 22:23 ` [PATCH-for-10.1 06/13] target/arm: Restrict inclusion of 'multiprocessing.h' Philippe Mathieu-Daudé
2025-04-02 22:23 ` [PATCH-for-10.1 07/13] target/arm: Move some definitions from 'cpu.h' to 'multiprocessing.h' Philippe Mathieu-Daudé
2025-04-02 22:23 ` [PATCH-for-10.1 08/13] hw/arm: Include missing 'target/arm/gtimer.h' header Philippe Mathieu-Daudé
2025-04-02 22:23 ` [PATCH-for-10.1 09/13] target/arm: Extract PSCI definitions to 'psci.h' Philippe Mathieu-Daudé
2025-04-02 22:23 ` [PATCH-for-10.1 10/13] target/arm: Extract feature definitions to 'cpu_has_feature.h' header Philippe Mathieu-Daudé
2025-04-02 22:23 ` [PATCH-for-10.1 11/13] target/arm: Add arm_cpu_has_feature() helper Philippe Mathieu-Daudé
2025-04-02 22:23 ` Philippe Mathieu-Daudé [this message]
2025-04-02 22:23 ` [PATCH-for-10.1 13/13] hw/arm/virt-acpi: Replace arm_feature() -> arm_cpu_has_feature() Philippe Mathieu-Daudé
2025-04-03 18:18 ` [PATCH-for-10.1 00/13] arm: Spring header cleanups Pierrick Bouvier
2025-04-03 18:22 ` Pierrick Bouvier
2025-04-03 19:31 ` Philippe Mathieu-Daudé
2025-04-03 20:51 ` Pierrick Bouvier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250402222334.66511-13-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).