From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Hanna Reitz <hreitz@redhat.com>, <qemu-block@nongnu.org>,
Fam Zheng <fam@euphon.net>, Stefan Hajnoczi <stefanha@redhat.com>,
Kevin Wolf <kwolf@redhat.com>
Subject: [PATCH v3 0/2] block: discard alignment fixes
Date: Mon, 14 Apr 2025 16:12:12 -0400 [thread overview]
Message-ID: <20250414201214.241351-1-stefanha@redhat.com> (raw)
v3:
- Refine error handling when pdiscard_alignment is not a multiple of request_alignment [Hanna]
v2:
- Fix inverted logic in alignment check [Qing Wang]
Two discard alignment issues were identified in
https://issues.redhat.com/browse/RHEL-86032:
1. pdiscard_alignment is not populated for host_device in file-posix.c.
2. Misaligned head/tail discard requests are not skipped when file-posix.c
returns -EINVAL. This causes an undesired pause when guests are configured
with werror=stop.
Stefan Hajnoczi (2):
file-posix: probe discard alignment on Linux block devices
block/io: skip head/tail requests on EINVAL
block/file-posix.c | 67 +++++++++++++++++++++++++++++++++++++++++++++-
block/io.c | 6 ++++-
2 files changed, 71 insertions(+), 2 deletions(-)
--
2.49.0
next reply other threads:[~2025-04-14 20:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-14 20:12 Stefan Hajnoczi [this message]
2025-04-14 20:12 ` [PATCH v3 1/2] file-posix: probe discard alignment on Linux block devices Stefan Hajnoczi
2025-04-17 16:27 ` Eric Blake
2025-04-17 16:31 ` Eric Blake
2025-04-14 20:12 ` [PATCH v3 2/2] block/io: skip head/tail requests on EINVAL Stefan Hajnoczi
2025-04-17 8:49 ` Kevin Wolf
2025-04-17 15:02 ` Stefan Hajnoczi
2025-04-17 15:32 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250414201214.241351-1-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=fam@euphon.net \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).