From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E8853C369B2 for ; Mon, 14 Apr 2025 20:13:34 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u4QAf-0002J8-Eq; Mon, 14 Apr 2025 16:12:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u4QAO-0002Fz-Ik for qemu-devel@nongnu.org; Mon, 14 Apr 2025 16:12:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u4QAM-0003Ok-NU for qemu-devel@nongnu.org; Mon, 14 Apr 2025 16:12:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744661545; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lnwvYU8wiln9Mjld4Smj0+Kw5Zx774dW9E8tIsCposI=; b=DhSqR0JMcOx1R1+D6Al2a77Fn/XyqO67uv0URLOs5WsNHH7qsgHZK4ShRpiCSo7CeJfKAN Kw+tlOrk5qs5yoOY5yH8JlT9GBzx3X6KNqlJ1+g4NzZD++J3wWfHxcc+i3qskTXjWU9R9p /XTM3rA+6ngxz5eaJhlOho3xfitLmPc= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-321--ontRR7EMt-wv4J1LKRBDg-1; Mon, 14 Apr 2025 16:12:19 -0400 X-MC-Unique: -ontRR7EMt-wv4J1LKRBDg-1 X-Mimecast-MFC-AGG-ID: -ontRR7EMt-wv4J1LKRBDg_1744661537 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2FF331800349; Mon, 14 Apr 2025 20:12:17 +0000 (UTC) Received: from localhost (unknown [10.2.16.100]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 29E071956094; Mon, 14 Apr 2025 20:12:15 +0000 (UTC) From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: Hanna Reitz , , Fam Zheng , Stefan Hajnoczi , Kevin Wolf Subject: [PATCH v3 0/2] block: discard alignment fixes Date: Mon, 14 Apr 2025 16:12:12 -0400 Message-ID: <20250414201214.241351-1-stefanha@redhat.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.129.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org v3: - Refine error handling when pdiscard_alignment is not a multiple of request_alignment [Hanna] v2: - Fix inverted logic in alignment check [Qing Wang] Two discard alignment issues were identified in https://issues.redhat.com/browse/RHEL-86032: 1. pdiscard_alignment is not populated for host_device in file-posix.c. 2. Misaligned head/tail discard requests are not skipped when file-posix.c returns -EINVAL. This causes an undesired pause when guests are configured with werror=stop. Stefan Hajnoczi (2): file-posix: probe discard alignment on Linux block devices block/io: skip head/tail requests on EINVAL block/file-posix.c | 67 +++++++++++++++++++++++++++++++++++++++++++++- block/io.c | 6 ++++- 2 files changed, 71 insertions(+), 2 deletions(-) -- 2.49.0