From: Jamin Lin via <qemu-devel@nongnu.org>
To: "Cédric Le Goater" <clg@kaod.org>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Steven Lee" <steven_lee@aspeedtech.com>,
"Troy Lee" <leetroy@gmail.com>,
"Andrew Jeffery" <andrew@codeconstruct.com.au>,
"Joel Stanley" <joel@jms.id.au>,
"open list:All patches CC here" <qemu-devel@nongnu.org>,
"open list:ASPEED BMCs" <qemu-arm@nongnu.org>
Cc: jamin_lin@aspeedtech.com, troy_lee@aspeedtech.com,
nabihestefan@google.com, "Cédric Le Goater" <clg@redhat.com>
Subject: [PATCH v4 01/10] hw/arm/aspeed_ast27x0: Rename variable sram_name to name in ast2700 realize
Date: Thu, 17 Apr 2025 11:11:58 +0800 [thread overview]
Message-ID: <20250417031209.2647703-2-jamin_lin@aspeedtech.com> (raw)
In-Reply-To: <20250417031209.2647703-1-jamin_lin@aspeedtech.com>
The variable "sram_name" was only used for naming the SRAM memory region.
Rename it to "name" for consistency with similar code and avoid unnecessary
new local variable declarations.
Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Tested-by: Nabih Estefan <nabihestefan@google.com>
---
hw/arm/aspeed_ast27x0.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/arm/aspeed_ast27x0.c b/hw/arm/aspeed_ast27x0.c
index dce7255a2c..b05ed75ff4 100644
--- a/hw/arm/aspeed_ast27x0.c
+++ b/hw/arm/aspeed_ast27x0.c
@@ -577,7 +577,7 @@ static void aspeed_soc_ast2700_realize(DeviceState *dev, Error **errp)
AspeedSoCClass *sc = ASPEED_SOC_GET_CLASS(s);
AspeedINTCClass *ic = ASPEED_INTC_GET_CLASS(&a->intc[0]);
AspeedINTCClass *icio = ASPEED_INTC_GET_CLASS(&a->intc[1]);
- g_autofree char *sram_name = NULL;
+ g_autofree char *name = NULL;
qemu_irq irq;
/* Default boot region (SPI memory or ROMs) */
@@ -649,9 +649,9 @@ static void aspeed_soc_ast2700_realize(DeviceState *dev, Error **errp)
}
/* SRAM */
- sram_name = g_strdup_printf("aspeed.sram.%d", CPU(&a->cpu[0])->cpu_index);
- if (!memory_region_init_ram(&s->sram, OBJECT(s), sram_name, sc->sram_size,
- errp)) {
+ name = g_strdup_printf("aspeed.sram.%d", CPU(&a->cpu[0])->cpu_index);
+ if (!memory_region_init_ram(&s->sram, OBJECT(s), name, sc->sram_size,
+ errp)) {
return;
}
memory_region_add_subregion(s->memory,
--
2.43.0
next prev parent reply other threads:[~2025-04-17 3:12 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-17 3:11 [PATCH v4 00/10] Support vbootrom for AST2700 Jamin Lin via
2025-04-17 3:11 ` Jamin Lin via [this message]
2025-04-17 3:11 ` [PATCH v4 02/10] hw/arm/aspeed_ast27x0 Introduce vbootrom memory region Jamin Lin via
2025-04-21 16:47 ` Cédric Le Goater
2025-04-22 1:59 ` Jamin Lin
2025-04-22 5:50 ` Cédric Le Goater
2025-04-21 21:03 ` Cédric Le Goater
2025-04-22 1:39 ` Jamin Lin
2025-04-17 3:12 ` [PATCH v4 03/10] hw/arm/aspeed: Add vbootrom support on AST2700 EVB machines Jamin Lin via
2025-04-17 3:12 ` [PATCH v4 04/10] hw/arm/aspeed: Reuse rom_size variable for vbootrom setup Jamin Lin via
2025-04-17 3:12 ` [PATCH v4 05/10] pc-bios: Add AST27x0 vBootrom Jamin Lin via
2025-04-17 3:12 ` [PATCH v4 06/10] hw/arm/aspeed: Add support for loading vbootrom image via "-bios" Jamin Lin via
2025-04-21 21:00 ` Cédric Le Goater
2025-04-22 3:30 ` Jamin Lin
2025-04-22 16:51 ` Cédric Le Goater
2025-04-23 7:02 ` Jamin Lin
2025-04-28 7:45 ` Cédric Le Goater
2025-04-28 7:54 ` Jamin Lin
2025-04-28 9:45 ` Philippe Mathieu-Daudé
2025-04-29 7:59 ` Jamin Lin
2025-04-17 3:12 ` [PATCH v4 07/10] tests/functional/aspeed: Move I2C test into shared helper for AST2700 reuse Jamin Lin via
2025-04-21 15:12 ` Nabih Estefan
2025-04-21 21:03 ` Cédric Le Goater
2025-04-17 3:12 ` [PATCH v4 08/10] tests/functional/aspeed: Update test ASPEED SDK v09.06 Jamin Lin via
2025-04-21 21:03 ` Cédric Le Goater
2025-04-22 7:05 ` Cédric Le Goater
2025-04-22 7:08 ` Jamin Lin
2025-04-17 3:12 ` [PATCH v4 09/10] tests/functional/aspeed: Add to test vbootrom for AST2700 Jamin Lin via
2025-04-21 15:12 ` Nabih Estefan
2025-04-21 21:07 ` Cédric Le Goater
2025-04-22 6:11 ` Jamin Lin
2025-04-17 3:12 ` [PATCH v4 10/10] docs/system/arm/aspeed: Support " Jamin Lin via
2025-04-22 7:29 ` Cédric Le Goater
2025-04-22 7:36 ` Jamin Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250417031209.2647703-2-jamin_lin@aspeedtech.com \
--to=qemu-devel@nongnu.org \
--cc=andrew@codeconstruct.com.au \
--cc=clg@kaod.org \
--cc=clg@redhat.com \
--cc=jamin_lin@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=leetroy@gmail.com \
--cc=nabihestefan@google.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=steven_lee@aspeedtech.com \
--cc=troy_lee@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).