qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: Fabiano Rosas <farosas@suse.de>
Cc: qemu-devel@nongnu.org, Peter Xu <peterx@redhat.com>
Subject: Migration compatibility test broken on major version releases
Date: Tue, 22 Apr 2025 11:41:31 -0400	[thread overview]
Message-ID: <20250422154131.GA308586@fedora> (raw)

[-- Attachment #1: Type: text/plain, Size: 1041 bytes --]

Hi Fabiano,
The build-previous-qemu job does not work when a new major version is
released:
https://gitlab.com/qemu-project/qemu/-/jobs/9788294494

The previous version computation produces "v10.0.0" when testing:

  $ export QEMU_PREV_VERSION="$(sed 's/\([0-9.]*\)\.[0-9]*/v␁.0/' VERSION)"
  $ git remote add upstream https://gitlab.com/qemu-project/qemu
  $ git fetch upstream refs/tags/$QEMU_PREV_VERSION:refs/tags/$QEMU_PREV_VERSION
  warning: redirecting to https://gitlab.com/qemu-project/qemu.git/
  fatal: couldn't find remote ref refs/tags/v10.0.0

The CI job runs before the v10.0.0 tag is pushed to the repo. (The tag
is only pushed once tests have passed.)

Even if the tag was there and git fetch succeeded, the test would test
migration between v10.0.0 and v10.0.0, which doesn't seem to be the
purpose of the test.

Please adjust the test to handle this situation. For now I will re-run
the job after pushing the final tag (since it already passed for the
release candidate tag).

Thanks!

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

             reply	other threads:[~2025-04-23 12:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-22 15:41 Stefan Hajnoczi [this message]
2025-04-23 17:01 ` Migration compatibility test broken on major version releases Fabiano Rosas
2025-04-23 22:05   ` Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250422154131.GA308586@fedora \
    --to=stefanha@redhat.com \
    --cc=farosas@suse.de \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).