From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Subject: [PULL 6/9] target/avr: Use cpu_stb_mmuidx_ra in helper_fullwr
Date: Tue, 22 Apr 2025 14:11:21 -0700 [thread overview]
Message-ID: <20250422211124.305724-7-richard.henderson@linaro.org> (raw)
In-Reply-To: <20250422211124.305724-1-richard.henderson@linaro.org>
Avoid direct use of address_space_memory.
Make use of the softmmu cache of the i/o page.
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/avr/helper.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/target/avr/helper.c b/target/avr/helper.c
index d0e86f5614..7d6954ec26 100644
--- a/target/avr/helper.c
+++ b/target/avr/helper.c
@@ -23,10 +23,10 @@
#include "qemu/error-report.h"
#include "cpu.h"
#include "accel/tcg/cpu-ops.h"
+#include "accel/tcg/getpc.h"
#include "exec/cputlb.h"
#include "exec/page-protection.h"
#include "exec/cpu_ldst.h"
-#include "exec/address-spaces.h"
#include "exec/helper-proto.h"
bool avr_cpu_exec_interrupt(CPUState *cs, int interrupt_request)
@@ -67,6 +67,11 @@ bool avr_cpu_exec_interrupt(CPUState *cs, int interrupt_request)
return false;
}
+static void do_stb(CPUAVRState *env, uint32_t addr, uint8_t data, uintptr_t ra)
+{
+ cpu_stb_mmuidx_ra(env, addr, data, MMU_DATA_IDX, ra);
+}
+
void avr_cpu_do_interrupt(CPUState *cs)
{
CPUAVRState *env = cpu_env(cs);
@@ -311,8 +316,7 @@ void helper_fullwr(CPUAVRState *env, uint32_t data, uint32_t addr)
break;
default:
- address_space_stb(&address_space_memory, OFFSET_DATA + addr, data,
- MEMTXATTRS_UNSPECIFIED, NULL);
+ do_stb(env, addr, data, GETPC());
break;
}
}
--
2.43.0
next prev parent reply other threads:[~2025-04-22 21:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-22 21:11 [PULL 0/9] target/avr: Increase TARGET_PAGE_BITS to 10 Richard Henderson
2025-04-22 21:11 ` [PULL 1/9] target/avr: Improve decode of LDS, STS Richard Henderson
2025-04-22 21:11 ` [PULL 2/9] target/avr: Remove OFFSET_CPU_REGISTERS Richard Henderson
2025-04-22 21:11 ` [PULL 3/9] target/avr: Add defines for i/o port registers Richard Henderson
2025-04-22 21:11 ` [PULL 4/9] target/avr: Move cpu register accesses into system memory Richard Henderson
2025-04-22 21:11 ` [PULL 5/9] target/avr: Remove NUMBER_OF_IO_REGISTERS Richard Henderson
2025-04-22 21:11 ` Richard Henderson [this message]
2025-04-22 21:11 ` [PULL 7/9] target/avr: Use do_stb in avr_cpu_do_interrupt Richard Henderson
2025-04-22 21:11 ` [PULL 8/9] hw/avr: Prepare for TARGET_PAGE_SIZE > 256 Richard Henderson
2025-04-22 21:11 ` [PULL 9/9] target/avr: Increase TARGET_PAGE_BITS to 10 Richard Henderson
2025-04-23 17:57 ` [PULL 0/9] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250422211124.305724-7-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).