From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Ewan Hai <ewanhai-oc@zhaoxin.com>
Subject: [PULL 02/34] target/i386: Fix model number of Zhaoxin YongFeng vCPU template
Date: Wed, 23 Apr 2025 11:40:32 +0200 [thread overview]
Message-ID: <20250423094105.40692-3-pbonzini@redhat.com> (raw)
In-Reply-To: <20250423094105.40692-1-pbonzini@redhat.com>
From: Ewan Hai <ewanhai-oc@zhaoxin.com>
The model number was mistakenly set to 0x0b (11) in commit ff04bc1ac4.
The correct value is 0x5b. This mistake occurred because the extended
model bits in cpuid[eax=0x1].eax were overlooked, and only the base
model was used.
Using the wrong model number can affect guest behavior. One known issue
is that vPMU (which relies on the model number) may fail to operate
correctly.
This patch corrects the model field by introducing a new vCPU version.
Fixes: ff04bc1ac4 ("target/i386: Introduce Zhaoxin Yongfeng CPU model")
Signed-off-by: Ewan Hai <ewanhai-oc@zhaoxin.com>
Link: https://lore.kernel.org/r/20250414075342.411626-1-ewanhai-oc@zhaoxin.com
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
target/i386/cpu.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index 1b64ceaaba4..3fb1ec62da1 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -5621,6 +5621,18 @@ static const X86CPUDefinition builtin_x86_defs[] = {
.features[FEAT_VMX_VMFUNC] = MSR_VMX_VMFUNC_EPT_SWITCHING,
.xlevel = 0x80000008,
.model_id = "Zhaoxin YongFeng Processor",
+ .versions = (X86CPUVersionDefinition[]) {
+ { .version = 1 },
+ {
+ .version = 2,
+ .note = "with the correct model number",
+ .props = (PropValue[]) {
+ { "model", "0x5b" },
+ { /* end of list */ }
+ }
+ },
+ { /* end of list */ }
+ }
},
};
--
2.49.0
next prev parent reply other threads:[~2025-04-23 9:42 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-23 9:40 [PULL 00/34] i386, Rust, SCSI changes for 2025-04-23 Paolo Bonzini
2025-04-23 9:40 ` [PULL 01/34] scsi: add conversion from ENODEV to sense Paolo Bonzini
2025-04-23 9:40 ` Paolo Bonzini [this message]
2025-04-23 9:40 ` [PULL 03/34] target/i386: Reset parked vCPUs together with the online ones Paolo Bonzini
2025-04-23 9:40 ` [PULL 04/34] target/i386/hvf: fix lflags_to_rflags Paolo Bonzini
2025-04-23 9:40 ` [PULL 05/34] target/i386: special case ADC/SBB x,0 and SBB x,x Paolo Bonzini
2025-04-23 9:40 ` [PULL 06/34] target/i386: tcg: remove tmp0 and tmp4 from SHLD/SHRD Paolo Bonzini
2025-04-23 9:40 ` [PULL 07/34] target/i386: tcg: remove subf from SHLD/SHRD expansion Paolo Bonzini
2025-04-23 9:40 ` [PULL 08/34] target/i386: tcg: remove tmp0 Paolo Bonzini
2025-04-23 9:40 ` [PULL 09/34] target/i386: tcg: remove some more uses of temporaries Paolo Bonzini
2025-04-23 9:40 ` [PULL 10/34] target/i386: tcg: simplify computation of AF after INC/DEC Paolo Bonzini
2025-04-23 9:40 ` [PULL 11/34] target/i386: emulate: microoptimize and explain ADD_COUT_VEC/SUB_COUT_VEC Paolo Bonzini
2025-04-23 9:40 ` [PULL 12/34] target/i386: tcg: use cout to commonize add/adc/sub/sbb cases Paolo Bonzini
2025-04-23 9:40 ` [PULL 13/34] target/i386/hvf: introduce x86_emul_ops Paolo Bonzini
2025-04-23 9:40 ` [PULL 14/34] target/i386/hvf: remove HVF specific calls from x86_decode.c Paolo Bonzini
2025-04-23 9:40 ` [PULL 15/34] target/i386/hvf: provide and use handle_io in emul_ops Paolo Bonzini
2025-04-23 9:40 ` [PULL 16/34] target/i386: rename hvf_mmio_buf to emu_mmio_buf Paolo Bonzini
2025-04-23 9:40 ` [PULL 17/34] target/i386/hvf: use emul_ops->read_mem in x86_emu.c Paolo Bonzini
2025-04-23 9:40 ` [PULL 18/34] target/i386/hvf: provide and use write_mem in emul_ops Paolo Bonzini
2025-04-23 9:40 ` [PULL 19/34] target/i386/hvf: provide and use simulate_{wrmsr, rdmsr} " Paolo Bonzini
2025-04-23 9:40 ` [PULL 20/34] target/i386: rename lazy flags field and its type Paolo Bonzini
2025-04-23 9:40 ` [PULL 21/34] target/i386/hvf: drop unused headers Paolo Bonzini
2025-04-23 9:40 ` [PULL 22/34] target/i386/hvf: rename some include guards Paolo Bonzini
2025-04-23 9:40 ` [PULL 23/34] target/i386: add a directory for x86 instruction emulator Paolo Bonzini
2025-04-23 9:40 ` [PULL 24/34] target/i386/emulate: add a panic.h Paolo Bonzini
2025-04-23 9:40 ` [PULL 25/34] target/i386: move x86 instruction emulator out of hvf Paolo Bonzini
2025-04-23 9:40 ` [PULL 26/34] MAINTAINERS: add an entry for the x86 instruction emulator Paolo Bonzini
2025-04-23 9:40 ` [PULL 27/34] target/i386/emulate: remove flags_mask Paolo Bonzini
2025-04-23 9:40 ` [PULL 28/34] i386/cpu: Consolidate the helper to get Host's vendor Paolo Bonzini
2025-04-23 9:40 ` [PULL 29/34] rust/hpet: convert num_timers to u8 type Paolo Bonzini
2025-04-23 9:41 ` [PULL 30/34] rust/hpet: convert HPETTimer index " Paolo Bonzini
2025-04-23 9:41 ` [PULL 31/34] rust/hpet: Fix a clippy error Paolo Bonzini
2025-04-23 9:41 ` [PULL 32/34] rust/vmstate_test: Fix typo in test_vmstate_macro_array_of_pointer_wrapped() Paolo Bonzini
2025-04-23 9:41 ` [PULL 33/34] rust/hw/char/pl011: Extract extract DR read logic into separate function Paolo Bonzini
2025-04-23 9:41 ` [PULL 34/34] rust/hw/char/pl011: Extract DR write " Paolo Bonzini
2025-04-23 17:58 ` [PULL 00/34] i386, Rust, SCSI changes for 2025-04-23 Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250423094105.40692-3-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=ewanhai-oc@zhaoxin.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).