qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org, Richard Henderson <richard.henderson@linaro.org>
Cc: "Pierrick Bouvier" <pierrick.bouvier@linaro.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH v2 04/13] include/exec: Include missing headers in exec-all.h
Date: Thu, 24 Apr 2025 11:46:44 +0200	[thread overview]
Message-ID: <20250424094653.35932-5-philmd@linaro.org> (raw)
In-Reply-To: <20250424094653.35932-1-philmd@linaro.org>

"exec/exec-all.h" declares prototypes such:

  void *probe_access(CPUArchState *env, vaddr addr, int size,
                                        ^^^^^
                     MMUAccessType access_type, int mmu_idx,
                     uintptr_t retaddr);
  MemoryRegionSection *iotlb_to_section(CPUState *cpu,
                                        hwaddr index,
                                        ^^^^^^
                                        MemTxAttrs attrs);
                                        ^^^^^^^^^^

vaddr is defined in "exec/vaddr.h", hwaddr in "exec/hwaddr.h"
and MemTxAttrs in "exec/memattrs.h". All these headers are
indirectly pulled in via "exec/translation-block.h". Since
we will remove "exec/translation-block.h" in the next commit,
include the missing ones, otherwise we'd get errors such:

  include/exec/exec-all.h:51:1: error: unknown type name 'hwaddr'
     51 | hwaddr memory_region_section_get_iotlb(CPUState *cpu,
        | ^

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 include/exec/exec-all.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h
index 24383b6abad..c46255e66ef 100644
--- a/include/exec/exec-all.h
+++ b/include/exec/exec-all.h
@@ -20,8 +20,11 @@
 #ifndef EXEC_ALL_H
 #define EXEC_ALL_H
 
+#include "exec/hwaddr.h"
+#include "exec/memattrs.h"
 #include "exec/mmu-access-type.h"
 #include "exec/translation-block.h"
+#include "exec/vaddr.h"
 
 #if defined(CONFIG_TCG)
 #include "accel/tcg/getpc.h"
-- 
2.47.1



  parent reply	other threads:[~2025-04-24  9:48 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-24  9:46 [PATCH v2 00/13] include: Remove "exec/exec-all.h" Philippe Mathieu-Daudé
2025-04-24  9:46 ` [PATCH v2 01/13] accel/tcg: Use vaddr for walk_memory_regions callback Philippe Mathieu-Daudé
2025-04-24  9:46 ` [PATCH v2 02/13] accel/tcg: Use vaddr in user/page-protection.h Philippe Mathieu-Daudé
2025-04-24  9:46 ` [PATCH v2 03/13] accel/tcg: Correct list of included headers in tcg-stub.c Philippe Mathieu-Daudé
2025-04-24 10:10   ` Mark Cave-Ayland
2025-04-24  9:46 ` Philippe Mathieu-Daudé [this message]
2025-04-24 10:11   ` [PATCH v2 04/13] include/exec: Include missing headers in exec-all.h Mark Cave-Ayland
2025-04-24  9:46 ` [PATCH v2 05/13] include/exec: Move tb_invalidate_phys_range to translation-block.h Philippe Mathieu-Daudé
2025-04-24  9:46 ` [PATCH v2 06/13] accel/tcg: Compile tb-maint.c twice Philippe Mathieu-Daudé
2025-04-24  9:46 ` [PATCH v2 07/13] target/riscv: Include missing 'accel/tcg/getpc.h' in csr.c Philippe Mathieu-Daudé
2025-04-24  9:50   ` Philippe Mathieu-Daudé
2025-04-24 10:14   ` Mark Cave-Ayland
2025-04-24 20:13     ` Philippe Mathieu-Daudé
2025-04-24 21:01       ` Richard Henderson
2025-04-24 10:23   ` Alistair Francis
2025-04-24  9:46 ` [PATCH v2 08/13] target/hexagon: Include missing 'accel/tcg/getpc.h' Philippe Mathieu-Daudé
2025-04-24 10:15   ` Mark Cave-Ayland
2025-04-24 14:35   ` Brian Cain
2025-04-24  9:46 ` [PATCH v2 09/13] accel/tcg: Include 'accel/tcg/getpc.h' in 'exec/helper-proto' Philippe Mathieu-Daudé
2025-04-24 10:21   ` Mark Cave-Ayland
2025-04-24 11:23     ` Philippe Mathieu-Daudé
2025-04-24 20:09       ` Philippe Mathieu-Daudé
2025-04-24  9:46 ` [PATCH v2 10/13] physmem: Move TCG IOMMU methods around Philippe Mathieu-Daudé
2025-04-24 10:23   ` Mark Cave-Ayland
2025-04-24  9:46 ` [PATCH v2 11/13] physmem: Restrict TCG IOMMU code to TCG accel Philippe Mathieu-Daudé
2025-04-24 10:25   ` Mark Cave-Ayland
2025-04-24  9:46 ` [PATCH v2 12/13] accel/tcg: Extract probe API out of 'exec/exec-all.h' Philippe Mathieu-Daudé
2025-04-24  9:50   ` Philippe Mathieu-Daudé
2025-04-24 10:30   ` Mark Cave-Ayland
2025-04-24 17:21   ` Richard Henderson
2025-04-24  9:46 ` [PATCH v2 13/13] include: Remove 'exec/exec-all.h' Philippe Mathieu-Daudé
2025-04-24 10:32   ` Mark Cave-Ayland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250424094653.35932-5-philmd@linaro.org \
    --to=philmd@linaro.org \
    --cc=pbonzini@redhat.com \
    --cc=pierrick.bouvier@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).