From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: John Snow <jsnow@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Michael Roth <michael.roth@amd.com>,
Cleber Rosa <crosa@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>
Subject: [PATCH v3 0/6] python: add QAPI and qapidoc et al to python linter tests
Date: Thu, 24 Apr 2025 17:08:58 -0400 [thread overview]
Message-ID: <20250424210904.2505114-1-jsnow@redhat.com> (raw)
Hiya, this series turns on automated linting for scripts/qapi,
docs/sphinx/qapidoc.py and docs/sphinx/qapi_domain.py.
This includes flake8/isort/pylint/mypy for scripts/qapi, but omits mypy
from the Sphinx plugins owing to my inability to strictly type the
extensions given the wide versions of Sphinx we actually support.
Though I have been using black in my own development, I have not yet
enabled it anywhere automatically. Maybe soon.
NOTE: the latest Fedora image doesn't have Python38 anymore; this series
does not address that. A more substantial fix for testing will be
forthcoming.
V3:
- Folded in Markus's commit to clean up setup.cfg.
V2:
- Mostly commit message updates based on Markus's's's review.
John Snow (5):
qapi: Add some pylint ignores
docs/qapidoc: linting fixes
python: update missing dependencies from minreqs
python: add qapi static analysis tests
qapi: delete un-needed python static analysis configs
Markus Armbruster (1):
python: Drop redundant warn_unused_configs = True
docs/sphinx/qapi_domain.py | 25 ++++++++++++++-----------
docs/sphinx/qapidoc.py | 5 +++--
python/setup.cfg | 2 +-
python/tests/minreqs.txt | 25 +++++++++++++++++++++++++
python/tests/qapi-flake8.sh | 4 ++++
python/tests/qapi-isort.sh | 6 ++++++
python/tests/qapi-mypy.sh | 2 ++
python/tests/qapi-pylint.sh | 6 ++++++
scripts/qapi/.flake8 | 3 ---
scripts/qapi/.isort.cfg | 7 -------
scripts/qapi/backend.py | 2 ++
scripts/qapi/mypy.ini | 4 ----
scripts/qapi/pylintrc | 1 +
13 files changed, 64 insertions(+), 28 deletions(-)
create mode 100755 python/tests/qapi-flake8.sh
create mode 100755 python/tests/qapi-isort.sh
create mode 100755 python/tests/qapi-mypy.sh
create mode 100755 python/tests/qapi-pylint.sh
delete mode 100644 scripts/qapi/.flake8
delete mode 100644 scripts/qapi/.isort.cfg
delete mode 100644 scripts/qapi/mypy.ini
--
2.48.1
next reply other threads:[~2025-04-24 21:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-24 21:08 John Snow [this message]
2025-04-24 21:08 ` [PATCH v3 1/6] qapi: Add some pylint ignores John Snow
2025-04-24 21:09 ` [PATCH v3 2/6] docs/qapidoc: linting fixes John Snow
2025-04-24 21:09 ` [PATCH v3 3/6] python: update missing dependencies from minreqs John Snow
2025-04-24 21:09 ` [PATCH v3 4/6] python: add qapi static analysis tests John Snow
2025-04-24 21:09 ` [PATCH v3 5/6] python: Drop redundant warn_unused_configs = True John Snow
2025-04-24 21:09 ` [PATCH v3 6/6] qapi: delete un-needed python static analysis configs John Snow
2025-04-25 6:11 ` [PATCH v3 0/6] python: add QAPI and qapidoc et al to python linter tests Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250424210904.2505114-1-jsnow@redhat.com \
--to=jsnow@redhat.com \
--cc=armbru@redhat.com \
--cc=crosa@redhat.com \
--cc=michael.roth@amd.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).