From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Pierrick Bouvier" <pierrick.bouvier@linaro.org>
Subject: [PULL 52/58] cpus: Replace CPU_RESOLVING_TYPE -> target_cpu_type()
Date: Fri, 25 Apr 2025 17:28:36 +0200 [thread overview]
Message-ID: <20250425152843.69638-53-philmd@linaro.org> (raw)
In-Reply-To: <20250425152843.69638-1-philmd@linaro.org>
Replace the target-specific CPU_RESOLVING_TYPE definition
by a call to the target-agnostic target_cpu_type() runtime
helper.
Since the big "cpu.h" is not required anymore in tcg-all.c,
remove it, using the tinier "cpu-param.h" header.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Message-Id: <20250417165430.58213-3-philmd@linaro.org>
---
accel/accel-target.c | 6 ++++--
accel/tcg/tcg-all.c | 5 +++--
cpu-target.c | 7 ++++---
3 files changed, 11 insertions(+), 7 deletions(-)
diff --git a/accel/accel-target.c b/accel/accel-target.c
index 33a539b4cbb..08d4e450bde 100644
--- a/accel/accel-target.c
+++ b/accel/accel-target.c
@@ -25,6 +25,7 @@
#include "qemu/osdep.h"
#include "qemu/accel.h"
+#include "qemu/target-info.h"
#include "cpu.h"
#include "accel/accel-cpu-target.h"
@@ -88,17 +89,18 @@ static void accel_init_cpu_interfaces(AccelClass *ac)
const char *ac_name; /* AccelClass name */
char *acc_name; /* AccelCPUClass name */
ObjectClass *acc; /* AccelCPUClass */
+ const char *cpu_resolving_type = target_cpu_type();
ac_name = object_class_get_name(OBJECT_CLASS(ac));
g_assert(ac_name != NULL);
- acc_name = g_strdup_printf("%s-%s", ac_name, CPU_RESOLVING_TYPE);
+ acc_name = g_strdup_printf("%s-%s", ac_name, cpu_resolving_type);
acc = object_class_by_name(acc_name);
g_free(acc_name);
if (acc) {
object_class_foreach(accel_init_cpu_int_aux,
- CPU_RESOLVING_TYPE, false, acc);
+ cpu_resolving_type, false, acc);
}
}
diff --git a/accel/tcg/tcg-all.c b/accel/tcg/tcg-all.c
index 40d73649796..0ce34ac912c 100644
--- a/accel/tcg/tcg-all.c
+++ b/accel/tcg/tcg-all.c
@@ -35,6 +35,7 @@
#include "qapi/qapi-types-common.h"
#include "qapi/qapi-builtin-visit.h"
#include "qemu/units.h"
+#include "qemu/target-info.h"
#if defined(CONFIG_USER_ONLY)
#include "hw/qdev-core.h"
#else
@@ -43,7 +44,7 @@
#endif
#include "accel/tcg/cpu-ops.h"
#include "internal-common.h"
-#include "cpu.h"
+#include "cpu-param.h"
struct TCGState {
@@ -89,7 +90,7 @@ static int tcg_init_machine(MachineState *ms)
unsigned max_threads = 1;
#ifndef CONFIG_USER_ONLY
- CPUClass *cc = CPU_CLASS(object_class_by_name(CPU_RESOLVING_TYPE));
+ CPUClass *cc = CPU_CLASS(object_class_by_name(target_cpu_type()));
bool mttcg_supported = cc->tcg_ops->mttcg_supported;
switch (s->mttcg_enabled) {
diff --git a/cpu-target.c b/cpu-target.c
index d68cbab5da9..c2dd590d48a 100644
--- a/cpu-target.c
+++ b/cpu-target.c
@@ -22,6 +22,7 @@
#include "qapi/error.h"
#include "qemu/error-report.h"
#include "qemu/qemu-print.h"
+#include "qemu/target-info.h"
#include "system/accel-ops.h"
#include "system/cpus.h"
#include "exec/cpu-common.h"
@@ -37,7 +38,7 @@ QEMU_BUILD_BUG_ON(offsetof(ArchCPU, env) != sizeof(CPUState));
char *cpu_model_from_type(const char *typename)
{
- const char *suffix = "-" CPU_RESOLVING_TYPE;
+ g_autofree char *suffix = g_strdup_printf("-%s", target_cpu_type());
if (!object_class_by_name(typename)) {
return NULL;
@@ -63,7 +64,7 @@ const char *parse_cpu_option(const char *cpu_option)
exit(1);
}
- oc = cpu_class_by_name(CPU_RESOLVING_TYPE, model_pieces[0]);
+ oc = cpu_class_by_name(target_cpu_type(), model_pieces[0]);
if (oc == NULL) {
error_report("unable to find CPU model '%s'", model_pieces[0]);
g_strfreev(model_pieces);
@@ -92,7 +93,7 @@ static void cpu_list_entry(gpointer data, gpointer user_data)
void list_cpus(void)
{
- CPUClass *cc = CPU_CLASS(object_class_by_name(CPU_RESOLVING_TYPE));
+ CPUClass *cc = CPU_CLASS(object_class_by_name(target_cpu_type()));
if (cc->list_cpus) {
cc->list_cpus();
--
2.47.1
next prev parent reply other threads:[~2025-04-25 15:36 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-25 15:27 [PULL 00/58] Misc single binary patches for 2025-04-25 Philippe Mathieu-Daudé
2025-04-25 15:27 ` [PULL 01/58] target/hexagon: Explode MO_TExx -> MO_TE | MO_xx Philippe Mathieu-Daudé
2025-04-25 15:27 ` [PULL 02/58] target/hexagon: Replace MO_TE -> MO_LE Philippe Mathieu-Daudé
2025-04-25 15:27 ` [PULL 03/58] target/i386: Replace MO_TE* -> MO_LE* Philippe Mathieu-Daudé
2025-04-25 15:27 ` [PULL 04/58] cpus: Introduce CPUClass::list_cpus() callback Philippe Mathieu-Daudé
2025-04-25 15:27 ` [PULL 05/58] target/i386: Register CPUClass:list_cpus Philippe Mathieu-Daudé
2025-04-25 15:27 ` [PULL 06/58] target/ppc: " Philippe Mathieu-Daudé
2025-04-25 15:27 ` [PULL 07/58] target/sparc: " Philippe Mathieu-Daudé
2025-04-25 15:27 ` [PULL 08/58] target/s390x: " Philippe Mathieu-Daudé
2025-04-25 15:27 ` [PULL 09/58] cpus: Remove #ifdef check on cpu_list definition Philippe Mathieu-Daudé
2025-04-25 15:27 ` [PULL 10/58] hw/pci-host/designware: Use deposit/extract API Philippe Mathieu-Daudé
2025-04-25 15:27 ` [PULL 11/58] hw/misc/edu: Convert type_init() -> DEFINE_TYPES() Philippe Mathieu-Daudé
2025-04-25 15:27 ` [PULL 12/58] qom: Have class_base_init() take a const data argument Philippe Mathieu-Daudé
2025-04-25 15:27 ` [PULL 14/58] qom: Constify TypeInfo::class_data Philippe Mathieu-Daudé
2025-04-25 15:27 ` [PULL 15/58] qom: Constify TypeInfo::interfaces Philippe Mathieu-Daudé
2025-04-25 15:28 ` [PULL 16/58] qom: Make InterfaceInfo[] uses const Philippe Mathieu-Daudé
2025-04-25 15:28 ` [PULL 17/58] qom/object: Fix type conflict of GLib function pointers Philippe Mathieu-Daudé
2025-04-25 15:28 ` [PULL 18/58] hw/core: Get default_cpu_type calling machine_class_default_cpu_type() Philippe Mathieu-Daudé
2025-04-25 15:28 ` [PULL 19/58] hw/core/cpu: gdb_arch_name string should not be freed Philippe Mathieu-Daudé
2025-04-25 15:28 ` [PULL 20/58] gdbstub: Allow gdb_core_xml_file to be set at runtime Philippe Mathieu-Daudé
2025-04-25 15:28 ` [PULL 21/58] target/arm: Handle AArch64 in TYPE_ARM_CPU gdb_arch_name Philippe Mathieu-Daudé
2025-04-25 15:28 ` [PULL 22/58] target/arm: Handle gdb_core_xml_file in TYPE_ARM_CPU Philippe Mathieu-Daudé
2025-04-25 15:28 ` [PULL 23/58] target/arm: Handle AArch64 gdb read/write regs " Philippe Mathieu-Daudé
2025-04-25 15:28 ` [PULL 24/58] target/arm: Replace target_ulong -> hwaddr in ARMMMUFaultInfo Philippe Mathieu-Daudé
2025-04-25 15:28 ` [PULL 25/58] target/arm: Replace target_ulong -> vaddr for CPUWatchpoint Philippe Mathieu-Daudé
2025-04-25 15:28 ` [PULL 26/58] target/mips: Fix MIPS16e translation Philippe Mathieu-Daudé
2025-04-25 15:28 ` [PULL 27/58] exec: Rename target_words_bigendian() -> target_big_endian() Philippe Mathieu-Daudé
2025-04-25 15:28 ` [PULL 28/58] hw/usb/hcd-xhci: Unmap canceled packet Philippe Mathieu-Daudé
2025-04-25 15:28 ` [PULL 29/58] hw/intc/i8259: Remove unused DEBUG_PIC define Philippe Mathieu-Daudé
2025-04-25 15:28 ` [PULL 30/58] hw/core/loader: Fix type conflict of GLib function pointers Philippe Mathieu-Daudé
2025-04-25 15:28 ` [PULL 31/58] hw/net/can: " Philippe Mathieu-Daudé
2025-04-25 15:28 ` [PULL 32/58] contrib/plugins: " Philippe Mathieu-Daudé
2025-04-25 15:28 ` [PULL 33/58] system/vl: " Philippe Mathieu-Daudé
2025-04-25 15:28 ` [PULL 34/58] system/memory: Remove DEVICE_HOST_ENDIAN definition Philippe Mathieu-Daudé
2025-04-25 15:28 ` [PULL 35/58] system/datadir: Add new type constant for DTB files Philippe Mathieu-Daudé
2025-04-25 15:28 ` [PULL 36/58] pc-bios: Move device tree files in their own subdir Philippe Mathieu-Daudé
2025-05-29 18:18 ` Bernhard Beschow
2025-05-30 0:54 ` BALATON Zoltan
2025-06-02 8:12 ` Philippe Mathieu-Daudé
2025-06-02 11:56 ` BALATON Zoltan
2025-06-03 11:25 ` Philippe Mathieu-Daudé
2025-06-03 6:39 ` Bernhard Beschow
2025-06-03 11:38 ` Thomas Huth
2025-06-04 9:59 ` Bernhard Beschow
2025-06-10 20:54 ` Bernhard Beschow
2025-06-03 12:58 ` BALATON Zoltan
2025-04-25 15:28 ` [PULL 37/58] meson: Use has_header_symbol() to check getcpu() Philippe Mathieu-Daudé
2025-04-25 15:28 ` [PULL 38/58] meson: Remove CONFIG_STATX and CONFIG_STATX_MNT_ID Philippe Mathieu-Daudé
2025-04-25 15:28 ` [PULL 39/58] meson: Share common C source prefixes Philippe Mathieu-Daudé
2025-04-25 15:28 ` [PULL 40/58] meson: Use osdep_prefix for strchrnul() Philippe Mathieu-Daudé
2025-04-25 15:28 ` [PULL 41/58] system/kvm: make functions accessible from common code Philippe Mathieu-Daudé
2025-04-25 15:28 ` [PULL 42/58] accel/tcg: Correct list of included headers in tcg-stub.c Philippe Mathieu-Daudé
2025-04-25 15:28 ` [PULL 43/58] target/hexagon: Include missing 'accel/tcg/getpc.h' Philippe Mathieu-Daudé
2025-04-25 15:28 ` [PULL 44/58] linux-user/elfload: Use target_needs_bswap() Philippe Mathieu-Daudé
2025-04-25 15:28 ` [PULL 45/58] accel/kvm: " Philippe Mathieu-Daudé
2025-04-25 15:28 ` [PULL 46/58] target/mips: Check CPU endianness at runtime using env_is_bigendian() Philippe Mathieu-Daudé
2025-04-25 15:28 ` [PULL 47/58] target/xtensa: Evaluate TARGET_BIG_ENDIAN at compile time Philippe Mathieu-Daudé
2025-04-25 15:28 ` [PULL 48/58] hw/mips: " Philippe Mathieu-Daudé
2025-04-25 15:28 ` [PULL 49/58] hw/microblaze: " Philippe Mathieu-Daudé
2025-04-25 15:28 ` [PULL 50/58] qapi: Rename TargetInfo structure as QemuTargetInfo Philippe Mathieu-Daudé
2025-04-25 15:28 ` [PULL 51/58] qemu: Introduce target_cpu_type() Philippe Mathieu-Daudé
2025-04-25 15:28 ` Philippe Mathieu-Daudé [this message]
2025-04-25 15:28 ` [PULL 53/58] cpus: Move target-agnostic methods out of cpu-target.c Philippe Mathieu-Daudé
2025-04-25 15:28 ` [PULL 54/58] accel: Implement accel_init_ops_interfaces() for both system/user mode Philippe Mathieu-Daudé
2025-04-25 15:28 ` [PULL 55/58] accel: Include missing 'qemu/accel.h' header in accel-internal.h Philippe Mathieu-Daudé
2025-04-25 15:28 ` [PULL 56/58] accel: Make AccelCPUClass structure target-agnostic Philippe Mathieu-Daudé
2025-04-25 15:28 ` [PULL 57/58] accel: Move target-agnostic code from accel-target.c -> accel-common.c Philippe Mathieu-Daudé
2025-04-25 15:28 ` [PULL 58/58] qemu: Convert target_name() to TargetInfo API Philippe Mathieu-Daudé
2025-04-28 17:56 ` [PULL 00/58] Misc single binary patches for 2025-04-25 Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250425152843.69638-53-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).