* [PATCH] target/i386/hvf: Include missing 'exec/target_page.h' header
@ 2025-04-25 17:43 Philippe Mathieu-Daudé
2025-04-25 17:51 ` Pierrick Bouvier
0 siblings, 1 reply; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-04-25 17:43 UTC (permalink / raw)
To: qemu-devel
Cc: Cameron Esfahani, Roman Bolshakov, Phil Dennis-Jordan,
Richard Henderson, Philippe Mathieu-Daudé, Pierrick Bouvier
Include "exec/target_page.h" to be able to compile HVF on x86_64:
../target/i386/hvf/hvf.c:139:49: error: use of undeclared identifier 'TARGET_PAGE_SIZE'
uint64_t dirty_page_start = gpa & ~(TARGET_PAGE_SIZE - 1u);
^
../target/i386/hvf/hvf.c:141:45: error: use of undeclared identifier 'TARGET_PAGE_SIZE'
hv_vm_protect(dirty_page_start, TARGET_PAGE_SIZE,
Fixes: 9c2ff9cdc9b ("exec/cpu-all: remove exec/target_page include")
Reported-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
target/i386/hvf/hvf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/target/i386/hvf/hvf.c b/target/i386/hvf/hvf.c
index 23ebf2550ac..da1dc66da07 100644
--- a/target/i386/hvf/hvf.c
+++ b/target/i386/hvf/hvf.c
@@ -50,6 +50,7 @@
#include "qemu/error-report.h"
#include "qemu/memalign.h"
#include "qapi/error.h"
+#include "exec/target_page.h"
#include "migration/blocker.h"
#include "system/hvf.h"
--
2.47.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] target/i386/hvf: Include missing 'exec/target_page.h' header
2025-04-25 17:43 [PATCH] target/i386/hvf: Include missing 'exec/target_page.h' header Philippe Mathieu-Daudé
@ 2025-04-25 17:51 ` Pierrick Bouvier
0 siblings, 0 replies; 2+ messages in thread
From: Pierrick Bouvier @ 2025-04-25 17:51 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Cameron Esfahani, Roman Bolshakov, Phil Dennis-Jordan,
Richard Henderson
On 4/25/25 10:43, Philippe Mathieu-Daudé wrote:
> Include "exec/target_page.h" to be able to compile HVF on x86_64:
>
> ../target/i386/hvf/hvf.c:139:49: error: use of undeclared identifier 'TARGET_PAGE_SIZE'
> uint64_t dirty_page_start = gpa & ~(TARGET_PAGE_SIZE - 1u);
> ^
> ../target/i386/hvf/hvf.c:141:45: error: use of undeclared identifier 'TARGET_PAGE_SIZE'
> hv_vm_protect(dirty_page_start, TARGET_PAGE_SIZE,
>
> Fixes: 9c2ff9cdc9b ("exec/cpu-all: remove exec/target_page include")
> Reported-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> target/i386/hvf/hvf.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/target/i386/hvf/hvf.c b/target/i386/hvf/hvf.c
> index 23ebf2550ac..da1dc66da07 100644
> --- a/target/i386/hvf/hvf.c
> +++ b/target/i386/hvf/hvf.c
> @@ -50,6 +50,7 @@
> #include "qemu/error-report.h"
> #include "qemu/memalign.h"
> #include "qapi/error.h"
> +#include "exec/target_page.h"
> #include "migration/blocker.h"
>
> #include "system/hvf.h"
Thanks for the patch Philippe,
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-04-25 17:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-25 17:43 [PATCH] target/i386/hvf: Include missing 'exec/target_page.h' header Philippe Mathieu-Daudé
2025-04-25 17:51 ` Pierrick Bouvier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).