From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: pierrick.bouvier@linaro.org, philmd@linaro.org
Subject: [PATCH 02/10] accel/tcg: Unconditionally use CPU_DUMP_CCOP in log_cpu_exec
Date: Mon, 28 Apr 2025 13:10:20 -0700 [thread overview]
Message-ID: <20250428201028.1699157-3-richard.henderson@linaro.org> (raw)
In-Reply-To: <20250428201028.1699157-1-richard.henderson@linaro.org>
This flag is only tested by target/i386, so including this
makes no functional change. This is similar to other places
like cpu-target.c which use CPU_DUMP_CCOP unconditionally.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
We could just as easily remove CPU_DUMP_CCOP entirely, and let
target/i386 dump CCOP along with general regs like other targets.
---
accel/tcg/cpu-exec.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c
index 8ff4a34509..ff979a2c57 100644
--- a/accel/tcg/cpu-exec.c
+++ b/accel/tcg/cpu-exec.c
@@ -285,14 +285,11 @@ static void log_cpu_exec(vaddr pc, CPUState *cpu,
if (qemu_loglevel_mask(CPU_LOG_TB_CPU)) {
FILE *logfile = qemu_log_trylock();
if (logfile) {
- int flags = 0;
+ int flags = CPU_DUMP_CCOP;
if (qemu_loglevel_mask(CPU_LOG_TB_FPU)) {
flags |= CPU_DUMP_FPU;
}
-#if defined(TARGET_I386)
- flags |= CPU_DUMP_CCOP;
-#endif
if (qemu_loglevel_mask(CPU_LOG_TB_VPU)) {
flags |= CPU_DUMP_VPU;
}
--
2.43.0
next prev parent reply other threads:[~2025-04-28 20:11 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-28 20:10 [PATCH 00/10] accel/tcg: Compile cpu-exec.c twice Richard Henderson
2025-04-28 20:10 ` [PATCH 01/10] accel/tcg: Generalize fake_user_interrupt test Richard Henderson
2025-04-28 21:36 ` Pierrick Bouvier
2025-04-29 6:45 ` Philippe Mathieu-Daudé
2025-04-28 20:10 ` Richard Henderson [this message]
2025-04-28 21:37 ` [PATCH 02/10] accel/tcg: Unconditionally use CPU_DUMP_CCOP in log_cpu_exec Pierrick Bouvier
2025-04-28 20:10 ` [PATCH 03/10] accel/tcg: Introduce TCGCPUOps.cpu_exec_reset Richard Henderson
2025-04-28 21:38 ` Pierrick Bouvier
2025-04-29 6:44 ` Philippe Mathieu-Daudé
2025-04-29 19:53 ` Richard Henderson
2025-04-28 20:10 ` [PATCH 04/10] target/i386: Split out x86_cpu_exec_reset Richard Henderson
2025-04-28 21:40 ` Pierrick Bouvier
2025-04-28 20:10 ` [PATCH 05/10] accel/tcg: Hoist cpu_get_tb_cpu_state decl to accl/tcg/cpu-ops.h Richard Henderson
2025-04-28 21:43 ` Pierrick Bouvier
2025-04-28 20:10 ` [PATCH 06/10] target/riscv: Move cpu_get_tb_cpu_state to tcg-cpu.c Richard Henderson
2025-04-28 21:41 ` Pierrick Bouvier
2025-04-29 6:39 ` Philippe Mathieu-Daudé
2025-04-29 20:00 ` Richard Henderson
2025-04-28 20:10 ` [PATCH 07/10] accel/tcg: Return TCGTBCPUState from cpu_get_tb_cpu_state Richard Henderson
2025-04-28 22:00 ` Pierrick Bouvier
2025-04-28 22:07 ` Richard Henderson
2025-04-28 22:26 ` Pierrick Bouvier
2025-04-28 22:37 ` Richard Henderson
2025-04-29 18:55 ` Richard Henderson
2025-04-29 19:04 ` Pierrick Bouvier
2025-04-28 20:10 ` [PATCH 08/10] accel/tcg: Move cpu_get_tb_cpu_state to TCGCPUOps Richard Henderson
2025-04-28 21:49 ` Pierrick Bouvier
2025-04-28 20:10 ` [PATCH 09/10] accel/tcg: Split out accel/tcg/helper-retaddr.h Richard Henderson
2025-04-28 21:48 ` Pierrick Bouvier
2025-04-29 6:41 ` Philippe Mathieu-Daudé
2025-04-28 20:10 ` [PATCH 10/10] accel/tcg: Compile cpu-exec.c twice Richard Henderson
2025-04-28 21:41 ` Pierrick Bouvier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250428201028.1699157-3-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=philmd@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).